In D94891#2506122, @MyDeveloperDay wrote:

In D94891#2505736, @ChuanqiXu wrote:

@231084fg may I ask why you remove the reviews for the patch?

This person is user since only 15th Jan, I'm beginning to think they may be malicious!

@hans , @rsmith , @benhamilton anyone mind if I disable this users account? they seem to be randomly going through phabricator making changes which seem to be unrelated.

Their email is also not verified.

Jan 19 2021, 8:43 AM · Unknown Object (Project)

Jan 8 2021

benhamilton empowered ldionne as an administrator.

Jan 8 2021, 1:42 PM

Oct 16 2020

benhamilton committed rG24b5266892c3: [Format/ObjC] Correctly handle base class with lightweight generics and protocol (authored by benhamilton).

[Format/ObjC] Correctly handle base class with lightweight generics and protocol

Oct 16 2020, 2:12 PM

benhamilton closed D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol.

Oct 16 2020, 2:12 PM · Restricted Project

Oct 15 2020

benhamilton requested review of D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol.

Oct 15 2020, 2:10 PM · Restricted Project

Oct 14 2020

benhamilton committed rGe7b4feea8e1b: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to… (authored by benhamilton).

[Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to…

Oct 14 2020, 2:44 PM

benhamilton closed D89425: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to WhitespaceSensitiveMacros.

Oct 14 2020, 2:44 PM · Unknown Object (Project), Restricted Project

benhamilton requested review of D89425: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to WhitespaceSensitiveMacros.

Oct 14 2020, 1:36 PM · Unknown Object (Project), Restricted Project

Apr 9 2020

benhamilton accepted D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes..

Apr 9 2020, 2:24 PM · Unknown Object (Project), Restricted Project

Apr 6 2020

benhamilton accepted D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes..

Apr 6 2020, 12:30 PM · Unknown Object (Project), Restricted Project

Feb 10 2020

benhamilton committed rG0151ddc2e834: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC… (authored by mwyman).

Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC…

Feb 10 2020, 7:57 AM

benhamilton closed D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..

Feb 10 2020, 7:57 AM · Restricted Project, Unknown Object (Project)

Feb 6 2020

benhamilton accepted D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category..

LGTM, just one nit-pick.

Feb 6 2020, 10:02 AM · Restricted Project, Unknown Object (Project)

Sep 13 2019

benhamilton added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

It definitely shouldn't be in an osx directory since it's available on iOS and other Darwin-like operating systems.

Sep 13 2019, 2:30 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Jul 22 2019

benhamilton committed rGd9212ef77b92: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM… (authored by benhamilton).

Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM…

Jul 22 2019, 11:23 AM

benhamilton committed rL366719: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM….

Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM…

Jul 22 2019, 11:23 AM

benhamilton closed D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

Jul 22 2019, 11:23 AM · Unknown Object (Project), Restricted Project

benhamilton added a comment to D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

Oh, I forgot there's one more place you should touch — the Objective-C style guesser for headers will need to be updated to understand that NS_CLOSED_ENUM indicates Objective-C:

Jul 22 2019, 9:36 AM · Unknown Object (Project), Restricted Project

benhamilton accepted D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

LGTM, thanks!

Jul 22 2019, 9:36 AM · Unknown Object (Project), Restricted Project

Jul 19 2019

benhamilton requested changes to D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

Thanks! Don't forget the CF version.

Jul 19 2019, 2:53 PM · Unknown Object (Project), Restricted Project

benhamilton committed rG86383e66266c: [Format/ObjC] Avoid breaking between unary operators and operands (authored by benhamilton).

[Format/ObjC] Avoid breaking between unary operators and operands

Jul 19 2019, 9:51 AM

benhamilton committed rL366592: [Format/ObjC] Avoid breaking between unary operators and operands.

[Format/ObjC] Avoid breaking between unary operators and operands

Jul 19 2019, 9:50 AM

benhamilton closed D64775: [Format/ObjC] Avoid breaking between unary operators and operands.

Jul 19 2019, 9:50 AM · Unknown Object (Project), Restricted Project

benhamilton retitled D64775: [Format/ObjC] Avoid breaking between unary operators and operands from [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations to [Format/ObjC] Avoid breaking between unary operators and operands.

Jul 19 2019, 9:46 AM · Unknown Object (Project), Restricted Project

Jul 17 2019

benhamilton added a comment to D64775: [Format/ObjC] Avoid breaking between unary operators and operands.

Any more thoughts on this?

Jul 17 2019, 3:51 PM · Unknown Object (Project), Restricted Project

Jul 16 2019

benhamilton committed rGf4c2d57f767d: [clang-format] Don't detect call to ObjC class method as C++11 attribute… (authored by benhamilton).

[clang-format] Don't detect call to ObjC class method as C++11 attribute…

Jul 16 2019, 2:31 PM

benhamilton added a comment to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Submitted as r366267. Thanks!

Jul 16 2019, 2:30 PM · Unknown Object (Project), Restricted Project

benhamilton committed rL366267: [clang-format] Don't detect call to ObjC class method as C++11 attribute….

[clang-format] Don't detect call to ObjC class method as C++11 attribute…

Jul 16 2019, 2:29 PM

benhamilton closed D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Jul 16 2019, 2:29 PM · Unknown Object (Project), Restricted Project

benhamilton added inline comments to D64775: [Format/ObjC] Avoid breaking between unary operators and operands.

Jul 16 2019, 7:38 AM · Unknown Object (Project), Restricted Project

benhamilton updated the diff for D64775: [Format/ObjC] Avoid breaking between unary operators and operands.

Rebase.
Change to just avoid breaking when the left-hand side is a unary operator

Jul 16 2019, 7:29 AM · Unknown Object (Project), Restricted Project

Jul 15 2019

benhamilton created D64775: [Format/ObjC] Avoid breaking between unary operators and operands.

Jul 15 2019, 3:13 PM · Unknown Object (Project), Restricted Project

Jul 12 2019

benhamilton accepted D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Thanks!

Jul 12 2019, 10:42 AM · Unknown Object (Project), Restricted Project

benhamilton added inline comments to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Jul 12 2019, 10:42 AM · Unknown Object (Project), Restricted Project

benhamilton requested changes to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Jul 12 2019, 8:20 AM · Unknown Object (Project), Restricted Project

benhamilton added inline comments to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Jul 12 2019, 8:20 AM · Unknown Object (Project), Restricted Project

benhamilton added a comment to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Thanks for the fix. One question: how does the real Clang parser deal with this case? Is it something that's actually ambiguous in the ObjC++ grammar, I wonder?

Jul 12 2019, 8:19 AM · Unknown Object (Project), Restricted Project

May 28 2019

benhamilton accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

May 28 2019, 9:37 AM · Unknown Object (Project), Restricted Project

May 17 2019

benhamilton requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

May 17 2019, 11:45 AM · Unknown Object (Project), Restricted Project

Apr 29 2019

benhamilton added inline comments to D61267: Update Phabricator.rst.

Apr 29 2019, 2:33 PM · Unknown Object (Project)

benhamilton added inline comments to D61267: Update Phabricator.rst.

Apr 29 2019, 2:32 PM · Unknown Object (Project)

Apr 22 2019

benhamilton committed rGa282bde69e37: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`… (authored by benhamilton).

[ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`…

Apr 22 2019, 10:54 AM

benhamilton committed rL358904: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`….

[ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`…

Apr 22 2019, 10:52 AM

benhamilton committed rC358904: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`….

[ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`…

Apr 22 2019, 10:52 AM

benhamilton closed D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`.

Apr 22 2019, 10:52 AM · Restricted Project

Apr 19 2019

benhamilton accepted D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`.

LGTM!

Apr 19 2019, 2:11 PM · Restricted Project

Feb 8 2019

benhamilton committed rG30b7d09d7a31: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow (authored by benhamilton).

[Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow

Feb 8 2019, 7:58 AM

benhamilton committed rL353531: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.

[Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow

Feb 8 2019, 7:55 AM

benhamilton committed rC353531: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.

[Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow

Feb 8 2019, 7:55 AM

benhamilton closed D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.

Feb 8 2019, 7:54 AM · Restricted Project

Feb 7 2019

benhamilton updated the diff for D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.

Tidy up code.

Feb 7 2019, 1:25 PM · Restricted Project

benhamilton created D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.

Feb 7 2019, 1:24 PM · Restricted Project

Feb 1 2019

benhamilton abandoned D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo.

Feb 1 2019, 2:54 PM · Restricted Project

benhamilton created D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo.

Feb 1 2019, 2:54 PM · Restricted Project

benhamilton abandoned D57622: [please ignore, v2] Test revision for new Herald rules for Github monorepo.

Feb 1 2019, 2:53 PM · Unknown Object (Project)

benhamilton created D57622: [please ignore, v2] Test revision for new Herald rules for Github monorepo.

Feb 1 2019, 2:53 PM · Unknown Object (Project)

Jan 31 2019

benhamilton committed rL352757: Update monorepo .arcconfig with new project callsign..

Update monorepo .arcconfig with new project callsign.

Jan 31 2019, 9:57 AM

benhamilton abandoned D57513: [please ignore] Clang test revision for new Herald rules for Github monorepo.

Jan 31 2019, 7:23 AM · Restricted Project

benhamilton abandoned D57512: [please ignore] Test revision for new Herald rules for Github monorepo.

Jan 31 2019, 7:23 AM

benhamilton updated the diff for D57513: [please ignore] Clang test revision for new Herald rules for Github monorepo.

Another update

Jan 31 2019, 7:21 AM · Restricted Project

benhamilton created D57513: [please ignore] Clang test revision for new Herald rules for Github monorepo.

Jan 31 2019, 7:11 AM · Restricted Project

benhamilton created D57512: [please ignore] Test revision for new Herald rules for Github monorepo.

Jan 31 2019, 7:08 AM

Jan 30 2019

benhamilton committed rC352622: [clang-format] Fix line parsing for noexcept lambdas.

[clang-format] Fix line parsing for noexcept lambdas

Jan 30 2019, 5:54 AM

benhamilton committed rL352622: [clang-format] Fix line parsing for noexcept lambdas.

[clang-format] Fix line parsing for noexcept lambdas

Jan 30 2019, 5:54 AM

benhamilton closed D56909: [clang-format] Fix line parsing for noexcept lambdas.

Jan 30 2019, 5:54 AM

benhamilton added a comment to D56909: [clang-format] Fix line parsing for noexcept lambdas.

So sorry for the delay. I've landed this diff as rC352622.

Jan 30 2019, 5:54 AM

benhamilton requested changes to D55545: Allow IncludeSorter to use #import for Objective-C files.

Jan 30 2019, 5:53 AM · Restricted Project

Jan 24 2019

benhamilton accepted D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.

Jan 24 2019, 1:14 PM

Jan 23 2019

benhamilton accepted D56896: Update property prefix regex to allow numbers..

Jan 23 2019, 9:34 AM · Restricted Project

benhamilton accepted D56909: [clang-format] Fix line parsing for noexcept lambdas.

Jan 23 2019, 9:34 AM

Jan 7 2019

benhamilton added inline comments to D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.

Jan 7 2019, 9:27 AM

Dec 13 2018

benhamilton added inline comments to D55545: Allow IncludeSorter to use #import for Objective-C files.

Dec 13 2018, 10:35 AM · Restricted Project

Dec 12 2018

benhamilton added inline comments to D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙.

Dec 12 2018, 8:42 AM

Dec 10 2018

benhamilton accepted D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙.

Thanks, just minor suggestions.

Dec 10 2018, 3:47 PM

Nov 30 2018

benhamilton added a comment to D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈.

Would you be okay with landing this fix and if we get any further reports for Objective-C++ sources then we can suppress it in all C++/Objective-C++ sources? I think there is enough value to enforcing the naming conventions on non-namespaced C functions in Objective-C++ to justify a simple followup fix. If other issues are reported after this then I also agree that enforcement in Objective-C++ sources may incur more overhead than it's worth.

Nov 30 2018, 2:43 PM

benhamilton added a comment to D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈.

IMHO we should just disable this check entirely for C++ files (including Objective-C++).

Nov 30 2018, 8:17 AM