Page MenuHomePhabricator

benhamilton (Ben Hamilton)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2017, 8:34 AM (100 w, 1 d)
Roles
Administrator

Recent Activity

Fri, Sep 13

benhamilton added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

It definitely shouldn't be in an osx directory since it's available on iOS and other Darwin-like operating systems.

Fri, Sep 13, 2:30 PM · Restricted Project, Restricted Project

Jul 22 2019

benhamilton committed rGd9212ef77b92: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM… (authored by benhamilton).
Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM…
Jul 22 2019, 11:23 AM
benhamilton committed rL366719: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM….
Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM…
Jul 22 2019, 11:23 AM
benhamilton closed D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..
Jul 22 2019, 11:23 AM · Unknown Object (Project), Restricted Project
benhamilton added a comment to D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

Oh, I forgot there's one more place you should touch — the Objective-C style guesser for headers will need to be updated to understand that NS_CLOSED_ENUM indicates Objective-C:

Jul 22 2019, 9:36 AM · Unknown Object (Project), Restricted Project
benhamilton accepted D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

LGTM, thanks!

Jul 22 2019, 9:36 AM · Unknown Object (Project), Restricted Project

Jul 19 2019

benhamilton requested changes to D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM..

Thanks! Don't forget the CF version.

Jul 19 2019, 2:53 PM · Unknown Object (Project), Restricted Project
benhamilton committed rG86383e66266c: [Format/ObjC] Avoid breaking between unary operators and operands (authored by benhamilton).
[Format/ObjC] Avoid breaking between unary operators and operands
Jul 19 2019, 9:51 AM
benhamilton committed rL366592: [Format/ObjC] Avoid breaking between unary operators and operands.
[Format/ObjC] Avoid breaking between unary operators and operands
Jul 19 2019, 9:50 AM
benhamilton closed D64775: [Format/ObjC] Avoid breaking between unary operators and operands.
Jul 19 2019, 9:50 AM · Unknown Object (Project), Restricted Project
benhamilton retitled D64775: [Format/ObjC] Avoid breaking between unary operators and operands from [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations to [Format/ObjC] Avoid breaking between unary operators and operands.
Jul 19 2019, 9:46 AM · Unknown Object (Project), Restricted Project

Jul 17 2019

benhamilton added a comment to D64775: [Format/ObjC] Avoid breaking between unary operators and operands.

Any more thoughts on this?

Jul 17 2019, 3:51 PM · Unknown Object (Project), Restricted Project

Jul 16 2019

benhamilton committed rGf4c2d57f767d: [clang-format] Don't detect call to ObjC class method as C++11 attribute… (authored by benhamilton).
[clang-format] Don't detect call to ObjC class method as C++11 attribute…
Jul 16 2019, 2:31 PM
benhamilton added a comment to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Submitted as r366267. Thanks!

Jul 16 2019, 2:30 PM · Unknown Object (Project), Restricted Project
benhamilton committed rL366267: [clang-format] Don't detect call to ObjC class method as C++11 attribute….
[clang-format] Don't detect call to ObjC class method as C++11 attribute…
Jul 16 2019, 2:29 PM
benhamilton closed D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.
Jul 16 2019, 2:29 PM · Unknown Object (Project), Restricted Project
benhamilton added inline comments to D64775: [Format/ObjC] Avoid breaking between unary operators and operands.
Jul 16 2019, 7:38 AM · Unknown Object (Project), Restricted Project
benhamilton updated the diff for D64775: [Format/ObjC] Avoid breaking between unary operators and operands.
  • Rebase.
  • Change to just avoid breaking when the left-hand side is a unary operator
Jul 16 2019, 7:29 AM · Unknown Object (Project), Restricted Project

Jul 15 2019

benhamilton created D64775: [Format/ObjC] Avoid breaking between unary operators and operands.
Jul 15 2019, 3:13 PM · Unknown Object (Project), Restricted Project

Jul 12 2019

benhamilton accepted D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Thanks!

Jul 12 2019, 10:42 AM · Unknown Object (Project), Restricted Project
benhamilton added inline comments to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.
Jul 12 2019, 10:42 AM · Unknown Object (Project), Restricted Project
benhamilton requested changes to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.
Jul 12 2019, 8:20 AM · Unknown Object (Project), Restricted Project
benhamilton added inline comments to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.
Jul 12 2019, 8:20 AM · Unknown Object (Project), Restricted Project
benhamilton added a comment to D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier.

Thanks for the fix. One question: how does the real Clang parser deal with this case? Is it something that's actually ambiguous in the ObjC++ grammar, I wonder?

Jul 12 2019, 8:19 AM · Unknown Object (Project), Restricted Project

May 28 2019

benhamilton accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 9:37 AM · Unknown Object (Project), Restricted Project

May 17 2019

benhamilton requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 11:45 AM · Unknown Object (Project), Restricted Project

Apr 29 2019

benhamilton added inline comments to D61267: Update Phabricator.rst.
Apr 29 2019, 2:33 PM · Unknown Object (Project)
benhamilton added inline comments to D61267: Update Phabricator.rst.
Apr 29 2019, 2:32 PM · Unknown Object (Project)

Apr 22 2019

benhamilton committed rGa282bde69e37: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`… (authored by benhamilton).
[ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`…
Apr 22 2019, 10:54 AM
benhamilton committed rL358904: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`….
[ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`…
Apr 22 2019, 10:52 AM
benhamilton committed rC358904: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`….
[ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`…
Apr 22 2019, 10:52 AM
benhamilton closed D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`.
Apr 22 2019, 10:52 AM · Restricted Project

Apr 19 2019

benhamilton accepted D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`.

LGTM!

Apr 19 2019, 2:11 PM · Restricted Project

Feb 8 2019

benhamilton committed rG30b7d09d7a31: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow (authored by benhamilton).
[Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow
Feb 8 2019, 7:58 AM
benhamilton committed rL353531: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.
[Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow
Feb 8 2019, 7:55 AM
benhamilton committed rC353531: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.
[Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow
Feb 8 2019, 7:55 AM
benhamilton closed D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.
Feb 8 2019, 7:54 AM · Restricted Project

Feb 7 2019

benhamilton updated the diff for D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.

Tidy up code.

Feb 7 2019, 1:25 PM · Restricted Project
benhamilton created D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow.
Feb 7 2019, 1:24 PM · Restricted Project

Feb 1 2019

benhamilton abandoned D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo.
Feb 1 2019, 2:54 PM · Restricted Project
benhamilton created D57623: [please ignore, v2] Clang test revision for new Herald rules for Github monorepo.
Feb 1 2019, 2:54 PM · Restricted Project
benhamilton abandoned D57622: [please ignore, v2] Test revision for new Herald rules for Github monorepo.
Feb 1 2019, 2:53 PM · Unknown Object (Project)
benhamilton created D57622: [please ignore, v2] Test revision for new Herald rules for Github monorepo.
Feb 1 2019, 2:53 PM · Unknown Object (Project)

Jan 31 2019

benhamilton committed rL352757: Update monorepo .arcconfig with new project callsign..
Update monorepo .arcconfig with new project callsign.
Jan 31 2019, 9:57 AM
benhamilton abandoned D57513: [please ignore] Clang test revision for new Herald rules for Github monorepo.
Jan 31 2019, 7:23 AM · Restricted Project
benhamilton abandoned D57512: [please ignore] Test revision for new Herald rules for Github monorepo.
Jan 31 2019, 7:23 AM
benhamilton updated the diff for D57513: [please ignore] Clang test revision for new Herald rules for Github monorepo.
  • Another update
Jan 31 2019, 7:21 AM · Restricted Project
benhamilton created D57513: [please ignore] Clang test revision for new Herald rules for Github monorepo.
Jan 31 2019, 7:11 AM · Restricted Project
benhamilton created D57512: [please ignore] Test revision for new Herald rules for Github monorepo.
Jan 31 2019, 7:08 AM

Jan 30 2019

benhamilton committed rC352622: [clang-format] Fix line parsing for noexcept lambdas.
[clang-format] Fix line parsing for noexcept lambdas
Jan 30 2019, 5:54 AM
benhamilton committed rL352622: [clang-format] Fix line parsing for noexcept lambdas.
[clang-format] Fix line parsing for noexcept lambdas
Jan 30 2019, 5:54 AM
benhamilton closed D56909: [clang-format] Fix line parsing for noexcept lambdas.
Jan 30 2019, 5:54 AM
benhamilton added a comment to D56909: [clang-format] Fix line parsing for noexcept lambdas.

So sorry for the delay. I've landed this diff as rC352622.

Jan 30 2019, 5:54 AM
benhamilton requested changes to D55545: Allow IncludeSorter to use #import for Objective-C files.
Jan 30 2019, 5:53 AM

Jan 24 2019

benhamilton accepted D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.
Jan 24 2019, 1:14 PM

Jan 23 2019

benhamilton accepted D56896: Update property prefix regex to allow numbers..
Jan 23 2019, 9:34 AM · Restricted Project
benhamilton accepted D56909: [clang-format] Fix line parsing for noexcept lambdas.
Jan 23 2019, 9:34 AM

Jan 7 2019

benhamilton added inline comments to D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.
Jan 7 2019, 9:27 AM

Dec 13 2018

benhamilton added inline comments to D55545: Allow IncludeSorter to use #import for Objective-C files.
Dec 13 2018, 10:35 AM

Dec 12 2018

benhamilton added inline comments to D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙.
Dec 12 2018, 8:42 AM

Dec 10 2018

benhamilton accepted D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙.

Thanks, just minor suggestions.

Dec 10 2018, 3:47 PM

Nov 30 2018

benhamilton added a comment to D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈.

Would you be okay with landing this fix and if we get any further reports for Objective-C++ sources then we can suppress it in all C++/Objective-C++ sources? I think there is enough value to enforcing the naming conventions on non-namespaced C functions in Objective-C++ to justify a simple followup fix. If other issues are reported after this then I also agree that enforcement in Objective-C++ sources may incur more overhead than it's worth.

Nov 30 2018, 2:43 PM
benhamilton added a comment to D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈.

IMHO we should just disable this check entirely for C++ files (including Objective-C++).

Nov 30 2018, 8:17 AM

Nov 21 2018

benhamilton accepted D54795: [clang-format] Do not treat asm clobber [ as ObjCExpr, refined.
Nov 21 2018, 8:39 AM

Nov 12 2018

benhamilton accepted D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜.
Nov 12 2018, 8:38 AM · Restricted Project

Nov 9 2018

benhamilton accepted D54288: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method..
Nov 9 2018, 3:05 PM

Nov 7 2018

benhamilton added inline comments to D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜.
Nov 7 2018, 12:20 PM · Restricted Project

Nov 5 2018

benhamilton accepted D54111: [clang-format] Do not treat the asm clobber [ as ObjCExpr.

In the diff description, please fix the typo: Do not threat the asm clobber -> Do not treat the asm clobber

Nov 5 2018, 9:20 AM
benhamilton committed rL346144: [Format] Add debugging to ObjC language guesser.
[Format] Add debugging to ObjC language guesser
Nov 5 2018, 9:02 AM
benhamilton committed rC346144: [Format] Add debugging to ObjC language guesser.
[Format] Add debugging to ObjC language guesser
Nov 5 2018, 9:01 AM
benhamilton closed D54110: [Format] Add debugging to ObjC language guesser.
Nov 5 2018, 9:01 AM
benhamilton created D54110: [Format] Add debugging to ObjC language guesser.
Nov 5 2018, 8:51 AM

Nov 1 2018

benhamilton accepted D53955: Fix the issue that not recognizing single acronym with prefix as ObjC property name..
Nov 1 2018, 10:02 AM

Oct 12 2018

benhamilton committed rL344406: [clang-format] Fix BraceWrapping AfterFunction for ObjC methods.
[clang-format] Fix BraceWrapping AfterFunction for ObjC methods
Oct 12 2018, 12:45 PM
benhamilton committed rC344406: [clang-format] Fix BraceWrapping AfterFunction for ObjC methods.
[clang-format] Fix BraceWrapping AfterFunction for ObjC methods
Oct 12 2018, 12:45 PM
benhamilton added a comment to D53197: [clang-format] Fix BraceWrapping AfterFunction for ObjC methods.

@benhamilton Could you land this patch?

Oct 12 2018, 12:44 PM
benhamilton closed D53197: [clang-format] Fix BraceWrapping AfterFunction for ObjC methods.
Oct 12 2018, 12:44 PM
benhamilton accepted D53197: [clang-format] Fix BraceWrapping AfterFunction for ObjC methods.

Thanks!

Oct 12 2018, 8:11 AM

Sep 10 2018

benhamilton accepted D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧.

This is fine, but please update the comments (and docs?) to make it clear that we no longer enforce camelCase but allow aRBiTraRYcAsE now.

Sep 10 2018, 8:16 AM

Sep 7 2018

benhamilton committed rL341721: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
[clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
Sep 7 2018, 3:06 PM
benhamilton committed rCTE341721: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
[clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
Sep 7 2018, 3:06 PM
benhamilton committed rCTE341720: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
[clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
Sep 7 2018, 3:06 PM
benhamilton committed rL341720: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
[clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck
Sep 7 2018, 3:06 PM
benhamilton closed D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
Sep 7 2018, 3:06 PM
benhamilton updated the diff for D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
  • Update docs.
Sep 7 2018, 3:05 PM
benhamilton created D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck.
Sep 7 2018, 2:48 PM

Sep 5 2018

benhamilton added inline comments to D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜.
Sep 5 2018, 2:09 PM · Restricted Project
benhamilton requested changes to D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜.

Thanks for this! Let's consolidate this with the property name checker (either simplify the logic there and allow arBiTRAryCapSAnYWHere or apply the same registered acronym logic here).

Sep 5 2018, 9:11 AM · Restricted Project

Jul 12 2018

benhamilton committed rL336919: [clang-tidy/ObjC] Add SQL to list of acronyms.
[clang-tidy/ObjC] Add SQL to list of acronyms
Jul 12 2018, 10:38 AM
benhamilton committed rCTE336919: [clang-tidy/ObjC] Add SQL to list of acronyms.
[clang-tidy/ObjC] Add SQL to list of acronyms
Jul 12 2018, 10:38 AM
benhamilton closed D49190: [clang-tidy/ObjC] Add SQL to list of acronyms.
Jul 12 2018, 10:38 AM

Jul 11 2018

benhamilton created D49190: [clang-tidy/ObjC] Add SQL to list of acronyms.
Jul 11 2018, 8:12 AM

Jul 9 2018

benhamilton accepted D46274: [Support] Harden JSON against invalid UTF-8..

Thanks!

Jul 9 2018, 9:06 AM
benhamilton added inline comments to D46274: [Support] Harden JSON against invalid UTF-8..
Jul 9 2018, 7:57 AM

Jul 2 2018

benhamilton accepted D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.

Sorry for the confusion. If you prefer me to add this test and modify in later commit I'll do it.

Jul 2 2018, 10:01 AM
benhamilton accepted D48716: [clang-format/ObjC] Fix counting selector name parts for ObjC.

General comment to changes D48716, D48718, D48719, D48720 (which are the split of D48352):

Jul 2 2018, 10:00 AM
benhamilton added a child revision for D48719: [clang-format/ObjC] Improve split priorities for ObjC methods: D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit.
Jul 2 2018, 9:59 AM
benhamilton added a parent revision for D48720: [clang-format/ObjC] Put ObjC method arguments into one line when they fit: D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.
Jul 2 2018, 9:59 AM
benhamilton added a parent revision for D48719: [clang-format/ObjC] Improve split priorities for ObjC methods: D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression.
Jul 2 2018, 9:59 AM
benhamilton added a child revision for D48718: [clang-format/ObjC] Prohibit breaking after a bracket opening ObjC method expression: D48719: [clang-format/ObjC] Improve split priorities for ObjC methods.
Jul 2 2018, 9:59 AM