Page MenuHomePhabricator

[LLD][NFC] Refactor: BuildID hash size calculation is now done in a single place.
ClosedPublic

Authored by bd1976llvm on Apr 24 2019, 10:14 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

bd1976llvm created this revision.Apr 24 2019, 10:14 AM
MaskRay added inline comments.Apr 24 2019, 7:08 PM
lld/ELF/SyntheticSections.h
151 ↗(On Diff #196479)

const size_t HashSize;

ruiu added inline comments.Apr 24 2019, 7:26 PM
lld/ELF/Writer.cpp
2551 ↗(On Diff #196479)

nit: instead of assigning to a new variable, I'd use In.BuildId->HashSize directly everywhere.

2554 ↗(On Diff #196479)

nit: add a blank line before switch.

Addressed review comments

bd1976llvm marked 3 inline comments as done.Apr 25 2019, 5:30 PM
ruiu accepted this revision.Apr 25 2019, 8:43 PM

LGTM

This revision is now accepted and ready to land.Apr 25 2019, 8:43 PM
This revision was automatically updated to reflect the committed changes.