Page MenuHomePhabricator

[AMDGPU] Fixed incorrect test in vcnd/vcmp optimization
ClosedPublic

Authored by tpr on Apr 13 2019, 9:32 AM.

Details

Summary

This fixes a test I introduced in change D59191 (that added src0 and
src1 modifiers to the v_cndmask instruction for disassembly purposes).

Spotted by David Binderman in bug 41488.

Change-Id: I6ac95e66cd84e812ed3359ad57bcd0e13198ba0c

Diff Detail

Repository
rL LLVM

Event Timeline

tpr created this revision.Apr 13 2019, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2019, 9:32 AM

I did not add a test because I believe that we do not currently set the source modifiers in codegen, so this code never gets exercised.

arsenm accepted this revision.Apr 13 2019, 1:02 PM

LGTM. We should probably start matching these though

This revision is now accepted and ready to land.Apr 13 2019, 1:02 PM
This revision was automatically updated to reflect the committed changes.