This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add DataCount section to object files
ClosedPublic

Authored by tlively on Apr 12 2019, 10:11 AM.

Details

Summary

This ensures that object files will continue to validate as
WebAssembly modules in the presence of bulk memory operations. Engines
that don't support bulk memory operations will not recognize the
DataCount section and will report validation errors, but that's ok
because object files aren't supposed to be run directly anyway.

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Apr 12 2019, 10:11 AM
dschuff accepted this revision.Apr 12 2019, 1:58 PM

I assume the linker doesn't need to do anything with this, it can just regenerate it after linking?

This revision is now accepted and ready to land.Apr 12 2019, 1:58 PM

I assume the linker doesn't need to do anything with this, it can just regenerate it after linking?

Correct. Coming soon!

This revision was automatically updated to reflect the committed changes.