This is an archive of the discontinued LLVM Phabricator instance.

[gn] Support for per-target runtime directory layout
ClosedPublic

Authored by phosek on Apr 5 2019, 12:09 PM.

Details

Summary

This change also introduces the clang_enable_per_target_runtime_dir
to enable the use of per-target runtime directory layout which is the
equivalent of LLVM_ENABLE_PER_TARGET_RUNTIME_DIR CMake option.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Apr 5 2019, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2019, 12:09 PM
thakis added inline comments.Apr 5 2019, 12:16 PM
llvm/utils/gn/secondary/clang/runtimes.gni
3

Looks like nothing in clang uses this gni file. Will that happen in a future patch? If not, why is this in clang/?

phosek marked an inline comment as done.Apr 5 2019, 5:29 PM
phosek added inline comments.
llvm/utils/gn/secondary/clang/runtimes.gni
3

Yes, this will be used by libunwind, libc++abi and libc++. We could move it to LLVM, but I need to use clang_resource_dir which would invert the dependency (I don't think LLVM should depend on anything in Clang).

thakis accepted this revision.Apr 5 2019, 7:21 PM

Ok, lgtm. I think it's fine to land this; if pcc has comments they can be addressed post-commit.

This revision is now accepted and ready to land.Apr 5 2019, 7:21 PM
pcc accepted this revision.Apr 5 2019, 7:40 PM

LGTM as well

llvm/utils/gn/secondary/clang/runtimes.gni
6

I would probably either make this comment more descriptive or remove it. As it is, it's just repeating the name of the flag.

phosek updated this revision to Diff 194037.Apr 6 2019, 3:53 PM
phosek marked 2 inline comments as done.
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2019, 3:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was automatically updated to reflect the committed changes.