This change also introduces the clang_enable_per_target_runtime_dir
to enable the use of per-target runtime directory layout which is the
equivalent of LLVM_ENABLE_PER_TARGET_RUNTIME_DIR CMake option.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/utils/gn/secondary/clang/runtimes.gni | ||
---|---|---|
2 | Looks like nothing in clang uses this gni file. Will that happen in a future patch? If not, why is this in clang/? |
llvm/utils/gn/secondary/clang/runtimes.gni | ||
---|---|---|
2 | Yes, this will be used by libunwind, libc++abi and libc++. We could move it to LLVM, but I need to use clang_resource_dir which would invert the dependency (I don't think LLVM should depend on anything in Clang). |
Ok, lgtm. I think it's fine to land this; if pcc has comments they can be addressed post-commit.
LGTM as well
llvm/utils/gn/secondary/clang/runtimes.gni | ||
---|---|---|
5 | I would probably either make this comment more descriptive or remove it. As it is, it's just repeating the name of the flag. |
Looks like nothing in clang uses this gni file. Will that happen in a future patch? If not, why is this in clang/?