Page MenuHomePhabricator

[Aarch64] Add v8.2-a half precision element extract intrinsics
ClosedPublic

Authored by dnsampaio on Apr 4 2019, 8:47 AM.

Details

Summary

Implements the intrinsics define on the ACLE to extract half precision fp scalar elements from float16x4_t and float16x8_t vector types.
a.k.a:
vduph_lane_f16
vduph_laneq_f16

Diff Detail

Repository
rL LLVM

Event Timeline

dnsampaio created this revision.Apr 4 2019, 8:47 AM

couple of nits, besides from that LGTM

lib/CodeGen/CGBuiltin.cpp
7813 ↗(On Diff #193727)

nit: spacing between : and {

7817 ↗(On Diff #193727)

nit: spacing again

dnsampaio updated this revision to Diff 194826.Apr 12 2019, 2:55 AM
dnsampaio marked 2 inline comments as done.
  • Used clang-format-diff
DavidSpickett accepted this revision.Apr 12 2019, 3:23 AM
DavidSpickett added a subscriber: DavidSpickett.

LGTM

This revision is now accepted and ready to land.Apr 12 2019, 3:23 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2019, 3:44 AM