Page MenuHomePhabricator

LukeGeeson (Luke Geeson)
Compiler Engineer (Arm)

Projects

User does not belong to any projects.

User Details

User Since
May 1 2018, 5:29 AM (109 w, 2 d)

Recent Activity

Yesterday

LukeGeeson updated the diff for D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.
  • used update_cc_test_checks.py to generate correct checks
Thu, Jun 4, 10:27 AM · Restricted Project, Restricted Project
LukeGeeson added a comment to D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.

Besides from rebasing to get @pratlucas changes upstream.

Thu, Jun 4, 5:24 AM · Restricted Project, Restricted Project

Wed, Jun 3

LukeGeeson updated the diff for D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.

ran llvm/utils/update_llc_test_checks.py on test to get proper CHECKs

Wed, Jun 3, 6:33 AM · Restricted Project, Restricted Project
LukeGeeson added inline comments to D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.
Wed, Jun 3, 6:33 AM · Restricted Project, Restricted Project

Tue, Jun 2

LukeGeeson added inline comments to D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.
Tue, Jun 2, 10:25 AM · Restricted Project, Restricted Project
LukeGeeson added inline comments to D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.
Tue, Jun 2, 9:52 AM · Restricted Project, Restricted Project
LukeGeeson added inline comments to D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
Tue, Jun 2, 9:52 AM · Restricted Project, Restricted Project
LukeGeeson updated the diff for D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.

Added CHECK-NEXT lines, tested whole functions

Tue, Jun 2, 9:52 AM · Restricted Project, Restricted Project
LukeGeeson updated the diff for D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.

Accidentally added dotprod tests here rather than the child commit - just removed them

Tue, Jun 2, 9:52 AM · Restricted Project, Restricted Project
LukeGeeson added a comment to D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.

We need testing for the backend code.

Tue, Jun 2, 9:19 AM · Restricted Project, Restricted Project
LukeGeeson updated subscribers of D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
Tue, Jun 2, 8:46 AM · Restricted Project, Restricted Project
LukeGeeson updated the diff for D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
Tue, Jun 2, 8:46 AM · Restricted Project, Restricted Project

Mon, Jun 1

LukeGeeson added a comment to D80928: [BFloat] Add convert/copy instrinsic support.

A few nits, it looks largely uncontroversial but I'll let someone else give the ok since an external eye is always good :)

Mon, Jun 1, 9:06 AM · Restricted Project, Restricted Project

Thu, May 28

LukeGeeson added a child revision for D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen: D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.
Thu, May 28, 12:38 PM · Restricted Project, Restricted Project
LukeGeeson added a parent revision for D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen: D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
Thu, May 28, 12:38 PM · Restricted Project, Restricted Project
LukeGeeson created D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen.
Thu, May 28, 12:38 PM · Restricted Project, Restricted Project
LukeGeeson added reviewers for D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen: sdesmalen, t.p.northover.
Thu, May 28, 6:30 AM · Restricted Project, Restricted Project
LukeGeeson added a parent revision for D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen: D79869: [clang][BFloat] Add reinterpret cast intrinsics.
Thu, May 28, 5:57 AM · Restricted Project, Restricted Project
LukeGeeson created D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
Thu, May 28, 5:57 AM · Restricted Project, Restricted Project
LukeGeeson added a child revision for D79869: [clang][BFloat] Add reinterpret cast intrinsics: D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
Thu, May 28, 5:57 AM · Restricted Project

Thu, May 21

LukeGeeson added inline comments to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Thu, May 21, 12:26 PM · Restricted Project

Mon, May 18

LukeGeeson added a comment to D79710: [clang][BFloat] Add create/set/get/dup intrinsics.

Can you update the commit message in this differential as well please? Same for the other commits :)

Mon, May 18, 5:19 AM · Restricted Project

Fri, May 15

LukeGeeson added a comment to D79709: [AArch64][BFloat] basic AArch64 bfloat support.

specifically clang/test/CodeGen/arm-bf16-params-returns.c

Fri, May 15, 10:18 AM · Restricted Project
LukeGeeson added a comment to D79709: [AArch64][BFloat] basic AArch64 bfloat support.

Hi @stuij ,

thank you for working on this!

Is there a way we can test the calling convention with your changes? A test that shows that passing or returning bfloat (scalar or vector) via IR functions is mapping to the correct registers will be good to have.

Grazie,

Francesci

Fri, May 15, 10:18 AM · Restricted Project

Wed, May 13

LukeGeeson added a comment to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

I authored some of the code for this patch, please update the commit message with my name on the list :)

Wed, May 13, 10:17 AM · Restricted Project
LukeGeeson added a comment to D79710: [clang][BFloat] Add create/set/get/dup intrinsics.

I was an author for part of this patch. Please add all authors as a list of authors to this commit message. Thanks!

Wed, May 13, 9:44 AM · Restricted Project
LukeGeeson added a comment to D79869: [clang][BFloat] Add reinterpret cast intrinsics.

As I was an author of this patch (among others) please could you add a list of authors to the commit message. Thanks!

Wed, May 13, 9:44 AM · Restricted Project

Apr 25 2020

LukeGeeson added inline comments to D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 25 2020, 6:51 AM · Restricted Project, Restricted Project

Apr 24 2020

LukeGeeson abandoned D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.

Sub-issues all closed

Apr 24 2020, 9:09 AM · Restricted Project
LukeGeeson committed rG740a1dd050ee: [ARM] Armv8.6-a Matrix Mul cmd line support (authored by LukeGeeson).
[ARM] Armv8.6-a Matrix Mul cmd line support
Apr 24 2020, 8:06 AM
LukeGeeson closed D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.
Apr 24 2020, 8:06 AM · Restricted Project
LukeGeeson committed rG659ca502453c: [AArch32] Armv8.6a Matrix Mul Assembly Parsing Support (authored by LukeGeeson).
[AArch32] Armv8.6a Matrix Mul Assembly Parsing Support
Apr 24 2020, 8:06 AM
LukeGeeson committed rGe71468388001: [AArch64] Armv8.6-A Mat Mul SVE Assembly (authored by LukeGeeson).
[AArch64] Armv8.6-A Mat Mul SVE Assembly
Apr 24 2020, 8:05 AM
LukeGeeson closed D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 24 2020, 8:05 AM · Restricted Project
LukeGeeson closed D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly.
Apr 24 2020, 8:05 AM · Restricted Project
LukeGeeson committed rG7da190512532: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson).
[AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics
Apr 24 2020, 8:05 AM
LukeGeeson committed rG832cd749131b: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson).
[AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics
Apr 24 2020, 8:05 AM
LukeGeeson closed D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 24 2020, 8:05 AM · Restricted Project, Restricted Project
LukeGeeson closed D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 24 2020, 8:05 AM · Restricted Project

Apr 23 2020

LukeGeeson added a comment to D78265: [AArch64ConditionOptimizer] Fix missed optimization due to debug insts [10/10].

I cannot build llvm locally using ninja clean && ninja check-all with this patch due to the following error:

Apr 23 2020, 6:59 AM · Restricted Project

Apr 22 2020

LukeGeeson updated the diff for D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.
  • fixed typos
  • added sroa as mem2reg arg to reduce redundant mem accesses in tests, refactored test
  • addressed other comments
Apr 22 2020, 10:19 AM · Restricted Project

Apr 21 2020

LukeGeeson added inline comments to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 21 2020, 7:31 AM · Restricted Project
LukeGeeson updated the diff for D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
  • uploaded the right patch this time... (hunk is removed)
Apr 21 2020, 7:31 AM · Restricted Project
LukeGeeson updated the diff for D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
  • removed hunk
Apr 21 2020, 6:59 AM · Restricted Project
LukeGeeson updated the diff for D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
  • Updated Commit Message
  • Updated Commit Title
Apr 21 2020, 3:12 AM · Restricted Project

Apr 20 2020

LukeGeeson added inline comments to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 20 2020, 8:39 AM · Restricted Project
LukeGeeson updated the diff for D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly.
  • fixed typos
  • added movprf compatibility test for indexed variant of sudot
  • added uzp1, uzp2 tests
  • added tests for ld1ro* vector list variants (no immediate), register variant (with immediate)
Apr 20 2020, 8:05 AM · Restricted Project
LukeGeeson added a comment to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.

The important part of this patch seems to be missing! It says it's adding AArch32 assembly parsing for some new instructions, but I don't see any new Tablegen work that adds the instructions. New mnemonics are added to a couple of exclusion lists in ARMAsmParser, but there's no code in here that makes the mnemonics actually exist in the first place, or that says what their operands should be or what their encodings are – just that small C++ tweak and a load of tests. Where's the rest of it?

Apr 20 2020, 3:43 AM · Restricted Project

Apr 16 2020

LukeGeeson added inline comments to D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 16 2020, 6:10 AM · Restricted Project, Restricted Project
LukeGeeson updated the diff for D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
  • added -sroa to arm-v8.6a-neon-intrinsics test, updated test to remove redundant memory accesses
  • made class vusdot for new vusdot instructions with hasNoSchedulinginfo for new instructions. Existing instructions retain scheduling via use of VDOT class
Apr 16 2020, 6:10 AM · Restricted Project, Restricted Project

Apr 14 2020

LukeGeeson updated the diff for D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.
  • updated commit message to reflect sve=>f32/64 implication
  • added comment in AArch64.cpp to that effect
Apr 14 2020, 9:06 AM · Restricted Project
LukeGeeson updated the summary of D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.
Apr 14 2020, 9:06 AM · Restricted Project
LukeGeeson added a comment to D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.

Note: +f32mm and +f64mm are optional and so have to be enabled by default

I think I know what you mean, but "and so are not enabled by default" would be clearer.

Also to double check, does f64mm imply f32mm? (not sure if there's an updated ARMARM yet that would tell me that)

Apr 14 2020, 8:00 AM · Restricted Project

Apr 10 2020

LukeGeeson added a comment to D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.

harbour master builds, unit tests passing, failures down to linting

Apr 10 2020, 8:33 AM · Restricted Project
LukeGeeson added a comment to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.

Harbourmaster builds, unit tests pass, failure down to linting

Apr 10 2020, 8:28 AM · Restricted Project
LukeGeeson added a comment to D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.

Harbourmaster now biulds, and unit tests pass, errors related to linting

Apr 10 2020, 8:27 AM · Restricted Project, Restricted Project
LukeGeeson added a comment to D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.

Removed reliance on parent revision, harbormaster now builds with unit tests passing

Apr 10 2020, 8:27 AM · Restricted Project
LukeGeeson removed a child revision for D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support: D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 7:24 AM · Restricted Project
LukeGeeson removed a parent revision for D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics: D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.
Apr 10 2020, 7:24 AM · Restricted Project
LukeGeeson added a comment to D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.

Hi folks,
Thank you for your help, I have split the patches up as follows:

Apr 10 2020, 7:23 AM · Restricted Project
LukeGeeson updated subscribers of D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly.
Apr 10 2020, 6:57 AM · Restricted Project
LukeGeeson updated subscribers of D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:57 AM · Restricted Project, Restricted Project
LukeGeeson updated subscribers of D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 10 2020, 6:57 AM · Restricted Project
LukeGeeson updated subscribers of D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.
Apr 10 2020, 6:57 AM · Restricted Project
LukeGeeson added a child revision for D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support: D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.
Apr 10 2020, 6:52 AM · Restricted Project
LukeGeeson added a parent revision for D77875: [ARM] Armv8.6-a Matrix Mul cmd line support: D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 10 2020, 6:52 AM · Restricted Project
LukeGeeson created D77875: [ARM] Armv8.6-a Matrix Mul cmd line support.
Apr 10 2020, 6:52 AM · Restricted Project
LukeGeeson added a parent revision for D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support: D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly.
Apr 10 2020, 6:52 AM · Restricted Project
LukeGeeson added a child revision for D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly: D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson created D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson added a child revision for D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics: D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly.
Apr 10 2020, 6:51 AM · Restricted Project, Restricted Project
LukeGeeson created D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson added a parent revision for D77873: [AArch64] Armv8.6-A Mat Mul SVE Assembly: D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson added a parent revision for D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics: D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:51 AM · Restricted Project, Restricted Project
LukeGeeson added a child revision for D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics: D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson created D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:51 AM · Restricted Project, Restricted Project
LukeGeeson added a parent revision for D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics: D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson created D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:51 AM · Restricted Project
LukeGeeson added a child revision for D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support: D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics.
Apr 10 2020, 6:51 AM · Restricted Project

Apr 8 2020

LukeGeeson added a comment to D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.

This patch is quite big and I think it would be easier to review if it would be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the LLVM side.

Apr 8 2020, 11:24 AM · Restricted Project
LukeGeeson added reviewers for D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support: eli.friedman, fhahn, aemerson.
Apr 8 2020, 9:12 AM · Restricted Project
LukeGeeson added a comment to D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support.

apologies please ignore adding here, added reviewers to the wrong diff

Apr 8 2020, 9:12 AM · Restricted Project, Restricted Project
LukeGeeson added reviewers for D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support: eli.friedman, fhahn, aemerson.
Apr 8 2020, 9:12 AM · Restricted Project, Restricted Project
LukeGeeson updated the summary of D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.
Apr 8 2020, 9:12 AM · Restricted Project
LukeGeeson added inline comments to D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.
Apr 8 2020, 8:40 AM · Restricted Project
LukeGeeson updated the diff for D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.

added __ARM_FEATURE_MATMUL_INT8 check test

Apr 8 2020, 8:39 AM · Restricted Project
LukeGeeson added inline comments to D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.
Apr 8 2020, 7:02 AM · Restricted Project
LukeGeeson updated the diff for D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.

changed hasmatmul type to boolean in clang/lib/basic/target/aarch64.h and related files

Apr 8 2020, 7:02 AM · Restricted Project

Apr 6 2020

LukeGeeson added a comment to D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.

build failures related to linting, unit tests passing

Apr 6 2020, 7:00 AM · Restricted Project
LukeGeeson created D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support.
Apr 6 2020, 5:22 AM · Restricted Project

Mar 13 2020

LukeGeeson updated the diff for D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

Added a file from a downstream cleanup of the branch.

Mar 13 2020, 11:49 AM · Restricted Project
LukeGeeson added inline comments to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mar 13 2020, 6:22 AM · Restricted Project
LukeGeeson added a comment to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

I don't understand why you wouldn't add a new IR type for this; doing so should be totally mechanical.

Mar 13 2020, 6:22 AM · Restricted Project
LukeGeeson added a comment to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

Note that we have an IR type for the PPC double-double format, which isn't even hardware-supported. This is literally just an IEEE floating-point format with non-standard parameters, right?

Mar 13 2020, 5:46 AM · Restricted Project

Mar 12 2020

LukeGeeson added a parent revision for D76077: [ARM] Add __bf16 as new Bfloat16 C Type: D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support.
Mar 12 2020, 10:18 AM · Restricted Project
LukeGeeson added a child revision for D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support: D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mar 12 2020, 10:18 AM · Restricted Project, Restricted Project
LukeGeeson created D76077: [ARM] Add __bf16 as new Bfloat16 C Type.
Mar 12 2020, 10:18 AM · Restricted Project
LukeGeeson updated the summary of D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support.
Mar 12 2020, 8:08 AM · Restricted Project, Restricted Project
LukeGeeson updated the summary of D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support.
Mar 12 2020, 7:03 AM · Restricted Project, Restricted Project
LukeGeeson updated the summary of D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support.
Mar 12 2020, 7:03 AM · Restricted Project, Restricted Project