This is an archive of the discontinued LLVM Phabricator instance.

modify-python-lldb.py: clean up __iter__ and __len__ support
ClosedPublic

Authored by labath on Apr 2 2019, 4:25 AM.

Details

Summary

Instead of modifying the swig-generated code, just add the appropriate
methods to the interface files in order to get the swig to do the
generation for us.

This is a straight-forward move from the python script to the interface
files. The single class which has nontrivial handling in the script
(SBModule) has been left for a separate patch.

For the cases where I did not find any tests exercising the
iteration/length methods (i.e., no tests failed after I stopped emitting
them), I tried to add basic tests for that functionality.

Event Timeline

labath created this revision.Apr 2 2019, 4:25 AM
clayborg accepted this revision.Apr 2 2019, 8:30 AM
This revision is now accepted and ready to land.Apr 2 2019, 8:30 AM
amccarth accepted this revision.Apr 2 2019, 4:50 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 4:47 AM
Herald added a subscriber: abidh. · View Herald Transcript