This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Support UTF-32 (i.e. codepoint) offsets.
ClosedPublic

Authored by sammccall on Mar 28 2019, 5:19 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Mar 28 2019, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 5:19 AM
ilya-biryukov added a subscriber: gribozavr.

NIT: maybe remove parentheses from the change description, they seem to only add noise.
Adding @gribozavr who definitely knows more about Unicode :-)

ilya-biryukov accepted this revision.Mar 28 2019, 5:34 AM

LGTM

unittests/clangd/SourceCodeTests.cpp
164 ↗(On Diff #192614)

small NIT: the . is missing at the end of the comment. Same for lots of comments in the file, I guess.

This revision is now accepted and ready to land.Mar 28 2019, 5:34 AM
sammccall updated this revision to Diff 192628.Mar 28 2019, 7:14 AM

Fix capitalization.

sammccall marked an inline comment as done.Mar 28 2019, 7:17 AM
sammccall added inline comments.
unittests/clangd/SourceCodeTests.cpp
164 ↗(On Diff #192614)

hmm, these are fragments rather than sentences (no caps, no trailing punctuation).
Are we not supposed to use those? There are some in the coding standards examples!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 7:36 AM