This is an archive of the discontinued LLVM Phabricator instance.

Differential D59671

[lld] Prevent duplicate files in debug line header in dwarf 5.
ClosedPublic

Authored by tamur on Mar 21 2019, 3:04 PM.

Details

Reviewers
echristo
ruiu
• espindola
Commits
rLLD357020: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5."
rG5c2f176ccc22: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5."
rL357020: [lld] Reapply "Prevent duplicate files in debug line header in dwarf 5."
rG5aa7478a55fa: [lld] Prevent duplicate files in debug line header in dwarf 5.
rLLD356943: [lld] Prevent duplicate files in debug line header in dwarf 5.
rL356943: [lld] Prevent duplicate files in debug line header in dwarf 5.
Summary

Changes to a couple of tests that will start failing after https://reviews.llvm.org/D59515 is submitted.

Diff Detail

Event Timeline

tamur created this revision.Mar 21 2019, 3:04 PM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 21 2019, 3:04 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. · View Herald Transcript
Harbormaster completed remote builds in B29455: Diff 191786.Mar 21 2019, 3:04 PM
echristo edited reviewers, added: echristo, ruiu; removed: • espindola.Mar 25 2019, 11:08 AM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 25 2019, 11:08 AM
echristo accepted this revision.Mar 25 2019, 11:08 AM

I feel comfortable approving this since it's just test changes and relate to the compiler side of things.

This revision is now accepted and ready to land.Mar 25 2019, 11:08 AM
ruiu accepted this revision.Mar 25 2019, 11:13 AM

LGTM

Sorry for the slow response. Feel ping me offline.

Closed by commit rL356943: [lld] Prevent duplicate files in debug line header in dwarf 5. (authored by tamur). · Explain WhyMar 25 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
test/
ELF/
13 lines
3 lines

Diff 191786

lld/test/ELF/debug-line-obj.s

Show All 26 Lines
.text .text
.file "test.cpp" .file "test.cpp"
.section .text._Z3barv,"ax",@progbits .section .text._Z3barv,"ax",@progbits
.globl _Z3barv .globl _Z3barv
.type _Z3barv,@function .type _Z3barv,@function
_Z3barv: _Z3barv:
.Lfunc_begin0: .Lfunc_begin0:
.file 0 "/path" "test.cpp" md5 0x9ff11a8404ab4d032ee2dd4f5f8c4140 .file 0 "/path" "test.cpp" md5 0x9ff11a8404ab4d032ee2dd4f5f8c4140
.file 1 "test.cpp" md5 0x9ff11a8404ab4d032ee2dd4f5f8c4140 .loc 0 2 0 # test.cpp:2:0
.loc 1 2 0 # test.cpp:2:0 .loc 0 2 20 prologue_end # test.cpp:2:20
.loc 1 2 20 prologue_end # test.cpp:2:20
callq _Z3foov callq _Z3foov
.loc 1 2 13 is_stmt 0 # test.cpp:2:13 .loc 0 2 13 is_stmt 0 # test.cpp:2:13
.Lfunc_end0: .Lfunc_end0:
.size _Z3barv, .Lfunc_end0-_Z3barv .size _Z3barv, .Lfunc_end0-_Z3barv
# -- End function # -- End function
.section .text._Z3bazv,"ax",@progbits .section .text._Z3bazv,"ax",@progbits
.globl _Z3bazv # -- Begin function _Z3bazv .globl _Z3bazv # -- Begin function _Z3bazv
.type _Z3bazv,@function .type _Z3bazv,@function
_Z3bazv: # @_Z3bazv _Z3bazv: # @_Z3bazv
.Lfunc_begin1: .Lfunc_begin1:
.loc 1 3 0 is_stmt 1 # test.cpp:3:0 .loc 0 3 0 is_stmt 1 # test.cpp:3:0
.loc 1 3 20 prologue_end # test.cpp:3:20 .loc 0 3 20 prologue_end # test.cpp:3:20
callq _Z3foov callq _Z3foov
.loc 1 3 13 is_stmt 0 # test.cpp:3:13 .loc 0 3 13 is_stmt 0 # test.cpp:3:13
.Lfunc_end1: .Lfunc_end1:
.size _Z3bazv, .Lfunc_end1-_Z3bazv .size _Z3bazv, .Lfunc_end1-_Z3bazv
.section .debug_str,"MS",@progbits,1 .section .debug_str,"MS",@progbits,1
.Linfo_string0: .Linfo_string0:
.asciz "stub" .asciz "stub"
.section .debug_str_offsets,"",@progbits .section .debug_str_offsets,"",@progbits
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines

lld/test/ELF/debug-line-str.s

Show All 21 Lines
.text .text
.file "test.cpp" .file "test.cpp"
.globl main .globl main
.type main,@function .type main,@function
main: main:
.Lfunc_begin0: .Lfunc_begin0:
.file 0 "/home/path" "test.cpp" md5 0x8ed32099ab837bd13543fd3e8102739f .file 0 "/home/path" "test.cpp" md5 0x8ed32099ab837bd13543fd3e8102739f
.file 1 "test.cpp" md5 0x8ed32099ab837bd13543fd3e8102739f .loc 0 3 10 prologue_end
.loc 1 3 10 prologue_end
jmp _Z3foov jmp _Z3foov
.Lfunc_end0: .Lfunc_end0:
.Lstr_offsets_base0: .Lstr_offsets_base0:
.section .debug_str,"MS",@progbits,1 .section .debug_str,"MS",@progbits,1
.asciz "stub" .asciz "stub"
.section .debug_str_offsets,"",@progbits .section .debug_str_offsets,"",@progbits
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines