[test-suite][mips] Fix compile options for tramp3d-v4 test

[mstojanovic]

Summary

The -mxgot flag was negatively effecting certain micromips builds. This patch narrows its use to to only mips64 targets.

[atanasyan]

Generally the patch looks good. But when I remove -mxgot option completely and unconditionally and run LLVM test suite in both 32 and 64-bit modes, I did not see any new failures. I used both LLD and GNU BFD linkers. Could you check it? What tests and what configurations will fail?

[mstojanovic]

This test will fail for mips64r6 n64 configurations with -O0 or -O1. I think those are the minimal requirements for reproducing the failure and adding other flags shouldn't have an effect on the result.

As for simplifying, I could maybe remove the -mcpu= part from the comparison. Do you think that would a nicer solution or does leaving the full flag give more context without effecting generality?

[atanasyan]

Thanks. I could reproduce the problem with the -O0 option. But I could reproduce the problem for both -mips64r2 and -mips64r6 flags. Is it true for you? If so, I would check for something like $(findstring -mabi=64, $(TARGET_FLAGS)).

[mstojanovic]

Yes, I could also reproduce it on mips64r2. The patch is updated with -mabi=64.

[atanasyan]

LGTM

MultiSource/Benchmarks/tramp3d-v4/CMakeLists.txt

 list(APPEND CXXFLAGS -fno-exceptions)
 list(APPEND LDFLAGS -lstdc++)
 if(SMALL_PROBLEM_SIZE)
   set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32)
 else()
   set(RUN_OPTIONS --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32)
 endif()
-if("${ARCH}" STREQUAL "Mips")
+if(MIPS_IS_MIPS64_ENABLED)
   list(APPEND CXXFLAGS -mxgot)
 endif()
 set(FP_ABSTOLERANCE 0.0000001)
 llvm_multisource(tramp3d-v4)

MultiSource/Benchmarks/tramp3d-v4/Makefile

 LEVEL = ../../..
 
 PROG     = tramp3d-v4
 CPPFLAGS = -fno-exceptions
 LDFLAGS  = -lstdc++
 ifdef SMALL_PROBLEM_SIZE
 RUN_OPTIONS =  --cartvis 1.0 0.0 --rhomin 1e-8 -n 4 --domain 32 32 32
 else
 RUN_OPTIONS =  --cartvis 1.0 0.0 --rhomin 1e-8 -n 10 --domain 32 32 32
 endif
 FP_ABSTOLERANCE :=  0.0000001
 
-ifeq ($(ARCH),Mips)
+ifeq (-mcpu=mips64r6, $(findstring -mcpu=mips64r6, $(TARGET_FLAGS)))
 # Mips needs a bit more compilation time when Mips64r6 and MSA are used
 # together.
 RUNTIMELIMIT := 700
 CPPFLAGS := "-mxgot"
 endif
 
 include ../../Makefile.multisrc