Page MenuHomePhabricator

[test-suite][mips] Fix compile options for tramp3d-v4 test
ClosedPublic

Authored by mstojanovic on Mar 20 2019, 2:08 PM.

Details

Summary

The -mxgot flag was negatively effecting certain micromips builds. This patch narrows its use to to only mips64 targets.

Diff Detail

Repository
rL LLVM

Event Timeline

mstojanovic created this revision.Mar 20 2019, 2:08 PM

Generally the patch looks good. But when I remove -mxgot option completely and unconditionally and run LLVM test suite in both 32 and 64-bit modes, I did not see any new failures. I used both LLD and GNU BFD linkers. Could you check it? What tests and what configurations will fail?

This test will fail for mips64r6 n64 configurations with -O0 or -O1. I think those are the minimal requirements for reproducing the failure and adding other flags shouldn't have an effect on the result.

As for simplifying, I could maybe remove the -mcpu= part from the comparison. Do you think that would a nicer solution or does leaving the full flag give more context without effecting generality?

Thanks. I could reproduce the problem with the -O0 option. But I could reproduce the problem for both -mips64r2 and -mips64r6 flags. Is it true for you? If so, I would check for something like $(findstring -mabi=64, $(TARGET_FLAGS)).

Yes, I could also reproduce it on mips64r2. The patch is updated with -mabi=64.

This revision is now accepted and ready to land.Mar 24 2019, 11:26 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2019, 11:26 AM