Page MenuHomePhabricator

Fix CodeGen/arm64-microsoft-status-reg.cpp test
ClosedPublic

Authored by rupprecht on Mar 19 2019, 1:11 PM.

Details

Summary

This test is failing after r356499 (verified with ninja check-clang-codegen). Update the register selection used in the test from x0 to x8.

Event Timeline

rupprecht created this revision.Mar 19 2019, 1:11 PM
rupprecht edited the summary of this revision. (Show Details)Mar 19 2019, 1:12 PM
efriedma accepted this revision.Mar 19 2019, 1:44 PM
efriedma added a subscriber: efriedma.

LGTM

This revision is now accepted and ready to land.Mar 19 2019, 1:44 PM
This revision was automatically updated to reflect the committed changes.

I thought we weren't supposed to reference asm codegen in clang tests? (PR24580)

Usually no... I wasn't think about it the last time I reviewed a change to this file. Patch welcome to just zap it, assuming we have appropriate coverage in llvm/test/CodeGen/AArch64.