If the compression was used and we had a symbol not involved in relocation,
we never updated its section and it was silently removed from the output.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Nice catch. Should we remove the loop in RelocationSection::replaceSectionReferences that updates the symbols? I think that's unnecessary now, if we are looping over all symbols in the symbol table.
Comment Actions
lgtm modulo trying out jhenderson's suggestion
tools/llvm-objcopy/ELF/Object.h | ||
---|---|---|
533 | missing parameter name |
missing parameter name