Adds patterns to lower all the remaining setcc modes: lt, gt,
le, and ge. Fixes PR40912.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 29314 Build 29313: arc lint + arc unit
Event Timeline
Comment Actions
to make the change even clearer, you could just say in the commit message that it just adds the missing non-equality opcodes.
llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td | ||
---|---|---|
422 | do we also need ord? I guess ord would trivially be true since they are nnan? Anyway, not sure how exactly the dag nodes line up with the LLVM IR ones, but let's jsut make sure we aren't missing more while we're at it. |
llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td | ||
---|---|---|
422 | I have tests for ord nnan and uno nnan below. They apparently do no become no-ops, but are expanded the same as ordand uno with NaNs allowed. |
do we also need ord? I guess ord would trivially be true since they are nnan? Anyway, not sure how exactly the dag nodes line up with the LLVM IR ones, but let's jsut make sure we aren't missing more while we're at it.