Dynamic stack realignment was disabled on micromips by checking if target
has standard encoding. We simply change the condition to skip Mips16 only.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Test was updated to include micromips. Since this is an older test the output was not generated with update_llc_test_checks.py so only lines that differ from mips were updated using new prefixes. Should I update the test with the given script? It could give quite a large output. Also new prefixes for each line might need to be introduced.
LGTM with a few nits
We simply weaken the condition to not include micromips.
I guess you mean mips16 not micromips in the comment to the patch. Right?
Should I update the test with the given script?
I would keep this change compact and do not regenerate test cases using the update_llc_test_checks.py script.
lib/Target/Mips/MipsRegisterInfo.cpp | ||
---|---|---|
324 ↗ | (On Diff #191111) | I would write the comment as "Support dynamic stack realignment for all targets except Mips16." |
We simply weaken the condition to not include micromips.
I guess you mean mips16 not micromips in the comment to the patch. Right?
Sorry, my comment was confusing. I was referring to the line of code that I changed. It was checking if target had standard encoding (is micromips or mips16) and that was the condition that was weakened to only check if target is mips16.
I changed it to make it more clear. Hope it's alright now.