Page MenuHomePhabricator

[AMDGPU] Switch default dwarf version to 5
ClosedPublic

Authored by scott.linder on Mar 5 2019, 5:11 PM.

Details

Summary

Reverts r337612. The issues that cropped up with the last attempt appear to have gone away.

Diff Detail

Repository
rC Clang

Event Timeline

scott.linder created this revision.Mar 5 2019, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2019, 5:11 PM
t-tye accepted this revision.Mar 25 2019, 11:08 AM

LGTM

Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?

This revision is now accepted and ready to land.Mar 25 2019, 11:08 AM

LGTM

Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?

State of them in what sense? Compression is pretty orthogonal to any DWARF version - it's more about the container (ELF, etc) you use. Split DWARF is non-standardly supported in pre-v5, and I think it's functioning in the standards conformant v5 mode too.

t-tye added a comment.Mar 25 2019, 1:59 PM

LGTM

Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?

State of them in what sense? Compression is pretty orthogonal to any DWARF version - it's more about the container (ELF, etc) you use. Split DWARF is non-standardly supported in pre-v5, and I think it's functioning in the standards conformant v5 mode too.

I had heard mention that at least split DWARF may not be fully supported yet for DWARF 5 in LLVM. But maybe that is old news:-)

LGTM

Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?

State of them in what sense? Compression is pretty orthogonal to any DWARF version - it's more about the container (ELF, etc) you use. Split DWARF is non-standardly supported in pre-v5, and I think it's functioning in the standards conformant v5 mode too.

I had heard mention that at least split DWARF may not be fully supported yet for DWARF 5 in LLVM. But maybe that is old news:-)

Might be - nothing I know of right now. (type units aren't fully supported in DWARFv5 - but that's the only big thing on my list)

LGTM

Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?

State of them in what sense? Compression is pretty orthogonal to any DWARF version - it's more about the container (ELF, etc) you use. Split DWARF is non-standardly supported in pre-v5, and I think it's functioning in the standards conformant v5 mode too.

I had heard mention that at least split DWARF may not be fully supported yet for DWARF 5 in LLVM. But maybe that is old news:-)

Might be - nothing I know of right now. (type units aren't fully supported in DWARFv5 - but that's the only big thing on my list)

Anything having to do with section format and placement ought to be correct at this point. Certainly I see v5 type units coming out in the .debug_info section per spec, and the .dwo files look right. If there's something missing please file a bug and CC me.

There was certainly a release where split-dwarf and type units didn't work yet, but that's all done now.

LGTM

Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?

State of them in what sense? Compression is pretty orthogonal to any DWARF version - it's more about the container (ELF, etc) you use. Split DWARF is non-standardly supported in pre-v5, and I think it's functioning in the standards conformant v5 mode too.

I had heard mention that at least split DWARF may not be fully supported yet for DWARF 5 in LLVM. But maybe that is old news:-)

Might be - nothing I know of right now. (type units aren't fully supported in DWARFv5 - but that's the only big thing on my list)

Anything having to do with section format and placement ought to be correct at this point. Certainly I see v5 type units coming out in the .debug_info section per spec, and the .dwo files look right. If there's something missing please file a bug and CC me.

There was certainly a release where split-dwarf and type units didn't work yet, but that's all done now.

Ah, thanks for the correction - I thought that was the case, and then I thought I'd tested it a couple of weeks ago and seen it wasn't (when I'd expected it was)... must've messed up my test, maybe used an old compiler build I had lying around.

Good stuff!

Add a test to confirm split-dwarf is supported for the amdhsa OS in the driver.

This revision was automatically updated to reflect the committed changes.