Page MenuHomePhabricator

[NFC] Declare the member data of class PostGenericScheduler as "protected" instead of "private"
ClosedPublic

Authored by steven.zhang on Mar 4 2019, 6:43 PM.

Details

Summary

Some target might try to subclass the PostGenericScheduler to custom the scheduling strategy. We need to declare the member data of PostGenericScheduler as "protected", which acts the same as "GenericScheduler".

Diff Detail

Repository
rL LLVM

Event Timeline

steven.zhang created this revision.Mar 4 2019, 6:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2019, 6:43 PM
jsji edited reviewers, added: MatzeB, javed.absar; removed: jsji.Mar 5 2019, 6:48 AM
fhahn accepted this revision.Mar 5 2019, 9:18 AM
fhahn added a subscriber: fhahn.

LGTM, given we already do the same for GenericScheduler. Please wait a bit with committing, in case there are additional concerns.

This revision is now accepted and ready to land.Mar 5 2019, 9:18 AM
echristo accepted this revision.Mar 5 2019, 10:29 AM

I'd probably prefer something around giving targets an interface rather than this... but that's a lot more work :)

jsji added a reviewer: jonpa.Mar 5 2019, 11:04 AM
This revision was automatically updated to reflect the committed changes.