Page MenuHomePhabricator

Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing
ClosedPublic

Authored by shafik on Feb 28 2019, 12:14 PM.

Diff Detail

Event Timeline

shafik created this revision.Feb 28 2019, 12:14 PM
aprantl added inline comments.Feb 28 2019, 12:36 PM
packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py
17

The Cocoa framework only exists on macOS, there's a skipDarwinEmbedded (or similar) decorator that you can use to skip the test on iOS. Alternatively, if the problem also reproduces by including CoreGraphics alone, that one I believe exists everywhere.

18

do you mean: skip unless gmodules?

aprantl added inline comments.Feb 28 2019, 12:44 PM
packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py
18

My mistake, this does what you intend.

davide added a subscriber: davide.Feb 28 2019, 12:48 PM

Just a drive-by comment. I think writing this as a inline test would make it more compact (and maybe slightly more readable because you don't have to look at two files), but if you prefer this way, I don't have a strong preference.

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py
3

minor, SourceLocation.

shafik updated this revision to Diff 188780.Feb 28 2019, 1:03 PM
shafik marked 5 inline comments as done.

Addressing comments

aprantl accepted this revision.Feb 28 2019, 1:09 PM
This revision is now accepted and ready to land.Feb 28 2019, 1:09 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2019, 10:04 AM