Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

[shafik]

Summary

This tests a fix in the ASTImpoter.cpp to ensure that we import built-in correctly, see differential:

https://reviews.llvm.org/D58743

Once this change is merged this test should pass and should catch regressions in this feature.

[aprantl]

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py

18

The Cocoa framework only exists on macOS, there's a skipDarwinEmbedded (or similar) decorator that you can use to skip the test on iOS. Alternatively, if the problem also reproduces by including CoreGraphics alone, that one I believe exists everywhere.

19

do you mean: skip unless gmodules?

[aprantl]

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py

19

My mistake, this does what you intend.

[davide]

Just a drive-by comment. I think writing this as a inline test would make it more compact (and maybe slightly more readable because you don't have to look at two files), but if you prefer this way, I don't have a strong preference.

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py

4

minor, SourceLocation.

[shafik]

Addressing comments

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/Makefile

+LEVEL = ../../make
+
+OBJC_SOURCES := main.m
+
+include $(LEVEL)/Makefile.rules
+LDFLAGS += -framework Cocoa

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py

+"""
+They may be cases where an expression will import SourceLocation and if the
+SourceLocation ends up with a FileID that is a built-in we need to copy that
+buffer over correctly.
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+class TestImportBuiltinFileID(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+    @skipUnlessDarwin
+    @skipIfDarwinEmbedded
+    @add_test_categories(["gmodules"])
+    def test_import_builtin_fileid(self):
+        self.build()
+
+        lldbutil.run_to_source_breakpoint(self, '// break here',
+                lldb.SBFileSpec("main.m", False))
+
+        self.expect("expr int (*DBG_CGImageGetRenderingIntent)(void *) = ((int (*)(void *))CGImageGetRenderingIntent); DBG_CGImageGetRenderingIntent((void *)0x00000000000000);", 
+                substrs=['$0 = 0'])

packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/main.m

+#import <Cocoa/Cocoa.h>
+
+int main(int argc, const char * argv[]) {
+
+    return 0; // break here
+}