Page MenuHomePhabricator

Moved Symbol into its own header and implementation file
ClosedPublic

Authored by gribozavr on Feb 28 2019, 3:39 AM.

Diff Detail

Event Timeline

gribozavr created this revision.Feb 28 2019, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 3:39 AM

The design of Symbol and SymbolSlab are closely related. I would suggest putting them close together in the same library.

gribozavr updated this revision to Diff 188712.Feb 28 2019, 4:40 AM

Moving SymbolSlab as well.

Moved SymbolSlab as well, PTAL.

ioeric added inline comments.Feb 28 2019, 4:43 AM
clang-tools-extra/clangd/index/Index.cpp
19 ↗(On Diff #188712)

should also move the implementation?

gribozavr updated this revision to Diff 188714.Feb 28 2019, 4:47 AM

Also moved the SymbolSlab implementation into Symbol.cpp

ioeric accepted this revision.Feb 28 2019, 4:53 AM
This revision is now accepted and ready to land.Feb 28 2019, 4:53 AM
This revision was automatically updated to reflect the committed changes.