Page MenuHomePhabricator

Moved SymbolOrigin into its own header and implementation file
ClosedPublic

Authored by gribozavr on Feb 28 2019, 3:14 AM.

Diff Detail

Event Timeline

gribozavr created this revision.Feb 28 2019, 3:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 3:14 AM

I'm not sure if SymbolOrigin is interesting enough to be its own library. It's usually only used along with Symbol. Maybe we could pull a library Symbol.h instead and put SymbolOrigin by Symbol?

SymbolOrigin is used by itself, for example, in CodeComplete.h to define struct CodeCompletion.

ioeric accepted this revision.Feb 28 2019, 3:43 AM

SymbolOrigin is used by itself, for example, in CodeComplete.h to define struct CodeCompletion.

Fair enough. lgtm

This revision is now accepted and ready to land.Feb 28 2019, 3:43 AM
This revision was automatically updated to reflect the committed changes.