Differential D58707
[llvm-objdump] Should print strings when dumping DT_RPATH, DT_RUNPATH, DT_SONAME, DT_AUXILIARY and DT_FILTER tags in dynamic section. Authored by Higuoxing on Feb 27 2019, 1:32 AM.
Details Before: Dynamic Section: NEEDED libpthread.so.0 ... NEEDED ld-linux-x86-64.so.2 RPATH 0x00000000001c2e61 After: Dynamic Section: NEEDED libpthread.so.0 ... NEEDED ld-linux-x86-64.so.2 RPATH $ORIGIN/../lib Only a small problem here, I have no idea on choosing test case. I see there's a test
Diff Detail
Event TimelineComment Actions
Looking at that test, I think now we should be able to convert it to use yaml2obj instead of using the precompiled binary (as an independent change). Comment Actions +1 to this. You could go as far as basically duplicating the test I've got for dynamic section tags in llvm-readobj in D58677. The only difference would be the output patterns to check. I think that test should give you what you are looking for. I'd make the test change first, so that the test starts failing (locally) after you have made your changes in this patch, before you update the test, if that makes sense. Comment Actions By the way, what about DT_SONAME, DT_AUXILIARY and DT_FILTER, all of which are string offsets in the dynamic string table, like DT_NEEDED etc? Comment Actions Addressed @grimar and @jhenderson 's comments. Thanks for the test file, I noticed that the last 5 d_tag are unknown. We should print them in hex format. I would like to resolve it in another Comment Actions Sounds reasonable. You may notice from the comments in D58677 that I'm going to make a couple of changes to that file in the "unknown" region. Perhaps you should just miss them out for now, and do them later when you fix the behaviour? Basically, we just want to show that the values in that range are printed sensibly. |