[libFuzzer] Remove extra semicolons

[metzman]

Summary

Remove extra semicolons so that libFuzzer can compile with
-Werror -Wextra-semi

[metzman]

Please take a look.
It might be worth adding -Wextra-semi to libFuzzer's cflags,.

[Dor1s]

Not sure if it's worth spending time on, but the change LGTM

[Dor1s]

Btw, if there is a way to automatically detect those unnecessary semicolons, isn't there a way to automatically remove them?

[morehouse]

LGTM, thanks!

[thakis]

In D58674#1410783, @Dor1s wrote:

Btw, if there is a way to automatically detect those unnecessary semicolons, isn't there a way to automatically remove them?

The warning could have a fixit for that. If it doesn't yet, it should grow one. You can then build with -Xclang -fixit to apply the fixits as part of the build.

compiler-rt/lib/fuzzer/FuzzerCorpus.h

public:
   }
 
   bool HasUnit(const Unit &U) { return Hashes.count(Hash(U)); }
   bool HasUnit(const std::string &H) { return Hashes.count(H); }
   InputInfo &ChooseUnitToMutate(Random &Rand) {
     InputInfo &II = *Inputs[ChooseUnitIdxToMutate(Rand)];
     assert(!II.U.empty());
     return II;
-  };
+  }
 
   // Returns an index of random unit from the corpus to mutate.
   size_t ChooseUnitIdxToMutate(Random &Rand) {
     size_t Idx = static_cast<size_t>(CorpusDistribution(Rand));
     assert(Idx < Inputs.size());
     return Idx;
   }
 

compiler-rt/lib/fuzzer/FuzzerExtFunctionsWindows.cpp

 #endif  // LIBFUZZER_MSVC
 
 extern "C" {
 #define EXT_FUNC(NAME, RETURN_TYPE, FUNC_SIG, WARN)         \
   RETURN_TYPE NAME##Def FUNC_SIG {                          \
     Printf("ERROR: Function \"%s\" not defined.\n", #NAME); \
     exit(1);                                                \
   }                                                         \
-  EXTERNAL_FUNC(NAME, NAME##Def) RETURN_TYPE NAME FUNC_SIG;
+  EXTERNAL_FUNC(NAME, NAME##Def) RETURN_TYPE NAME FUNC_SIG
 
 #include "FuzzerExtFunctions.def"
 
 #undef EXT_FUNC
 }
 
 template <typename T>
 static T *GetFnPtr(T *Fun, T *FunDef, const char *FnName, bool WarnIfMissing) {

compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp

 
 void CALLBACK AlarmHandler(PVOID, BOOLEAN) {
   Fuzzer::StaticAlarmCallback();
 }
 
 class TimerQ {
   HANDLE TimerQueue;
  public:
-  TimerQ() : TimerQueue(NULL) {};
+  TimerQ() : TimerQueue(NULL) {}
   ~TimerQ() {
     if (TimerQueue)
       DeleteTimerQueueEx(TimerQueue, NULL);
-  };
+  }
   void SetTimer(int Seconds) {
     if (!TimerQueue) {
       TimerQueue = CreateTimerQueue();
       if (!TimerQueue) {
         Printf("libFuzzer: CreateTimerQueue failed.\n");
         exit(1);
       }
     }
     HANDLE Timer;
     if (!CreateTimerQueueTimer(&Timer, TimerQueue, AlarmHandler, NULL,
         Seconds*1000, Seconds*1000, 0)) {
       Printf("libFuzzer: CreateTimerQueueTimer failed.\n");
       exit(1);
     }
-  };
+  }
 };
 
 static TimerQ Timer;
 
 static void CrashHandler(int) { Fuzzer::StaticCrashSignalCallback(); }
 
 bool Mprotect(void *Ptr, size_t Size, bool AllowReadWrite) {
   return false;  // UNIMPLEMENTED