User Details
- User Since
- Jun 8 2016, 8:15 AM (347 w, 5 d)
Apr 13 2021
LGTM
Dec 18 2020
Nov 16 2020
Disabling on Linux was right call as http://lab.llvm.org:8011/#/builders/112/builds/1191/steps/5/logs/stdio is failing with ASAN_OPTIONS fix.
Looks like my fix broke windows.
http://lab.llvm.org:8011/#/builders/127/builds/1548
I'm going to undo my Win fix and disable it on Linux for now (https://github.com/llvm/llvm-project/commit/91703085f53428ea6305770d41db148e0ebbdea7)
I'll try again if http://lab.llvm.org:8011/#/builders/112/builds/1191 passes since I think it contains https://github.com/llvm/llvm-project/commit/a3be1287091463f4099cdb1710883645329cda7e
The problem is, I don't really know how I can set an env var in a way that works on Linux but doesn't cause failure on Win.
I have both platforms to test though
Nov 12 2020
Sorry, didn't notice your response.
Do you need me to merge this for you?
Nov 2 2020
Oct 28 2020
Oct 20 2020
This change was a bit hard to review since it doesn't include full context (See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).
Jul 13 2020
This change LGTM.
I'll let @vitalybuka decide if he wants to accept.
Jun 29 2020
Thanks!
Mar 19 2020
LGTM
Feb 19 2020
Sorry I didn't review this. LGTM
Feb 11 2020
still LGTM
Feb 10 2020
Mostly LGTM.
What's hash for? To seed an RNG?
I'm not 100% hashing the whole array is the right way to do things but it might be better than nothing.
I guess changing this is possible but not ideal since corpus elements won't map to the same behavior if we change it to say, the last byte or something similar.
Feb 4 2020
LGTM
Jan 21 2020
LGTM. This seems like a generic way of handling this and is especially useful when using LD_PRELOAD to load custom mutators since iirc LD_PRELOAD doesn't make so much noise when it fails.
Dec 12 2019
Dec 11 2019
- fix comment
Dec 10 2019
- fmt
- hoist as requested
- fix comment
Dec 4 2019
LGTM.
Thanks!
Oct 10 2019
I don't consider myself a Windows expert but I don't see anything problematic from a Windows point of view.
Sep 5 2019
We recreate merged_corpus directory and run the second merge step:
Sep 4 2019
Aug 13 2019
Thanks for looking into making this change. It should be very useful for CF.
I'll try to take a look again tomorrow morning with fresh eyes.
Jun 14 2019
LGTM
May 2 2019
May 1 2019
Please take a look.
This reenables libFuzzer on i386 on Linux (accidentally disabled here), and fixes a previously failing test.
Apr 30 2019
I'm also thinking i386 libFuzzer is broken on iOS (though I have no way of confirming this) and thus caused the greendragon bot failure: http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/3958/consoleFull#console-section-35
Please take a look.
I could be less conservative here and only disable i386 on Windows but I frankly don't think the risk of breaking other platforms is worth the benefit (nothing).
This is intended to fix https://bugs.chromium.org/p/chromium/issues/detail?id=957971#c5 I've verified that the "fuzzer" target is no longer possible to build on x86 (as opposed to possible but failing as it was before).
It's also worth noting that this breakage is in part caused by libFuzzer building with MSVC (__builtin_clzll isn't supported by MSVC but _BitScanReverse64 is supported, but not on i386) instead of indirectly with clang.
- fix comment
PTAL.
- add missing period
- use exit(1)
- improve message
- improve error message and look for it in tests
- add newline
@kcc I've changed things so that libFuzzer will fail if the argument to -seed_inputs is a non existent file or is empty? What do you think of this change?
- Add more tests to verify we catch empty lists
- Make LF fail if no seed list
- fix bug
- only use @ in argument
- test