- User Since
- Jun 8 2016, 8:15 AM (110 w, 4 d)
Fri, Jul 20
Left a few comments with high level concerns and some less important ones as well.
Did you use clang-format on this? If not I may have to start using vscode myself since clang-format had no suggested changes to this. Good job.
Thu, Jul 19
I don't think this will work. This just subtracts the number of unstable edges without actually removing those features? Or do i misunderstand how this actually works?
Tue, Jul 17
LGTM with Max's suggestions
Fri, Jul 13
Commit message needs tweaking.
Thu, Jul 12
Please run clang-format as you agreed to do, it's giving me some small formatting changes for this patch.
Just one question
Wed, Jul 11
Also, you should add @Dor1s as a reviewer.
Just some minor suggestions.
Tue, Jul 10
Reposting my comments here from https://reviews.llvm.org/D49141
Please land this revert as soon as possible since the initial revision breaks afl_driver's command line interface, which is used by ClusterFuzz to reproduce crashes.
AFL on OSS-Fuzz has been broken since the initial revision landed.
I think this patch should be reverted.
It breaks afl_driver's command line interface by causing invocations such as ./fuzzer inputfile to fail.
I don't think this breakage was intentional since ./fuzzer inputfile1 inputfile2 still works and I don't think there is a reason to break this.
I've created a revert here: https://reviews.llvm.org/D49141
@kodewilliams have you rerun the tests to find the failing one?
Mon, Jul 9
This code seems like an improvement over last time, but I'll make another pass tomorrow morning just to be sure =)
It might be easier to review this if it were diffed against https://reviews.llvm.org/D48150 so that I don't need to see changes that aren't relevant. But don't spend too much time figuring out how to do this.
Tue, Jun 26
Mon, Jun 25
Jun 22 2018
It looks like the line numbers on my last comments were messed up, trying again.
Jun 20 2018
Jun 19 2018
I still think using a map that contains string -> count makes most sense.
I meant unordered_map
I don't seem to have any other comments except of the naming (e.g. Idx) and the CL description. Jonathan, once you're also satisfied, I think we should ask @morehouse to take a look later this week. WDYT?
+1, after the language in the commit is updated and [libFuzzer] is added to the title.
@Dor1s I still think using a map that contains string -> count makes most sense.
What is the advantage of using an array? I don't consider the performance benefits worth it since that cost is paid instead when printing the name of a mutation (ie: when this option is not being used).
Additionally this approach is simpler, we only need 2 data structures instead of 3.
I assumed I was supposed to review this. +1 to Max's comment about saying "PTAL"
I don't really think this should be its own option. I'd just print the percentages, but I think this is for Max to decide since he has in mind what will be done with the stats better than I.
let's update the language in the commit message too, when you get a chance.
Jun 18 2018
Is the whole patch uploaded? I can only see one file.
Jun 17 2018
I have two comments that I didn't think should be put in any particular place.
Jun 15 2018
Jun 14 2018
Jun 13 2018
Thanks for the changes.
Left some cosmetic suggestions, I don't think this needs any important changes to functionality.
Did a first pass. Looks pretty good!
Jun 11 2018
Clarified a comment and left two more.
Thanks. Looks good so far.
Left a few minor suggestions.
Apr 20 2018
I don't believe it is without AFL.
Apr 18 2018
Replaced by https://reviews.llvm.org/D45744
Right (unless the process is restarted because it OOMs or times out).
This patch seems reasonable to me, but let Kostya comment on it.
If the Chromium fuzzers are currently using the default N, you may want to bump it up so you're not calling LLVMFuzzerInitialize multiple times a second.
Apr 17 2018
- Don't manually init the forkserver if we are not using the deferred one.
Jan 19 2018
Dec 13 2017
- Don't do dummy execution when executing files one-by-one.
Jun 30 2016
Jun 28 2016
Breakup afl-driver.test, remove max_len feature and fix extra stats test.
Jun 26 2016
Remove unneded unsetting of ASAN_OPTIONS in test.
Remove unneeded unset of AFL_MAX_LEN in test and undo unnecessary comment change.
Jun 17 2016
Jun 14 2016
Replace assertion and fix test case.
- Replace assertion with print to stderr and abort().
- Remove call to unset() environmental variable in test case.
Rename duplicate_stderr to maybe_duplicate_stderr().
Build the test binary using cmake and remove use of a hardcoded path.
Jun 10 2016
Remove afl_driver.h, move tests to afl-driver.test