Page MenuHomePhabricator

metzman (Jonathan Metzman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2016, 8:15 AM (200 w, 7 h)

Recent Activity

Thu, Mar 19

metzman accepted D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..

LGTM

Thu, Mar 19, 5:33 PM · Restricted Project

Feb 19 2020

metzman added a comment to D74779: [libFuzzer] Fix denominator in the "inputs have DFT" log line..

Sorry I didn't review this. LGTM

Feb 19 2020, 1:20 PM · Restricted Project, Restricted Project

Feb 11 2020

metzman added inline comments to D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..
Feb 11 2020, 2:13 PM · Restricted Project, Restricted Project
metzman accepted D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..

still LGTM

Feb 11 2020, 1:55 PM · Restricted Project, Restricted Project

Feb 10 2020

metzman accepted D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..

Mostly LGTM.
What's hash for? To seed an RNG?
I'm not 100% hashing the whole array is the right way to do things but it might be better than nothing.
I guess changing this is possible but not ideal since corpus elements won't map to the same behavior if we change it to say, the last byte or something similar.

Feb 10 2020, 4:24 PM · Restricted Project, Restricted Project

Feb 4 2020

metzman added a comment to D73813: [libFuzzer] Make dataflow and focus functions more user friendly..

LGTM

Feb 4 2020, 9:53 AM · Restricted Project, Restricted Project

Jan 21 2020

metzman added inline comments to D73136: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found..
Jan 21 2020, 2:41 PM · Restricted Project, Restricted Project
metzman accepted D73136: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found..

LGTM. This seems like a generic way of handling this and is especially useful when using LD_PRELOAD to load custom mutators since iirc LD_PRELOAD doesn't make so much noise when it fails.

Jan 21 2020, 1:19 PM · Restricted Project, Restricted Project

Dec 12 2019

metzman committed rG23bee0b0cf7a: [fuzzer] Add basic support for emscripten. (authored by metzman).
[fuzzer] Add basic support for emscripten.
Dec 12 2019, 9:00 AM
metzman closed D71285: [fuzzer] Add basic support for emscripten..
Dec 12 2019, 9:00 AM · Restricted Project, Restricted Project

Dec 11 2019

metzman updated the diff for D71285: [fuzzer] Add basic support for emscripten..
  • fix comment
Dec 11 2019, 1:23 PM · Restricted Project, Restricted Project

Dec 10 2019

metzman added inline comments to D71285: [fuzzer] Add basic support for emscripten..
Dec 10 2019, 6:09 PM · Restricted Project, Restricted Project
metzman updated the diff for D71285: [fuzzer] Add basic support for emscripten..
  • fmt
Dec 10 2019, 6:00 PM · Restricted Project, Restricted Project
metzman updated the diff for D71285: [fuzzer] Add basic support for emscripten..
  • hoist as requested
Dec 10 2019, 6:00 PM · Restricted Project, Restricted Project
metzman retitled D71285: [fuzzer] Add basic support for emscripten. from Summary: [fuzzer] Add basic support for emscripten. to [fuzzer] Add basic support for emscripten..
Dec 10 2019, 5:51 PM · Restricted Project, Restricted Project
metzman added reviewers for D71285: [fuzzer] Add basic support for emscripten.: kcc, vitalybuka, hctim.

Demo https://jonathanmetzman.github.io/wasm-fuzzing-demo/brotli/decode_fuzzer.html

Dec 10 2019, 11:23 AM · Restricted Project, Restricted Project
metzman updated the summary of D71285: [fuzzer] Add basic support for emscripten..
Dec 10 2019, 11:23 AM · Restricted Project, Restricted Project
metzman updated the summary of D71285: [fuzzer] Add basic support for emscripten..
Dec 10 2019, 11:14 AM · Restricted Project, Restricted Project
metzman updated the diff for D71285: [fuzzer] Add basic support for emscripten..
  • fix comment
Dec 10 2019, 11:04 AM · Restricted Project, Restricted Project
metzman created D71285: [fuzzer] Add basic support for emscripten..
Dec 10 2019, 10:18 AM · Restricted Project, Restricted Project

Dec 4 2019

metzman accepted D71031: [compiler-rt] FuzzedDataProvider: do not call memcpy on empty vector..

LGTM.
Thanks!

Dec 4 2019, 1:34 PM · Restricted Project, Restricted Project

Oct 10 2019

metzman added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

I don't consider myself a Windows expert but I don't see anything problematic from a Windows point of view.

Oct 10 2019, 7:13 PM · Restricted Project, Restricted Project

Sep 5 2019

metzman added a comment to D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file..

We recreate merged_corpus directory and run the second merge step:

Sep 5 2019, 10:06 PM · Restricted Project, Restricted Project

Sep 4 2019

metzman abandoned D61327: [libFuzzer] Revert commits accidentally committed separately..
Sep 4 2019, 1:56 PM · Restricted Project, Restricted Project

Aug 13 2019

metzman added a comment to D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file..

Thanks for looking into making this change. It should be very useful for CF.
I'll try to take a look again tomorrow morning with fresh eyes.

Aug 13 2019, 7:33 PM · Restricted Project, Restricted Project

Jun 14 2019

metzman accepted D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

LGTM

Jun 14 2019, 12:29 PM · Restricted Project, Restricted Project

May 2 2019

metzman committed rG3d1d3ad50ef9: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test (authored by metzman).
[libFuzzer] Re-enable libFuzzer on i386 Linux and fix test
May 2 2019, 9:45 AM
metzman committed rL359802: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test.
[libFuzzer] Re-enable libFuzzer on i386 Linux and fix test
May 2 2019, 9:45 AM
metzman committed rCRT359802: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test.
[libFuzzer] Re-enable libFuzzer on i386 Linux and fix test
May 2 2019, 9:45 AM
metzman closed D61415: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test.
May 2 2019, 9:45 AM · Restricted Project, Restricted Project

May 1 2019

metzman added a reviewer for D61415: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test: morehouse.

Please take a look.
This reenables libFuzzer on i386 on Linux (accidentally disabled here), and fixes a previously failing test.

May 1 2019, 7:04 PM · Restricted Project, Restricted Project
metzman retitled D61415: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test from [libFuzzer] Re-enable libFuzzer on i386 Linux and fix tests to [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test.
May 1 2019, 5:24 PM · Restricted Project, Restricted Project
metzman created D61415: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test.
May 1 2019, 5:20 PM · Restricted Project, Restricted Project

Apr 30 2019

metzman added inline comments to D61354: [libFuzzer] Disable i386 on non-Linux platforms.
Apr 30 2019, 7:48 PM · Restricted Project, Restricted Project
metzman committed rGa5147e0e1564: [libFuzzer] Disable i386 on non-Linux platforms (authored by metzman).
[libFuzzer] Disable i386 on non-Linux platforms
Apr 30 2019, 6:39 PM
metzman committed rCRT359641: [libFuzzer] Disable i386 on non-Linux platforms.
[libFuzzer] Disable i386 on non-Linux platforms
Apr 30 2019, 6:38 PM
metzman committed rL359641: [libFuzzer] Disable i386 on non-Linux platforms.
[libFuzzer] Disable i386 on non-Linux platforms
Apr 30 2019, 6:38 PM
metzman closed D61354: [libFuzzer] Disable i386 on non-Linux platforms.
Apr 30 2019, 6:38 PM · Restricted Project, Restricted Project
metzman added a comment to D61354: [libFuzzer] Disable i386 on non-Linux platforms.

I'm also thinking i386 libFuzzer is broken on iOS (though I have no way of confirming this) and thus caused the greendragon bot failure: http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/3958/consoleFull#console-section-35

Apr 30 2019, 6:38 PM · Restricted Project, Restricted Project
metzman added reviewers for D61354: [libFuzzer] Disable i386 on non-Linux platforms: morehouse, rnk.

Please take a look.
I could be less conservative here and only disable i386 on Windows but I frankly don't think the risk of breaking other platforms is worth the benefit (nothing).
This is intended to fix https://bugs.chromium.org/p/chromium/issues/detail?id=957971#c5 I've verified that the "fuzzer" target is no longer possible to build on x86 (as opposed to possible but failing as it was before).
It's also worth noting that this breakage is in part caused by libFuzzer building with MSVC (__builtin_clzll isn't supported by MSVC but _BitScanReverse64 is supported, but not on i386) instead of indirectly with clang.

Apr 30 2019, 5:07 PM · Restricted Project, Restricted Project
metzman retitled D61354: [libFuzzer] Disable i386 on non-Linux platforms from [libFuzzer] Disable i386 on Windows to [libFuzzer] Disable i386 on non-Linux platforms.
Apr 30 2019, 4:55 PM · Restricted Project, Restricted Project
metzman created D61354: [libFuzzer] Disable i386 on non-Linux platforms.
Apr 30 2019, 4:53 PM · Restricted Project, Restricted Project
metzman committed rGc0806e0d24ad: [libFuzzer] Fix failing test: sigint.test (authored by metzman).
[libFuzzer] Fix failing test: sigint.test
Apr 30 2019, 4:47 PM
metzman committed rL359638: [libFuzzer] Fix failing test: sigint.test.
[libFuzzer] Fix failing test: sigint.test
Apr 30 2019, 4:46 PM
metzman committed rCRT359638: [libFuzzer] Fix failing test: sigint.test.
[libFuzzer] Fix failing test: sigint.test
Apr 30 2019, 4:46 PM
metzman closed D61353: [libFuzzer] Fix failing test: sigint.test.
Apr 30 2019, 4:46 PM · Restricted Project, Restricted Project
metzman retitled D61353: [libFuzzer] Fix failing test: sigint.test from Fix failing test: sigint.test to [libFuzzer] Fix failing test: sigint.test.
Apr 30 2019, 4:46 PM · Restricted Project, Restricted Project
metzman updated the diff for D61353: [libFuzzer] Fix failing test: sigint.test.
  • fix comment
Apr 30 2019, 4:24 PM · Restricted Project, Restricted Project
metzman created D61353: [libFuzzer] Fix failing test: sigint.test.
Apr 30 2019, 3:55 PM · Restricted Project, Restricted Project
metzman added a reviewer for D61353: [libFuzzer] Fix failing test: sigint.test: kcc.

PTAL.

Apr 30 2019, 3:55 PM · Restricted Project, Restricted Project
metzman abandoned D61352: [libFuzzer] Fix failing test.
Apr 30 2019, 3:51 PM · Restricted Project, Restricted Project
metzman created D61352: [libFuzzer] Fix failing test.
Apr 30 2019, 3:50 PM · Restricted Project, Restricted Project
metzman committed rGf3ee97731eb5: [libFuzzer] Replace -seed_corpus to better support fork mode on Win (authored by metzman).
[libFuzzer] Replace -seed_corpus to better support fork mode on Win
Apr 30 2019, 1:58 PM
metzman committed rCRT359610: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
[libFuzzer] Replace -seed_corpus to better support fork mode on Win
Apr 30 2019, 1:57 PM
metzman committed rL359610: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
[libFuzzer] Replace -seed_corpus to better support fork mode on Win
Apr 30 2019, 1:57 PM
metzman closed D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
Apr 30 2019, 1:57 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • add missing period
Apr 30 2019, 12:17 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • use exit(1)
Apr 30 2019, 12:13 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • improve message
Apr 30 2019, 12:12 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • improve error message and look for it in tests
Apr 30 2019, 12:09 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • add newline
Apr 30 2019, 12:05 PM · Restricted Project, Restricted Project
metzman added a comment to D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.

@kcc I've changed things so that libFuzzer will fail if the argument to -seed_inputs is a non existent file or is empty? What do you think of this change?

Apr 30 2019, 12:05 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • Add more tests to verify we catch empty lists
Apr 30 2019, 12:02 PM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • Make LF fail if no seed list
Apr 30 2019, 11:57 AM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • fix bug
Apr 30 2019, 11:44 AM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
Apr 30 2019, 11:42 AM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • only use @ in argument
Apr 30 2019, 11:42 AM · Restricted Project, Restricted Project
metzman abandoned D61328: tmp.
Apr 30 2019, 11:16 AM · Restricted Project
metzman updated the diff for D61327: [libFuzzer] Revert commits accidentally committed separately..
  • test
Apr 30 2019, 11:16 AM · Restricted Project, Restricted Project
metzman created D61328: tmp.
Apr 30 2019, 11:14 AM · Restricted Project
metzman created D61327: [libFuzzer] Revert commits accidentally committed separately..
Apr 30 2019, 11:12 AM · Restricted Project, Restricted Project
metzman committed rG7a2ce3790b92: fix broken test (authored by metzman).
fix broken test
Apr 30 2019, 11:00 AM
metzman committed rG17bd74d40655: remove extra zeros (authored by metzman).
remove extra zeros
Apr 30 2019, 11:00 AM
metzman committed rG5a271cd75838: remove stale comment (authored by metzman).
remove stale comment
Apr 30 2019, 11:00 AM
metzman committed rGd61084901ca3: change order (authored by metzman).
change order
Apr 30 2019, 11:00 AM
metzman committed rG269766458211: [libFuzzer] Enable for i386 (authored by metzman).
[libFuzzer] Enable for i386
Apr 30 2019, 11:00 AM
metzman committed rG1fbc6116e17d: fix comment (authored by metzman).
fix comment
Apr 30 2019, 11:00 AM
metzman committed rG6fa864b7a641: Fix issues with testing for i386 (authored by metzman).
Fix issues with testing for i386
Apr 30 2019, 11:00 AM
metzman committed rGf721230831c5: Enable x86 builds (authored by metzman).
Enable x86 builds
Apr 30 2019, 11:00 AM
metzman committed rCRT359590: fix broken test.
fix broken test
Apr 30 2019, 10:59 AM
metzman committed rCRT359589: remove extra zeros.
remove extra zeros
Apr 30 2019, 10:59 AM
metzman committed rCRT359588: remove stale comment.
remove stale comment
Apr 30 2019, 10:59 AM
metzman committed rCRT359587: change order.
change order
Apr 30 2019, 10:59 AM
metzman committed rCRT359586: fix comment.
fix comment
Apr 30 2019, 10:59 AM
metzman committed rCRT359585: [libFuzzer] Enable for i386.
[libFuzzer] Enable for i386
Apr 30 2019, 10:59 AM
metzman committed rCRT359584: Fix issues with testing for i386.
Fix issues with testing for i386
Apr 30 2019, 10:59 AM
metzman committed rCRT359583: Enable x86 builds.
Enable x86 builds
Apr 30 2019, 10:59 AM
metzman committed rL359590: fix broken test.
fix broken test
Apr 30 2019, 10:59 AM
metzman committed rL359588: remove stale comment.
remove stale comment
Apr 30 2019, 10:59 AM
metzman committed rL359589: remove extra zeros.
remove extra zeros
Apr 30 2019, 10:59 AM
metzman committed rL359585: [libFuzzer] Enable for i386.
[libFuzzer] Enable for i386
Apr 30 2019, 10:59 AM
metzman committed rL359587: change order.
change order
Apr 30 2019, 10:59 AM
metzman committed rL359586: fix comment.
fix comment
Apr 30 2019, 10:59 AM
metzman closed D61070: [libFuzzer] Enable on i386.
Apr 30 2019, 10:59 AM · Restricted Project, Restricted Project
metzman committed rL359583: Enable x86 builds.
Enable x86 builds
Apr 30 2019, 10:59 AM
metzman committed rL359584: Fix issues with testing for i386.
Fix issues with testing for i386
Apr 30 2019, 10:59 AM
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • use new format
Apr 30 2019, 10:58 AM · Restricted Project, Restricted Project
metzman added inline comments to D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
Apr 30 2019, 10:43 AM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • remove extra newline
Apr 30 2019, 10:43 AM · Restricted Project, Restricted Project
metzman updated the diff for D60980: [libFuzzer] Replace -seed_corpus to better support fork mode on Win.
  • ideal but test failing
  • fix issue
Apr 30 2019, 10:43 AM · Restricted Project, Restricted Project