- User Since
- Feb 14 2017, 7:36 AM (193 w, 3 d)
Fri, Oct 23
Not that I like to merge CLs on Friday afternoon, but I'm OOO next week, so taking a shot now while I'm still online.
print "U" and "C" unconditionally
Matt, I'm trying to finish this on behalf of Ryan. Marty has been enabling the use of that feature on ClusterFuzz already, so it makes sense to move forward with this. Please take another look when you can :)
addressing review feedback from Matt
Sep 11 2020
Sep 10 2020
Sep 9 2020
LGTM, thanks for adding this back!
To be more constructive, do you have a use case where this option or its inverse is needed?
Sep 2 2020
Fangrui, what made you think it's fine to remove documented options and break compatibility for the users of the tool?
Sep 1 2020
@morehouse could you please take a look as well, when you get a chance?
Aug 13 2020
Good job on uploading this for review, Ryan!
Jul 10 2020
Alright, we've ended up disabling that behavior in honggfuzz build, so I'll just close this CL for now.
Jul 6 2020
Jul 1 2020
Updated the version of ExecuteCommand with piped output.
Should be better now, ready for review again :)
Ready for review, PTAL.
Ready for review, PTAL.
Re-write to use fork-exec instead of system() on Linux.
If we still decide to proceed with this, would it make sense to expand it to sanitizer_coverage based on any sancov instrumentation being enabled? As you mentioned in the description, there might be users who manually enable certain sancov flags. I think it's good to be able to support those usecases too (e.g. other fuzzing engines).
What usecase(s) do you have for this in mind?
Jun 30 2020
I've split the implementation into platform specific files, but I still don't like it. Plus, as Jonathan mentioned, it still has edge cases e.g. if a filename has a single quote. I'll give a shot at refactoring ExecuteCommand into fork-exec. It looks like I need to re-write only Posix implementation, as Fuchsia is already doing good and Windows is less prone to such issues due to its more restrictive file naming.
split the implementation into platform specific files
Jun 29 2020
Jun 26 2020
Mar 25 2020
@leonardchan I've committed https://github.com/llvm/llvm-project/commit/6d0488f75bb2f37bcfe93fc8f59f6e78c9a0c939, that should help, I'll monitor the buildbot.
rebase + add a comment for ConsumeProbability
Mar 23 2020
The failure seems to be clang-tidy again -- I'm not going to change names of the methods. PTAL at lines 37-78, if you find time. The rest is existing code moved out of the class definition block. If no one takes a look, I'll land it in a couple days anyways, no worries.
updated CL description
Mar 19 2020
make the linter happy #2
fix tidy error
PTAL, this is a small change requested/suggested by Mitch. I have another one ready (which is a large refactoring) that would come after.
Mar 18 2020
Feb 25 2020
Feb 19 2020
Feb 18 2020
Small change. PTAL, or I'll land it myself it a day or so :)
Feb 11 2020
I'm gonna rebase and commit, since there isn't much to review compared to the PS#1 (just a test).
Thanks for the review. I can't think of a good application for the hash. Anything I come up with is better to be done either without hashing or even without FDP.
- Removed the hash
- Added test
- Renamed ConsumeMemory to ConsumeData, as the former sounds a bit ambiguous (like memory consumption is more about memory being allocated, while here it's just values being copied, i.e. data)
remove hash method, rename ConsumeMemory to ConsumeData, add test
Feb 10 2020
Jonathan @metzman please take a look when you get a chance. I'll add the tests later. Two comments:
Self-approval for a quick fix (reverting two lines in https://reviews.llvm.org/D74137).
Looks like there is potentially relevant failure in: http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/29265
Feb 6 2020
Feb 3 2020
I'm happy to take a review pass too. Just ping me when / if this is needed.
The next build succeeded. Must be a flake. And I'm seeing some other unrelated failures locally, but not this one. False alarm
Hm, there is a failure in http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25533, but I don't understand how it can be related... Looking more.
Jan 31 2020
Jan 22 2020
one rebase is never enough
Given that this is a simple change and Kostya is a busy man I'm going to go ahead and land this. We can always revert if there is any concern.
rebase + getting ready to commit