- User Since
- Feb 14 2017, 7:36 AM (123 w, 12 h)
Thu, Jun 20
LGTM, thanks @sajjadm !
+1, the change looks good, but if you could modify the existing test for lcov export in a way so that it starts failing with the existing implementation but will pass after your chance, that'd be awesome.
Wed, Jun 19
Self-approval for a minor fix.
Tue, Jun 18
Trying rebase, re-running the tests, and committing again.
Hm, I'm doing the following:
Thanks a lot, Matt!
Mon, Jun 17
Fri, Jun 14
Added a test, thanks @metzman for the idea how to test it.
The change is tested and ready for review. Please take a look :)
Add static_assert guards to ConvertUnsignedToSigned.
Thu, Jun 13
Thanks for the replies, Vedant. Still LGTM!
Left some questions / suggestions, but don't see any problems, LGTM!
Tue, Jun 11
Fix CMakeLists.txt as per Matt's comment
Mon, Jun 10
Yay, the current version works across Linux / Windows / Mac without any hacks. Thanks again, Reid!
Fix linking on Windows, get rid of unnecessary RTFuzzer dependency.
Fri, Jun 7
Nico, Reid, Jonathan, I'd greatly appreciate your Windows expertise here. If I remove lines 11-16 from lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp, I'm getting the following link errors on Windows:
Workaround Windows-specific linking issue.
Remove commented line
Add the tests.
Thu, Jun 6
LGTM (was OOO), thanks a lot David for Sajjad for multiple iterations here. One question: was the test landed? I see it in the latest patchset (https://reviews.llvm.org/D62541?id=203034), but not in the code that was committed.
Mon, Jun 3
Fri, May 31
Wed, May 29
I think it'll be bad if we lose merging with this approach. Should the change be done in a way that openFileForMerging can also use the runtime provided file pointer?
May 20 2019
Getting ready to commit
The change looks good to me, with one minor edit requested.
Apr 12 2019
fix a typo
Add the test, remove debug logging, fix python3 division.
Btw, I did some testing locally, with a 5 bytes input. I was tracing it 3 times:
- 0 3 bytes
- 3 5 bytes
Please see this draft proposal / explanation for the issue. The bisection in python is fine! :)
This patch fixes the issue with the long inputs by not creating DFSan labels
for the bytes which we do not trace, and by offseting the resulting labels to
make the dumps easily mergeable.
Hey @kcc, I've figured out what's the problem here. Will update the description and the CL shortly.
Apr 11 2019
With this change my target is finally running! :)
Apr 10 2019
Update the test to reflect the change and make sure it passes.
Apr 4 2019
Kostya / Matt, this is fairly minor change, PTAL.