Page MenuHomePhabricator

Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (113 w, 3 d)

Recent Activity

Fri, Apr 12

Dor1s committed rGb6e6d3c740a4: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. (authored by Dor1s).
[libFuzzer] Fix DataFlow.cpp logic when tracing long inputs.
Fri, Apr 12, 1:59 PM
Dor1s committed rCRT358311: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
[libFuzzer] Fix DataFlow.cpp logic when tracing long inputs.
Fri, Apr 12, 1:58 PM
Dor1s committed rL358311: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
[libFuzzer] Fix DataFlow.cpp logic when tracing long inputs.
Fri, Apr 12, 1:58 PM
Dor1s closed D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Fri, Apr 12, 1:58 PM · Restricted Project, Restricted Project
Dor1s retitled D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. from [Draft] [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. to [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Fri, Apr 12, 1:30 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

fix a typo

Fri, Apr 12, 1:29 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Add the test, remove debug logging, fix python3 division.

Fri, Apr 12, 1:28 PM · Restricted Project, Restricted Project
Dor1s added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Btw, I did some testing locally, with a 5 bytes input. I was tracing it 3 times:

  • full
  • 0 3 bytes
  • 3 5 bytes
Fri, Apr 12, 11:27 AM · Restricted Project, Restricted Project
Dor1s added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Please see this draft proposal / explanation for the issue. The bisection in python is fine! :)

Fri, Apr 12, 11:14 AM · Restricted Project, Restricted Project
Dor1s updated the summary of D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Fri, Apr 12, 11:10 AM · Restricted Project, Restricted Project
Dor1s retitled D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. from [libFuzzer] Skip too long inputs in the data flow scripts. to [Draft] [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Fri, Apr 12, 11:10 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

This patch fixes the issue with the long inputs by not creating DFSan labels
for the bytes which we do not trace, and by offseting the resulting labels to
make the dumps easily mergeable.

Fri, Apr 12, 11:07 AM · Restricted Project, Restricted Project
Dor1s added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Hey @kcc, I've figured out what's the problem here. Will update the description and the CL shortly.

Fri, Apr 12, 11:07 AM · Restricted Project, Restricted Project

Thu, Apr 11

Dor1s committed rGbcb93a35c02f: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input. (authored by Dor1s).
[libFuzzer] Make MutateWithMask work when the Mask is shorter than the input.
Thu, Apr 11, 11:24 AM
Dor1s committed rL358207: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
[libFuzzer] Make MutateWithMask work when the Mask is shorter than the input.
Thu, Apr 11, 11:24 AM
Dor1s committed rCRT358207: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
[libFuzzer] Make MutateWithMask work when the Mask is shorter than the input.
Thu, Apr 11, 11:24 AM
Dor1s closed D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
Thu, Apr 11, 11:24 AM · Restricted Project, Restricted Project
Dor1s added a comment to D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..

With this change my target is finally running! :)

Thu, Apr 11, 11:11 AM · Restricted Project, Restricted Project
Dor1s created D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
Thu, Apr 11, 11:11 AM · Restricted Project, Restricted Project
Dor1s committed rG9d5e7ee29665: [libFuzzer] Fallback to default Mutate when MutateWithMask fails. (authored by Dor1s).
[libFuzzer] Fallback to default Mutate when MutateWithMask fails.
Thu, Apr 11, 9:24 AM
Dor1s committed rL358190: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
[libFuzzer] Fallback to default Mutate when MutateWithMask fails.
Thu, Apr 11, 9:24 AM
Dor1s committed rCRT358190: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
[libFuzzer] Fallback to default Mutate when MutateWithMask fails.
Thu, Apr 11, 9:24 AM
Dor1s closed D60567: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
Thu, Apr 11, 9:24 AM · Restricted Project, Restricted Project
Dor1s created D60567: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
Thu, Apr 11, 8:21 AM · Restricted Project, Restricted Project

Wed, Apr 10

Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Update the test to reflect the change and make sure it passes.

Wed, Apr 10, 1:45 PM · Restricted Project, Restricted Project
Dor1s created D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Wed, Apr 10, 1:42 PM · Restricted Project, Restricted Project

Thu, Apr 4

Dor1s committed rGb25040359018: [libFuzzer] Another follow up fix for Data Flow scripts in Py3. (authored by Dor1s).
[libFuzzer] Another follow up fix for Data Flow scripts in Py3.
Thu, Apr 4, 3:54 PM
Dor1s committed rL357732: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
[libFuzzer] Another follow up fix for Data Flow scripts in Py3.
Thu, Apr 4, 3:54 PM
Dor1s committed rCRT357732: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
[libFuzzer] Another follow up fix for Data Flow scripts in Py3.
Thu, Apr 4, 3:54 PM
Dor1s closed D60289: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
Thu, Apr 4, 3:54 PM · Restricted Project, Restricted Project
Dor1s accepted D60289: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..

TBR

Thu, Apr 4, 3:54 PM · Restricted Project, Restricted Project
Dor1s created D60289: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
Thu, Apr 4, 3:53 PM · Restricted Project, Restricted Project
Dor1s committed rG665b6b30ddea: [libFuzzer] Fix output format in data flow merge script after Py3 change. (authored by Dor1s).
[libFuzzer] Fix output format in data flow merge script after Py3 change.
Thu, Apr 4, 3:21 PM
Dor1s committed rL357730: [libFuzzer] Fix output format in data flow merge script after Py3 change..
[libFuzzer] Fix output format in data flow merge script after Py3 change.
Thu, Apr 4, 3:21 PM
Dor1s committed rCRT357730: [libFuzzer] Fix output format in data flow merge script after Py3 change..
[libFuzzer] Fix output format in data flow merge script after Py3 change.
Thu, Apr 4, 3:21 PM
Dor1s closed D60288: [libFuzzer] Fix output format in data flow merge script after Py3 change..
Thu, Apr 4, 3:21 PM · Restricted Project, Restricted Project
Dor1s accepted D60288: [libFuzzer] Fix output format in data flow merge script after Py3 change..

TBR

Thu, Apr 4, 3:21 PM · Restricted Project, Restricted Project
Dor1s created D60288: [libFuzzer] Fix output format in data flow merge script after Py3 change..
Thu, Apr 4, 3:21 PM · Restricted Project, Restricted Project
Dor1s committed rGc815210013f2: [libFuzzer] Make DataFlow scripts Python3 compatible. (authored by Dor1s).
[libFuzzer] Make DataFlow scripts Python3 compatible.
Thu, Apr 4, 2:20 PM
Dor1s committed rL357726: [libFuzzer] Make DataFlow scripts Python3 compatible..
[libFuzzer] Make DataFlow scripts Python3 compatible.
Thu, Apr 4, 2:19 PM
Dor1s committed rCRT357726: [libFuzzer] Make DataFlow scripts Python3 compatible..
[libFuzzer] Make DataFlow scripts Python3 compatible.
Thu, Apr 4, 2:19 PM
Dor1s closed D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..
Thu, Apr 4, 2:19 PM · Restricted Project, Restricted Project
Dor1s added a comment to D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..

Kostya / Matt, this is fairly minor change, PTAL.

Thu, Apr 4, 12:35 PM · Restricted Project, Restricted Project
Dor1s created D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..
Thu, Apr 4, 12:32 PM · Restricted Project, Restricted Project

Mar 14 2019

Dor1s committed rGa80d9ce5cfa1: Speeding up llvm-cov export with multithreaded renderFiles implementation. (authored by Dor1s).
Speeding up llvm-cov export with multithreaded renderFiles implementation.
Mar 14 2019, 10:51 AM
Dor1s committed rL356178: Speeding up llvm-cov export with multithreaded renderFiles implementation..
Speeding up llvm-cov export with multithreaded renderFiles implementation.
Mar 14 2019, 10:48 AM
Dor1s closed D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..
Mar 14 2019, 10:48 AM · Restricted Project
Dor1s retitled D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation. from Speeding up llvm-cov with multithreaded renderFiles. to Speeding up llvm-cov export with multithreaded renderFiles implementation..
Mar 14 2019, 10:48 AM · Restricted Project
Dor1s updated the summary of D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..
Mar 14 2019, 10:47 AM · Restricted Project
Dor1s updated the diff for D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..

Verified that the tests are passing, getting ready to commit.

Mar 14 2019, 10:47 AM · Restricted Project
Dor1s updated the summary of D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..
Mar 14 2019, 10:47 AM · Restricted Project
Dor1s accepted D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..

Thanks for all the feedback, Max and Vedant!

@Dor1s , do you still find the comparison function confusing now that it's a lambda? It's meant to return a boolean in the manner expected by std::sort. True if the left argument is "less" than the right argument, and false otherwise.

Mar 14 2019, 7:24 AM · Restricted Project

Mar 13 2019

Dor1s added a comment to D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..

Have we written tests for the new behaviors?

Mar 13 2019, 10:56 AM · Restricted Project
Dor1s requested changes to D59277: Speeding up llvm-cov export with multithreaded renderFiles implementation..

Thanks for the patch, @sajjadm ! I left some comments. You would also need to update the documentation page and add a test for the new behavior you're introducing.

Mar 13 2019, 9:54 AM · Restricted Project

Feb 26 2019

Dor1s added a comment to D58674: [libFuzzer] Remove extra semicolons.

Btw, if there is a way to automatically detect those unnecessary semicolons, isn't there a way to automatically remove them?

Feb 26 2019, 9:17 AM · Restricted Project, Restricted Project
Dor1s accepted D58674: [libFuzzer] Remove extra semicolons.

Not sure if it's worth spending time on, but the change LGTM

Feb 26 2019, 9:17 AM · Restricted Project, Restricted Project

Feb 11 2019

Dor1s added a comment to rL353551: Document libFuzzer on Windows..

Removed my comment here and posted it on the review: https://reviews.llvm.org/D57597

Feb 11 2019, 9:57 PM
Dor1s added a comment to D57597: Document libFuzzer on Windows..

You may need to use double backticks to put something into monospaced font, see https://reviews.llvm.org/rL352890. Maybe that's why the docs are still not updated.

Feb 11 2019, 9:56 PM · Restricted Project
Dor1s added a comment to rL353551: Document libFuzzer on Windows..
Feb 11 2019, 9:56 PM

Feb 1 2019

Dor1s committed rL352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..
Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.
Feb 1 2019, 9:12 AM
Dor1s committed rC352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..
Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.
Feb 1 2019, 9:12 AM
Dor1s closed D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..
Feb 1 2019, 9:12 AM · Restricted Project
Dor1s added inline comments to D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..
Feb 1 2019, 9:02 AM · Restricted Project
Dor1s updated the diff for D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..

Clarify that only linkers other than LLD are affected.

Feb 1 2019, 9:02 AM · Restricted Project

Jan 30 2019

Dor1s added a comment to D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..

I'm not sure if I wrote down the information correctly, PTAL :)

Jan 30 2019, 2:25 PM · Restricted Project
Dor1s created D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..
Jan 30 2019, 2:24 PM · Restricted Project

Jan 15 2019

Dor1s accepted D56730: [libFuzzer] Remove unstable edge handling.

Thanks a ton, Jonathan!

Jan 15 2019, 1:34 PM

Dec 11 2018

Dor1s committed rL348863: [ASan] Minor documentation fix: clarify static linking limitation..
[ASan] Minor documentation fix: clarify static linking limitation.
Dec 11 2018, 8:50 AM
Dor1s committed rC348863: [ASan] Minor documentation fix: clarify static linking limitation..
[ASan] Minor documentation fix: clarify static linking limitation.
Dec 11 2018, 8:50 AM
Dor1s closed D55066: [ASan] Minor documentation fix: clarify static linking limitation..
Dec 11 2018, 8:50 AM

Dec 4 2018

Dor1s added a comment to D55066: [ASan] Minor documentation fix: clarify static linking limitation..

Thanks @eugenis for explaining the issue to me over chat. I've updated the CL and the description. I can abandon it though, if you find it useless.

Dec 4 2018, 2:33 PM
Dor1s retitled D55066: [ASan] Minor documentation fix: clarify static linking limitation. from [ASan] Minor documentation fix: remove static linking limitation. to [ASan] Minor documentation fix: clarify static linking limitation..
Dec 4 2018, 2:32 PM
Dor1s updated the diff for D55066: [ASan] Minor documentation fix: clarify static linking limitation..

Restore the message with a couple clarifying words.

Dec 4 2018, 2:30 PM

Dec 3 2018

Dor1s added a comment to D55066: [ASan] Minor documentation fix: clarify static linking limitation..

Sorry for the delay.
This is wrong, static linking is NOT supported.
You could be confusing it with static linking of asan runtime library to an executable - that is and has always been the default.

Dec 3 2018, 7:29 AM

Nov 30 2018

Dor1s added a comment to D55066: [ASan] Minor documentation fix: clarify static linking limitation..

PTAL, it's a single line change, I just need someone to confirm that I'm not mistaken :)

Nov 30 2018, 2:39 PM

Nov 29 2018

Dor1s created D55066: [ASan] Minor documentation fix: clarify static linking limitation..
Nov 29 2018, 10:49 AM

Nov 21 2018

Dor1s added a comment to D54771: [compiler-rt][UBSan] silence_unsigned_overflow: do *NOT* ignore *fatal* unsigned overflows.

Roman, I can land this CL for you next week, unless other reviewers have any complains :)

Nov 21 2018, 12:37 PM · Restricted Project
Dor1s accepted D54771: [compiler-rt][UBSan] silence_unsigned_overflow: do *NOT* ignore *fatal* unsigned overflows.

Nice! LGTM!

Nov 21 2018, 12:36 PM · Restricted Project

Nov 9 2018

Dor1s committed rL346514: [llvm-cov] Remove "default:" label in the switch covering all enum values..
[llvm-cov] Remove "default:" label in the switch covering all enum values.
Nov 9 2018, 8:47 AM
Dor1s closed D54323: [llvm-cov] Remove "default:" label in the switch covering all enum values..
Nov 9 2018, 8:47 AM
Dor1s accepted D54323: [llvm-cov] Remove "default:" label in the switch covering all enum values..

Self-approval for this minor fix.

Nov 9 2018, 8:46 AM
Dor1s created D54323: [llvm-cov] Remove "default:" label in the switch covering all enum values..
Nov 9 2018, 8:46 AM
Dor1s committed rL346506: [llvm-cov] Add lcov tracefile export format..
[llvm-cov] Add lcov tracefile export format.
Nov 9 2018, 8:14 AM
Dor1s closed D54266: [llvm-cov] Add lcov tracefile export format..
Nov 9 2018, 8:14 AM
Dor1s updated the summary of D54266: [llvm-cov] Add lcov tracefile export format..
Nov 9 2018, 8:14 AM

Nov 8 2018

Dor1s accepted D54266: [llvm-cov] Add lcov tracefile export format..

Thanks again!

Nov 8 2018, 4:04 PM
Dor1s accepted D54266: [llvm-cov] Add lcov tracefile export format..

Very nice!! LGTM!

Nov 8 2018, 11:27 AM

Nov 6 2018

Dor1s accepted D54180: [fuzzer] Read files as binary.

LGTM!

Nov 6 2018, 3:02 PM
Dor1s added a comment to D54180: [fuzzer] Read files as binary.

I guess it might be worth adding the binary mode argument to FuzzerMerge.cpp and FuzzerDataFlowTrace.cpp as well, since apparently we may have some unexpected platform-dependent specifics when reading files.

Nov 6 2018, 1:55 PM

Oct 26 2018

Dor1s added a comment to D53729: [llvm-cov] Don't remap existing paths.
In D53729#1277534, @vsk wrote:

Even if there's a file at the path we're supposed to remap, shouldn't we still do the remap? Couldn't the file we're intended to read be at the remapped path?

Oct 26 2018, 12:41 PM

Oct 25 2018

Dor1s added a comment to D53729: [llvm-cov] Don't remap existing paths.

@greened, thanks for the patch. Could you please share which tests were failing for you?

Oct 25 2018, 3:04 PM

Oct 12 2018

Dor1s committed rL344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl….
[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Oct 12 2018, 7:03 AM
Dor1s committed rCRT344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl….
[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Oct 12 2018, 7:03 AM
Dor1s closed D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Oct 12 2018, 7:02 AM
Dor1s committed rL344345: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping….
[SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping…
Oct 12 2018, 7:01 AM
Dor1s closed D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 12 2018, 7:01 AM

Oct 11 2018

Dor1s updated the diff for D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..

Move GlobalsToAppendToUsed.push_back call into CreateFunctionLocalArrayInSection

Oct 11 2018, 8:22 AM
Dor1s added inline comments to D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 11 2018, 8:22 AM

Oct 10 2018

Dor1s added a comment to D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..

The test is added in https://reviews.llvm.org/D53114, similarly to the existing https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/gc-sections.test

Oct 10 2018, 3:49 PM
Dor1s created D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Oct 10 2018, 3:46 PM