Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (86 w, 6 d)

Recent Activity

Fri, Oct 12

Dor1s committed rL344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl….
[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Fri, Oct 12, 7:03 AM
Dor1s committed rCRT344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl….
[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Fri, Oct 12, 7:03 AM
Dor1s closed D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Fri, Oct 12, 7:02 AM
Dor1s committed rL344345: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping….
[SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping…
Fri, Oct 12, 7:01 AM
Dor1s closed D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Fri, Oct 12, 7:01 AM

Thu, Oct 11

Dor1s updated the diff for D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..

Move GlobalsToAppendToUsed.push_back call into CreateFunctionLocalArrayInSection

Thu, Oct 11, 8:22 AM
Dor1s added inline comments to D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Thu, Oct 11, 8:22 AM

Wed, Oct 10

Dor1s added a comment to D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..

The test is added in https://reviews.llvm.org/D53114, similarly to the existing https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/gc-sections.test

Wed, Oct 10, 3:49 PM
Dor1s created D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Wed, Oct 10, 3:46 PM
Dor1s created D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Wed, Oct 10, 3:42 PM
Dor1s added a comment to D53039: [sancov] Generalize the code to get the previous instruction to multiple architectures.

LGTM

Wed, Oct 10, 9:17 AM

Tue, Oct 9

Dor1s added a comment to D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.

Btw, @george.karpenkov, have you every experienced anything similar to https://bugs.chromium.org/p/chromium/issues/detail?id=892167 ?

Tue, Oct 9, 2:53 PM · Restricted Project
Dor1s accepted D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.

I should admit that I'm not familiar with ARM offsets, but since the change fixes the test, LGTM.

Tue, Oct 9, 2:50 PM · Restricted Project

Fri, Sep 28

Dor1s accepted D52648: [Support] Listing a directory containing dangling symlinks is not an error..
Fri, Sep 28, 3:53 PM
Dor1s added inline comments to D52648: [Support] Listing a directory containing dangling symlinks is not an error..
Fri, Sep 28, 9:24 AM

Sep 6 2018

Dor1s accepted D51760: [libfuzzer] Enable trace-malloc-unballanced.test on Windows..

LGTM! I like your comment https://reviews.llvm.org/D51760#1226757, maybe you could paste it into the CL description too?

Sep 6 2018, 8:10 PM
Dor1s accepted D51739: [libfuzzer] Correct typo in comment (test commit)..
Sep 6 2018, 10:42 AM
Dor1s committed rL341562: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
[libfuzzer] Fix fuzzer-oom.test on windows and reenable it.
Sep 6 2018, 9:49 AM
Dor1s committed rCRT341562: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
[libfuzzer] Fix fuzzer-oom.test on windows and reenable it.
Sep 6 2018, 9:49 AM
Dor1s closed D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
Sep 6 2018, 9:49 AM
Dor1s updated the diff for D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..

getting ready to land.

Sep 6 2018, 9:48 AM
Dor1s updated the summary of D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
Sep 6 2018, 9:47 AM
Dor1s accepted D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..

I wonder if there is any trick in lit to resolve this .exe issue. How do other tests work on windows? I see that /compiler-rt/test/asan/TestCases/Windows/ has a bunch of tests that don't use .exe, but some of them have .exe too.

Sep 6 2018, 9:34 AM

Sep 5 2018

Dor1s committed rL341514: [libfuzzer] Temporarily disable unittests failing on Windows..
[libfuzzer] Temporarily disable unittests failing on Windows.
Sep 5 2018, 7:56 PM
Dor1s committed rCRT341514: [libfuzzer] Temporarily disable unittests failing on Windows..
[libfuzzer] Temporarily disable unittests failing on Windows.
Sep 5 2018, 7:56 PM
Dor1s closed D51712: [libfuzzer] Temporarily disable unittests failing on Windows..
Sep 5 2018, 7:56 PM
Dor1s updated the summary of D51712: [libfuzzer] Temporarily disable unittests failing on Windows..
Sep 5 2018, 7:55 PM
Dor1s updated the diff for D51712: [libfuzzer] Temporarily disable unittests failing on Windows..

Getting ready to commit.

Sep 5 2018, 7:55 PM
Dor1s accepted D51712: [libfuzzer] Temporarily disable unittests failing on Windows..

Will commit this shortly.

Sep 5 2018, 7:51 PM
Dor1s committed rL341473: Enable symbolize-deadlock.test on Windows.
Enable symbolize-deadlock.test on Windows
Sep 5 2018, 7:45 AM
Dor1s committed rCRT341473: Enable symbolize-deadlock.test on Windows.
Enable symbolize-deadlock.test on Windows
Sep 5 2018, 7:45 AM
Dor1s closed D51685: Enable symbolize-deadlock.test on Windows.
Sep 5 2018, 7:45 AM
Dor1s accepted D51685: Enable symbolize-deadlock.test on Windows.
Sep 5 2018, 7:45 AM
Dor1s updated the summary of D51685: Enable symbolize-deadlock.test on Windows.
Sep 5 2018, 7:45 AM
Dor1s updated the diff for D51685: Enable symbolize-deadlock.test on Windows.

fix the filepaths

Sep 5 2018, 7:45 AM

Aug 30 2018

Dor1s added a comment to D51503: [libFuzzer] Optimize Basename.

Doesn't compiler optimize it anyway? Would it make more sense to mark GetSeparator() inline or just put the separator into a constant variable?

Aug 30 2018, 12:39 PM

Aug 29 2018

Dor1s committed rL340976: [libFuzzer] Remove mutation stats and weighted mutation selection..
[libFuzzer] Remove mutation stats and weighted mutation selection.
Aug 29 2018, 2:54 PM
Dor1s committed rCRT340976: [libFuzzer] Remove mutation stats and weighted mutation selection..
[libFuzzer] Remove mutation stats and weighted mutation selection.
Aug 29 2018, 2:54 PM
Dor1s closed D51455: [libFuzzer] Remove mutation stats and weighted mutation selection..
Aug 29 2018, 2:54 PM
Dor1s created D51455: [libFuzzer] Remove mutation stats and weighted mutation selection..
Aug 29 2018, 12:57 PM

Aug 8 2018

Dor1s committed rL339249: [libFuzzer] Optimize handle unstable checks by reducing iterations.
[libFuzzer] Optimize handle unstable checks by reducing iterations
Aug 8 2018, 7:33 AM
Dor1s committed rCRT339249: [libFuzzer] Optimize handle unstable checks by reducing iterations.
[libFuzzer] Optimize handle unstable checks by reducing iterations
Aug 8 2018, 7:33 AM
Dor1s closed D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.
Aug 8 2018, 7:33 AM
Dor1s updated the summary of D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.
Aug 8 2018, 6:46 AM
Dor1s updated the diff for D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.

Rebase and getting ready to land

Aug 8 2018, 6:46 AM

Aug 7 2018

Dor1s accepted D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.

Nice! Do you have an estimate on the performance improvement? The code becomes slightly harder to read, but I guess it's worth it.

Aug 7 2018, 3:33 PM
Dor1s added a reviewer for D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations: morehouse.
Aug 7 2018, 3:33 PM
Dor1s committed rL339143: [libFuzzer] Disable print_unstable_stats.test for aarch64..
[libFuzzer] Disable print_unstable_stats.test for aarch64.
Aug 7 2018, 7:22 AM
Dor1s committed rCRT339143: [libFuzzer] Disable print_unstable_stats.test for aarch64..
[libFuzzer] Disable print_unstable_stats.test for aarch64.
Aug 7 2018, 7:22 AM
Dor1s closed D50386: [libFuzzer] Disable print_unstable_stats.test for aarch64..
Aug 7 2018, 7:22 AM
Dor1s accepted D50386: [libFuzzer] Disable print_unstable_stats.test for aarch64..

Self-approval for a trivial change.

Aug 7 2018, 7:22 AM
Dor1s created D50386: [libFuzzer] Disable print_unstable_stats.test for aarch64..
Aug 7 2018, 7:21 AM

Aug 6 2018

Dor1s committed rL339081: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
[libFuzzer] Add unstable function printing to print_unstable_stats flag
Aug 6 2018, 4:15 PM
Dor1s committed rCRT339081: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
[libFuzzer] Add unstable function printing to print_unstable_stats flag
Aug 6 2018, 4:14 PM
Dor1s closed D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
Aug 6 2018, 4:14 PM
Dor1s updated the diff for D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

rebase and getting ready to land

Aug 6 2018, 4:14 PM
Dor1s updated the summary of D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
Aug 6 2018, 4:00 PM
Dor1s accepted D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

LGTM, will land soon

Aug 6 2018, 3:40 PM
Dor1s added a comment to D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

Please update the CL summary and description. LGTM, otherwise.

Aug 6 2018, 9:20 AM

Aug 3 2018

Dor1s added a comment to D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

Very nice!

Aug 3 2018, 12:32 PM

Aug 2 2018

Dor1s committed rL338776: [libFuzzer] Initial implementation of weighted mutation leveraging during….
[libFuzzer] Initial implementation of weighted mutation leveraging during…
Aug 2 2018, 3:30 PM
Dor1s committed rCRT338776: [libFuzzer] Initial implementation of weighted mutation leveraging during….
[libFuzzer] Initial implementation of weighted mutation leveraging during…
Aug 2 2018, 3:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Aug 2 2018, 3:30 PM
Dor1s updated the diff for D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Rebase

Aug 2 2018, 3:28 PM
Dor1s updated the summary of D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 3:19 PM
Dor1s updated the diff for D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Getting ready to land.

Aug 2 2018, 3:14 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 1:52 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 9:21 AM
Dor1s accepted D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

LGTM

Aug 2 2018, 7:51 AM

Aug 1 2018

Dor1s added a comment to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Left a couple minor comments. Looks good otherwise. Still not happy with the test, but can't think of anything better so far.

Aug 1 2018, 4:14 PM
Dor1s added a reviewer for D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime.: morehouse.
Aug 1 2018, 4:13 PM
Dor1s added a comment to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

I don't like the test as it only tests that we do not completely break libFuzzer, but doesn't test the feature itself. I'll play with some ideas locally, will share those if anything works out. Otherwise, I guess we'll proceed with this test.

Aug 1 2018, 8:54 AM

Jul 31 2018

Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 31 2018, 4:21 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 31 2018, 11:26 AM

Jul 30 2018

Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 30 2018, 5:27 PM

Jul 27 2018

Dor1s added inline comments to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 27 2018, 2:28 PM
Dor1s added inline comments to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 27 2018, 2:13 PM
Dor1s added a comment to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Haven't looked at the test yet, as the code needs a lot of clean up.

Jul 27 2018, 1:44 PM

Jul 26 2018

Dor1s added inline comments to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 26 2018, 10:01 AM
Dor1s added inline comments to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 26 2018, 9:58 AM

Jul 25 2018

Dor1s accepted D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.

LGTM

Jul 25 2018, 10:59 PM
Dor1s added inline comments to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 25 2018, 5:29 PM
Dor1s updated subscribers of D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 25 2018, 5:29 PM
Dor1s updated subscribers of D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.

PTAL
Added comment before c < 1000
Moved enum to FuzzerOptions and included them on necessary files.

Jul 25 2018, 4:36 PM
Dor1s committed rL337949: [libFuzzer] Disable handle-unstable.test for ARM and delete duplicated test….
[libFuzzer] Disable handle-unstable.test for ARM and delete duplicated test…
Jul 25 2018, 11:34 AM
Dor1s committed rCRT337949: [libFuzzer] Disable handle-unstable.test for ARM and delete duplicated test….
[libFuzzer] Disable handle-unstable.test for ARM and delete duplicated test…
Jul 25 2018, 11:34 AM
Dor1s closed D49810: [libFuzzer] Disable handle-unstable.test for ARM and delete duplicated test file..
Jul 25 2018, 11:34 AM
Dor1s created D49810: [libFuzzer] Disable handle-unstable.test for ARM and delete duplicated test file..
Jul 25 2018, 11:24 AM
Dor1s added a comment to D49525: [libFuzzer] Handle unstable edges by using minimum hit counts.

Kevin, looks like test is not fully deterministic :(

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/5509

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/5509/steps/ninja%20check%202/logs/FAIL%3A%20libFuzzer%3A%3A%20handle_unstable_minunstable.test

This is the first testbot failure I've seen so far, so am not reverting the change yet, but please take a look into why the test might be failing sometimes.

It seems to have be failing for aarch64 since it was introduced:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/5509 is failing and covers the range which added this test
http://lab.llvm.org:8011/waterfall?show=clang-cmake-aarch64-full shows that the test has been failing since that build onwards, except for build 5514 which was interrupted before stage2 tests were run.

Jul 25 2018, 10:59 AM
Dor1s added a comment to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.

Changed UpdateUnstableCounters to get rid of indentation.
Changed ints to size_ts.

2 questions, @metzman @Dor1s .

  1. For changing UnstableMode to UnstableOptions, FuzzerDriver and FuzzerLoop do include TracePC.h, but FuzzerOptions does not. Where would be the right place to cast the int from FuzzerOptions? Would it be fine to cast it right before it gets sent to CheckForUnstableCounters in RunOne? (inside FuzzerLoop)
Jul 25 2018, 6:28 AM

Jul 24 2018

Dor1s added a comment to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.

Can you re-phrase the CL description please, because it looks like a chat message I've sent to you in the past :)

Jul 24 2018, 3:48 PM
Dor1s committed rL337853: [libFuzzer] Handle unstable edges by disregarding unstable edges.
[libFuzzer] Handle unstable edges by disregarding unstable edges
Jul 24 2018, 2:03 PM
Dor1s committed rCRT337853: [libFuzzer] Handle unstable edges by disregarding unstable edges.
[libFuzzer] Handle unstable edges by disregarding unstable edges
Jul 24 2018, 2:03 PM
Dor1s closed D49684: [libFuzzer] Handle unstable edges by disregarding unstable edges.
Jul 24 2018, 2:03 PM
Dor1s updated the diff for D49684: [libFuzzer] Handle unstable edges by disregarding unstable edges.

Rebase and getting ready to commit.

Jul 24 2018, 2:02 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 24 2018, 7:01 AM

Jul 23 2018

Dor1s added a comment to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.

Looks great! Left a couple comments + let's clean up the test. Since the test is specific for handle_unstable=3 mode, can we make it shorter, e.g. leave only 1 or 2 deterministic function, and so on. Also, let's rename the source file to HandleUnstablePoisonUnstableTest.cpp, the test file can be renamed to handle_unstable_poison_unstable.test for better readability.

Jul 23 2018, 9:07 PM
Dor1s added a comment to D49525: [libFuzzer] Handle unstable edges by using minimum hit counts.

Kevin, looks like test is not fully deterministic :(

Jul 23 2018, 8:53 PM
Dor1s added a comment to D49684: [libFuzzer] Handle unstable edges by disregarding unstable edges.

Feel free to ask Matt / Kostya to review this once my comments are addressed.

Jul 23 2018, 3:12 PM
Dor1s added a comment to D49684: [libFuzzer] Handle unstable edges by disregarding unstable edges.

I'm not sure I fully understand that approach. We put 0 into the counters for edges we think are unstable. That's fair, but every time we generate a new input that triggers such edge, we would re-run it twice just to learn again that it was unstable. Why not put something like 0xff to mark it like a covered edge, so that we would ignore any new testcases covering that?

Another concern I have is the following. Let's say we have a testcase that covers edge X in a deterministic way, we save it. Later on, we find another testcases that covers that edge, but demonstrates instability, so we mark the edge as unstable. That sort of thing may happen again and again, an edge might seem to be stable or unstable with different testcases, And we still be blowing the corpus.

What do I misunderstand?

So the reason I think putting it as an uncovered edge is a better solution is that, in the future, if we get an input that hits the the previously unstable edges deterministically, we want to award the deterministically reached input for finding the "new" edge. It may be slower as you commented, but I think that it makes more sense. If we mark those undeterministically reached edges as covered edge, inputs that reach it deterministically in the future (which I believe are the truly interesting inputs) will not be added to corpus.

Jul 23 2018, 3:10 PM