- User Since
- Feb 14 2017, 7:36 AM (86 w, 6 d)
Fri, Oct 12
Thu, Oct 11
Move GlobalsToAppendToUsed.push_back call into CreateFunctionLocalArrayInSection
Wed, Oct 10
The test is added in https://reviews.llvm.org/D53114, similarly to the existing https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/gc-sections.test
Tue, Oct 9
Btw, @george.karpenkov, have you every experienced anything similar to https://bugs.chromium.org/p/chromium/issues/detail?id=892167 ?
I should admit that I'm not familiar with ARM offsets, but since the change fixes the test, LGTM.
Fri, Sep 28
Sep 6 2018
LGTM! I like your comment https://reviews.llvm.org/D51760#1226757, maybe you could paste it into the CL description too?
getting ready to land.
I wonder if there is any trick in lit to resolve this .exe issue. How do other tests work on windows? I see that /compiler-rt/test/asan/TestCases/Windows/ has a bunch of tests that don't use .exe, but some of them have .exe too.
Sep 5 2018
Getting ready to commit.
Will commit this shortly.
fix the filepaths
Aug 30 2018
Doesn't compiler optimize it anyway? Would it make more sense to mark GetSeparator() inline or just put the separator into a constant variable?
Aug 29 2018
Aug 8 2018
Rebase and getting ready to land
Aug 7 2018
Nice! Do you have an estimate on the performance improvement? The code becomes slightly harder to read, but I guess it's worth it.
Self-approval for a trivial change.
Aug 6 2018
rebase and getting ready to land
LGTM, will land soon
Please update the CL summary and description. LGTM, otherwise.
Aug 3 2018
Aug 2 2018
Getting ready to land.
Aug 1 2018
Left a couple minor comments. Looks good otherwise. Still not happy with the test, but can't think of anything better so far.
I don't like the test as it only tests that we do not completely break libFuzzer, but doesn't test the feature itself. I'll play with some ideas locally, will share those if anything works out. Otherwise, I guess we'll proceed with this test.
Jul 31 2018
Jul 30 2018
Jul 27 2018
Haven't looked at the test yet, as the code needs a lot of clean up.
Jul 26 2018
Jul 25 2018
Jul 24 2018
Can you re-phrase the CL description please, because it looks like a chat message I've sent to you in the past :)
Rebase and getting ready to commit.
Jul 23 2018
Looks great! Left a couple comments + let's clean up the test. Since the test is specific for handle_unstable=3 mode, can we make it shorter, e.g. leave only 1 or 2 deterministic function, and so on. Also, let's rename the source file to HandleUnstablePoisonUnstableTest.cpp, the test file can be renamed to handle_unstable_poison_unstable.test for better readability.
Kevin, looks like test is not fully deterministic :(
Feel free to ask Matt / Kostya to review this once my comments are addressed.