Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (66 w, 1 d)

Recent Activity

Yesterday

Dor1s committed rL333116: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..
[libFuzzer] Don't complain about lack of interesting inputs when -runs=0.
Wed, May 23, 12:46 PM
Dor1s committed rCRT333116: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..
[libFuzzer] Don't complain about lack of interesting inputs when -runs=0.
Wed, May 23, 12:46 PM
Dor1s closed D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..
Wed, May 23, 12:46 PM
Dor1s added a comment to D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..

Thanks for the hint! All tests passed now, I'm committing.

Wed, May 23, 12:46 PM
Dor1s added a comment to D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..

An update: no tests seem to be failing due to this, but I have some build issue with dataflow.test:

Wed, May 23, 11:16 AM
Dor1s updated the diff for D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..

Remove unnecessary test modification, the default value works as well.

Wed, May 23, 11:14 AM
Dor1s updated the diff for D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..

Stop being stupid and write conditions right (i.e. remove "!")

Wed, May 23, 11:14 AM
Dor1s added a comment to D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..

FYI, this breaks some tests, but I can fix that if we agree that we need this change.

Wed, May 23, 11:12 AM
Dor1s created D47271: [libFuzzer] Don't complain about lack of interesting inputs when -runs=0..
Wed, May 23, 11:08 AM

Tue, May 22

Dor1s committed rL333034: [Coverage] Update CSS to make HTML reports copy-paste friendly..
[Coverage] Update CSS to make HTML reports copy-paste friendly.
Tue, May 22, 3:44 PM
Dor1s closed D47231: [Coverage] Update CSS to make HTML reports copy-paste friendly..
Tue, May 22, 3:44 PM
Dor1s updated the summary of D47231: [Coverage] Update CSS to make HTML reports copy-paste friendly..
Tue, May 22, 2:57 PM
Dor1s updated the summary of D47231: [Coverage] Update CSS to make HTML reports copy-paste friendly..
Tue, May 22, 2:55 PM
Dor1s created D47231: [Coverage] Update CSS to make HTML reports copy-paste friendly..
Tue, May 22, 2:54 PM

Wed, May 16

Dor1s committed rL332507: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
[libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer).
Wed, May 16, 11:23 AM
Dor1s committed rCRT332507: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
[libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer).
Wed, May 16, 11:23 AM
Dor1s closed D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
Wed, May 16, 11:23 AM
Dor1s updated the summary of D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
Wed, May 16, 10:58 AM
Dor1s updated the diff for D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..

Address review comments: remove unused header + add a comment regarding "noinline"

Wed, May 16, 10:58 AM
Dor1s added a comment to D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..

Neat. Was this generated programmatically?

Wed, May 16, 10:58 AM
Dor1s updated the summary of D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
Wed, May 16, 10:22 AM

Tue, May 15

Dor1s updated the summary of D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
Tue, May 15, 7:36 PM
Dor1s created D46924: [libFuzzer] add a symbolic execution puzzle (difficult for today's libFuzzer)..
Tue, May 15, 7:36 PM

Wed, May 9

Dor1s accepted D46666: [libFuzzer] Experimental data flow tracer for fuzz targets..

LGTM! Left some questions though, mostly for my own education, I guess 😛

Wed, May 9, 7:36 PM

Tue, May 8

Dor1s committed rL331801: [Coverage] Take filenames into account when loading function records..
[Coverage] Take filenames into account when loading function records.
Tue, May 8, 12:30 PM
Dor1s closed D46478: [Coverage] Take filenames into account when loading function records..
Tue, May 8, 12:30 PM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

remove the header from the proper file

Tue, May 8, 12:29 PM
Dor1s added inline comments to D46478: [Coverage] Take filenames into account when loading function records..
Tue, May 8, 12:27 PM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

remove unnecessary header include

Tue, May 8, 12:27 PM
Dor1s added inline comments to D46478: [Coverage] Take filenames into account when loading function records..
Tue, May 8, 11:36 AM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

Use hash-based DenseMap for filenames and hash-based DenseSet for function names

Tue, May 8, 11:33 AM
Dor1s retitled D46478: [Coverage] Take filenames into account when loading function records. from [Coverage] Do not skip functions with the same name when loading CoverageMapping. to [Coverage] Take filenames into account when loading function records..
Tue, May 8, 8:59 AM
Dor1s added a comment to D46478: [Coverage] Take filenames into account when loading function records..
In D46478#1090589, @vsk wrote:

...
Maybe you could change the FunctionNames StringSet to some kind of filename-based map.

Tue, May 8, 8:57 AM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

Added filenames into consideration whether a record should be loaded or skipped

Tue, May 8, 8:54 AM

Mon, May 7

Dor1s added a comment to D46478: [Coverage] Take filenames into account when loading function records..
In D46478#1090568, @vsk wrote:
LLVM-Unit :: ProfileData/./ProfileDataTests/ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0

This test was added in r284251 along with the initial support for loading coverage data from multiple object files. The basic idea behind seems reasonable, as it makes sense to skip records which are exact duplicates. Do you think the duplicate detection could be enhanced by taking filenames and function hashes into account?

  • Ah, I see your update to the unit test. Yes, I think a version of loadFunctionRecord which satisfies this test would be great.
Mon, May 7, 3:48 PM
Dor1s added a comment to D46478: [Coverage] Take filenames into account when loading function records..

Another option would be to implement loadFunctionRecord in a way that it would pass the updated CoverageMappingTest.cpp test.

Mon, May 7, 3:38 PM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

update skip_duplicate_function_record to reflect a change necessary to fix the issue

Mon, May 7, 3:36 PM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

fix a typo

Mon, May 7, 3:31 PM
Dor1s added a comment to D46478: [Coverage] Take filenames into account when loading function records..

Well, it doesn't look like skip_duplicate_function_record make a lot of sense...

Mon, May 7, 3:24 PM
Dor1s updated the diff for D46478: [Coverage] Take filenames into account when loading function records..

Added an example of test that would fail without the change and pass with it.

Mon, May 7, 3:22 PM
Dor1s added a comment to D46478: [Coverage] Take filenames into account when loading function records..

Thanks Vedant! The following tests trigger that branch:

Mon, May 7, 3:13 PM

Fri, May 4

Dor1s added a comment to D46478: [Coverage] Take filenames into account when loading function records..

Please take a look. That doesn't seem to break any tests. If there aren't any concerns, I'll add a test that would pass with this change and would fail without it.

Fri, May 4, 2:26 PM
Dor1s created D46478: [Coverage] Take filenames into account when loading function records..
Fri, May 4, 2:24 PM
Dor1s created D46474: Temp local change for dumping coverage features..
Fri, May 4, 2:16 PM

Apr 9 2018

Dor1s committed rL329581: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..
[llvm-cov] Implement -ignore-filename-regex= option for excluding source files.
Apr 9 2018, 8:23 AM
Dor1s closed D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..
Apr 9 2018, 8:23 AM
Dor1s added a comment to D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..
In D43907#1060440, @vsk wrote:

It does seem like the logic to get a filtered list of files could be factored out. Forwarding CodeCoverageTool into CoverageReport, etc. might be a good way to achieve that. Another option is to add a utility to CoverageViewOptions, which should already be threaded through.

Apr 9 2018, 8:23 AM

Apr 6 2018

Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Add one more test to ensure that ignore-filename-regex is applied even when SOURCES are specified.

Apr 6 2018, 3:43 PM
Dor1s added a comment to D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Vedant, thanks for the awesome suggestions. I've addressed those.

Apr 6 2018, 3:37 PM
Dor1s retitled D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files. from [llvm-cov] Implement -ignore-source-regex= option for excluding source files. to [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..
Apr 6 2018, 3:27 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Address review comments: rename "source" to "filename" and move new logic into CoverageFilters.

Apr 6 2018, 3:26 PM

Apr 5 2018

Dor1s added a comment to D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Sure! I've reverted all changes that are not necessary for adding the new option.

Apr 5 2018, 3:20 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Finish revert of clang-format.

Apr 5 2018, 3:19 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Revert clang-format and remove CoverageExporter.cpp which is unnecessary at this point.

Apr 5 2018, 3:18 PM
Dor1s added a comment to D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Please take a look when you get a chance :)

Apr 5 2018, 1:38 PM
Dor1s added reviewers for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files.: vsk, morehouse, liaoyuke.
Apr 5 2018, 1:38 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Use clang-format on the modified and added files.

Apr 5 2018, 1:34 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Minor fixes after self-review + update the documentation page.

Apr 5 2018, 1:26 PM
Dor1s retitled D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files. from Draft to [llvm-cov] Implement -ignore-source-regex= option for excluding source files..
Apr 5 2018, 1:08 PM
Dor1s committed rL329338: [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist..
[llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist.
Apr 5 2018, 12:46 PM
Dor1s closed D44960: [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist..
Apr 5 2018, 12:46 PM
Dor1s retitled D44960: [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist. from Prevent llvm-cov from hanging when a symblink doesn't exist. to [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist..
Apr 5 2018, 12:41 PM
Dor1s updated the summary of D44960: [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist..
Apr 5 2018, 12:41 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

This version works, but I need to self-review it first.

Apr 5 2018, 12:39 PM

Apr 4 2018

Dor1s committed rL329223: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.
Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960
Apr 4 2018, 12:52 PM
Dor1s committed rC329223: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.
Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960
Apr 4 2018, 12:52 PM
Dor1s closed D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.
Apr 4 2018, 12:52 PM
Dor1s updated the diff for D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.

Resolve merge conflicts and fix whitespaces.

Apr 4 2018, 12:45 PM
Dor1s retitled D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960 from Fixes errors caused by https://reviews.llvm.org/D44960 to Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.
Apr 4 2018, 12:31 PM
Dor1s commandeered D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.
Apr 4 2018, 12:31 PM
Dor1s updated the diff for D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..

Still draft, in the middle of refactoring

Apr 4 2018, 12:16 PM
Dor1s added a comment to D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.

Thanks a lot, Vedant! No worries, I'll commit it on behalf of Yuke @liaoyuke

Apr 4 2018, 12:15 PM

Apr 3 2018

Dor1s added a comment to D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.

Friendly ping. We'll probably land it tomorrow anyway, as it blocks another fix needed for llvm-cov, but having another pair of eyes to look at this would be still helpful :)

Apr 3 2018, 7:21 PM

Apr 2 2018

Dor1s accepted D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960.

Looks good from my perspective, added Peter and Zachary who might know this code better :)

Apr 2 2018, 1:08 PM
Dor1s added reviewers for D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960: pcc, zturner.
Apr 2 2018, 1:05 PM

Mar 28 2018

Dor1s added inline comments to D44960: [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist..
Mar 28 2018, 8:12 AM

Mar 27 2018

Dor1s added inline comments to D44960: [llvm-cov] Prevent llvm-cov from hanging when a symblink doesn't exist..
Mar 27 2018, 4:22 PM

Feb 28 2018

Dor1s created D43907: [llvm-cov] Implement -ignore-filename-regex= option for excluding source files..
Feb 28 2018, 1:50 PM

Jan 31 2018

Dor1s committed rL323923: [llvm-cov] Fix incorrect usage of .precision specifier in format() call..
[llvm-cov] Fix incorrect usage of .precision specifier in format() call.
Jan 31 2018, 2:15 PM
Dor1s closed D42767: [llvm-cov] Fix incorrect usage of .precision specifier in format() call..
Jan 31 2018, 2:15 PM
Dor1s accepted D42767: [llvm-cov] Fix incorrect usage of .precision specifier in format() call..

Self-approval for a single character change.

Jan 31 2018, 2:15 PM
Dor1s created D42767: [llvm-cov] Fix incorrect usage of .precision specifier in format() call..
Jan 31 2018, 2:09 PM
Dor1s added inline comments to rL323892: [llvm-cov] Improvements for summary report generated in HTML format..
Jan 31 2018, 1:09 PM
Dor1s added inline comments to rL323892: [llvm-cov] Improvements for summary report generated in HTML format..
Jan 31 2018, 11:56 AM
Dor1s committed rL323892: [llvm-cov] Improvements for summary report generated in HTML format..
[llvm-cov] Improvements for summary report generated in HTML format.
Jan 31 2018, 9:41 AM
Dor1s closed D42093: [llvm-cov] Improvements for summary report generated in HTML format..
Jan 31 2018, 9:41 AM
Dor1s updated the diff for D42093: [llvm-cov] Improvements for summary report generated in HTML format..

Minor test improvement

Jan 31 2018, 12:59 AM
Dor1s updated the diff for D42093: [llvm-cov] Improvements for summary report generated in HTML format..

Update the tests

Jan 31 2018, 12:55 AM

Jan 24 2018

Dor1s added a comment to D42093: [llvm-cov] Improvements for summary report generated in HTML format..

Vedant, friendly ping :)

Jan 24 2018, 3:14 PM

Jan 16 2018

Dor1s added a comment to D42093: [llvm-cov] Improvements for summary report generated in HTML format..

Changes look nice visually. I think standard practice is to right-align numerical entries, but that might require a bit more work to pad properly.

Jan 16 2018, 12:30 PM

Jan 15 2018

Dor1s updated the summary of D42093: [llvm-cov] Improvements for summary report generated in HTML format..
Jan 15 2018, 10:27 PM
Dor1s added a comment to D42093: [llvm-cov] Improvements for summary report generated in HTML format..

I need to fix some style-related tests, but first I'd like to see what you think about the change.

Jan 15 2018, 10:22 PM
Dor1s created D42093: [llvm-cov] Improvements for summary report generated in HTML format..
Jan 15 2018, 10:20 PM

Jan 12 2018

Dor1s committed rL322397: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..
[llvm-cov] Skip unnecessary coverage computations for "export -summary-only".
Jan 12 2018, 12:33 PM
Dor1s closed D42000: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..
Jan 12 2018, 12:32 PM
Dor1s updated the summary of D42000: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..
Jan 12 2018, 10:53 AM
Dor1s updated the diff for D42000: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..

Clean up the code

Jan 12 2018, 10:51 AM
Dor1s updated the diff for D42000: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..

Refactor methods for file rendering

Jan 12 2018, 10:47 AM
Dor1s updated the summary of D42000: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..
Jan 12 2018, 10:29 AM
Dor1s created D42000: [llvm-cov] Skip unnecessary coverage computations for "export -summary-only"..
Jan 12 2018, 10:28 AM