Page MenuHomePhabricator

Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (95 w, 3 d)

Recent Activity

Tue, Dec 11

Dor1s committed rL348863: [ASan] Minor documentation fix: clarify static linking limitation..
[ASan] Minor documentation fix: clarify static linking limitation.
Tue, Dec 11, 8:50 AM
Dor1s committed rC348863: [ASan] Minor documentation fix: clarify static linking limitation..
[ASan] Minor documentation fix: clarify static linking limitation.
Tue, Dec 11, 8:50 AM
Dor1s closed D55066: [ASan] Minor documentation fix: clarify static linking limitation..
Tue, Dec 11, 8:50 AM

Tue, Dec 4

Dor1s added a comment to D55066: [ASan] Minor documentation fix: clarify static linking limitation..

Thanks @eugenis for explaining the issue to me over chat. I've updated the CL and the description. I can abandon it though, if you find it useless.

Tue, Dec 4, 2:33 PM
Dor1s retitled D55066: [ASan] Minor documentation fix: clarify static linking limitation. from [ASan] Minor documentation fix: remove static linking limitation. to [ASan] Minor documentation fix: clarify static linking limitation..
Tue, Dec 4, 2:32 PM
Dor1s updated the diff for D55066: [ASan] Minor documentation fix: clarify static linking limitation..

Restore the message with a couple clarifying words.

Tue, Dec 4, 2:30 PM

Mon, Dec 3

Dor1s added a comment to D55066: [ASan] Minor documentation fix: clarify static linking limitation..

Sorry for the delay.
This is wrong, static linking is NOT supported.
You could be confusing it with static linking of asan runtime library to an executable - that is and has always been the default.

Mon, Dec 3, 7:29 AM

Fri, Nov 30

Dor1s added a comment to D55066: [ASan] Minor documentation fix: clarify static linking limitation..

PTAL, it's a single line change, I just need someone to confirm that I'm not mistaken :)

Fri, Nov 30, 2:39 PM

Thu, Nov 29

Dor1s created D55066: [ASan] Minor documentation fix: clarify static linking limitation..
Thu, Nov 29, 10:49 AM

Wed, Nov 21

Dor1s added a comment to D54771: [compiler-rt][UBSan] silence_unsigned_overflow: do *NOT* ignore *fatal* unsigned overflows.

Roman, I can land this CL for you next week, unless other reviewers have any complains :)

Wed, Nov 21, 12:37 PM · Restricted Project
Dor1s accepted D54771: [compiler-rt][UBSan] silence_unsigned_overflow: do *NOT* ignore *fatal* unsigned overflows.

Nice! LGTM!

Wed, Nov 21, 12:36 PM · Restricted Project

Nov 9 2018

Dor1s committed rL346514: [llvm-cov] Remove "default:" label in the switch covering all enum values..
[llvm-cov] Remove "default:" label in the switch covering all enum values.
Nov 9 2018, 8:47 AM
Dor1s closed D54323: [llvm-cov] Remove "default:" label in the switch covering all enum values..
Nov 9 2018, 8:47 AM
Dor1s accepted D54323: [llvm-cov] Remove "default:" label in the switch covering all enum values..

Self-approval for this minor fix.

Nov 9 2018, 8:46 AM
Dor1s created D54323: [llvm-cov] Remove "default:" label in the switch covering all enum values..
Nov 9 2018, 8:46 AM
Dor1s committed rL346506: [llvm-cov] Add lcov tracefile export format..
[llvm-cov] Add lcov tracefile export format.
Nov 9 2018, 8:14 AM
Dor1s closed D54266: [llvm-cov] Add lcov tracefile export format..
Nov 9 2018, 8:14 AM
Dor1s updated the summary of D54266: [llvm-cov] Add lcov tracefile export format..
Nov 9 2018, 8:14 AM

Nov 8 2018

Dor1s accepted D54266: [llvm-cov] Add lcov tracefile export format..

Thanks again!

Nov 8 2018, 4:04 PM
Dor1s accepted D54266: [llvm-cov] Add lcov tracefile export format..

Very nice!! LGTM!

Nov 8 2018, 11:27 AM

Nov 6 2018

Dor1s accepted D54180: [fuzzer] Read files as binary.

LGTM!

Nov 6 2018, 3:02 PM
Dor1s added a comment to D54180: [fuzzer] Read files as binary.

I guess it might be worth adding the binary mode argument to FuzzerMerge.cpp and FuzzerDataFlowTrace.cpp as well, since apparently we may have some unexpected platform-dependent specifics when reading files.

Nov 6 2018, 1:55 PM

Oct 26 2018

Dor1s added a comment to D53729: [llvm-cov] Don't remap existing paths.
In D53729#1277534, @vsk wrote:

Even if there's a file at the path we're supposed to remap, shouldn't we still do the remap? Couldn't the file we're intended to read be at the remapped path?

Oct 26 2018, 12:41 PM

Oct 25 2018

Dor1s added a comment to D53729: [llvm-cov] Don't remap existing paths.

@greened, thanks for the patch. Could you please share which tests were failing for you?

Oct 25 2018, 3:04 PM

Oct 12 2018

Dor1s committed rL344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl….
[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Oct 12 2018, 7:03 AM
Dor1s committed rCRT344346: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl….
[libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl…
Oct 12 2018, 7:03 AM
Dor1s closed D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Oct 12 2018, 7:02 AM
Dor1s committed rL344345: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping….
[SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping…
Oct 12 2018, 7:01 AM
Dor1s closed D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 12 2018, 7:01 AM

Oct 11 2018

Dor1s updated the diff for D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..

Move GlobalsToAppendToUsed.push_back call into CreateFunctionLocalArrayInSection

Oct 11 2018, 8:22 AM
Dor1s added inline comments to D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 11 2018, 8:22 AM

Oct 10 2018

Dor1s added a comment to D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..

The test is added in https://reviews.llvm.org/D53114, similarly to the existing https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/gc-sections.test

Oct 10 2018, 3:49 PM
Dor1s created D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Oct 10 2018, 3:46 PM
Dor1s created D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 10 2018, 3:42 PM
Dor1s added a comment to D53039: [sancov] Generalize the code to get the previous instruction to multiple architectures.

LGTM

Oct 10 2018, 9:17 AM

Oct 9 2018

Dor1s added a comment to D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.

Btw, @george.karpenkov, have you every experienced anything similar to https://bugs.chromium.org/p/chromium/issues/detail?id=892167 ?

Oct 9 2018, 2:53 PM · Restricted Project
Dor1s accepted D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.

I should admit that I'm not familiar with ARM offsets, but since the change fixes the test, LGTM.

Oct 9 2018, 2:50 PM · Restricted Project

Sep 28 2018

Dor1s accepted D52648: [Support] Listing a directory containing dangling symlinks is not an error..
Sep 28 2018, 3:53 PM
Dor1s added inline comments to D52648: [Support] Listing a directory containing dangling symlinks is not an error..
Sep 28 2018, 9:24 AM

Sep 6 2018

Dor1s accepted D51760: [libfuzzer] Enable trace-malloc-unballanced.test on Windows..

LGTM! I like your comment https://reviews.llvm.org/D51760#1226757, maybe you could paste it into the CL description too?

Sep 6 2018, 8:10 PM
Dor1s accepted D51739: [libfuzzer] Correct typo in comment (test commit)..
Sep 6 2018, 10:42 AM
Dor1s committed rL341562: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
[libfuzzer] Fix fuzzer-oom.test on windows and reenable it.
Sep 6 2018, 9:49 AM
Dor1s committed rCRT341562: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
[libfuzzer] Fix fuzzer-oom.test on windows and reenable it.
Sep 6 2018, 9:49 AM
Dor1s closed D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
Sep 6 2018, 9:49 AM
Dor1s updated the diff for D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..

getting ready to land.

Sep 6 2018, 9:48 AM
Dor1s updated the summary of D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..
Sep 6 2018, 9:47 AM
Dor1s accepted D51735: [libfuzzer] Fix fuzzer-oom.test on windows and reenable it..

I wonder if there is any trick in lit to resolve this .exe issue. How do other tests work on windows? I see that /compiler-rt/test/asan/TestCases/Windows/ has a bunch of tests that don't use .exe, but some of them have .exe too.

Sep 6 2018, 9:34 AM

Sep 5 2018

Dor1s committed rL341514: [libfuzzer] Temporarily disable unittests failing on Windows..
[libfuzzer] Temporarily disable unittests failing on Windows.
Sep 5 2018, 7:56 PM
Dor1s committed rCRT341514: [libfuzzer] Temporarily disable unittests failing on Windows..
[libfuzzer] Temporarily disable unittests failing on Windows.
Sep 5 2018, 7:56 PM
Dor1s closed D51712: [libfuzzer] Temporarily disable unittests failing on Windows..
Sep 5 2018, 7:56 PM
Dor1s updated the summary of D51712: [libfuzzer] Temporarily disable unittests failing on Windows..
Sep 5 2018, 7:55 PM
Dor1s updated the diff for D51712: [libfuzzer] Temporarily disable unittests failing on Windows..

Getting ready to commit.

Sep 5 2018, 7:55 PM
Dor1s accepted D51712: [libfuzzer] Temporarily disable unittests failing on Windows..

Will commit this shortly.

Sep 5 2018, 7:51 PM
Dor1s committed rL341473: Enable symbolize-deadlock.test on Windows.
Enable symbolize-deadlock.test on Windows
Sep 5 2018, 7:45 AM
Dor1s committed rCRT341473: Enable symbolize-deadlock.test on Windows.
Enable symbolize-deadlock.test on Windows
Sep 5 2018, 7:45 AM
Dor1s closed D51685: Enable symbolize-deadlock.test on Windows.
Sep 5 2018, 7:45 AM
Dor1s accepted D51685: Enable symbolize-deadlock.test on Windows.
Sep 5 2018, 7:45 AM
Dor1s updated the summary of D51685: Enable symbolize-deadlock.test on Windows.
Sep 5 2018, 7:45 AM
Dor1s updated the diff for D51685: Enable symbolize-deadlock.test on Windows.

fix the filepaths

Sep 5 2018, 7:45 AM

Aug 30 2018

Dor1s added a comment to D51503: [libFuzzer] Optimize Basename.

Doesn't compiler optimize it anyway? Would it make more sense to mark GetSeparator() inline or just put the separator into a constant variable?

Aug 30 2018, 12:39 PM

Aug 29 2018

Dor1s committed rL340976: [libFuzzer] Remove mutation stats and weighted mutation selection..
[libFuzzer] Remove mutation stats and weighted mutation selection.
Aug 29 2018, 2:54 PM
Dor1s committed rCRT340976: [libFuzzer] Remove mutation stats and weighted mutation selection..
[libFuzzer] Remove mutation stats and weighted mutation selection.
Aug 29 2018, 2:54 PM
Dor1s closed D51455: [libFuzzer] Remove mutation stats and weighted mutation selection..
Aug 29 2018, 2:54 PM
Dor1s created D51455: [libFuzzer] Remove mutation stats and weighted mutation selection..
Aug 29 2018, 12:57 PM

Aug 8 2018

Dor1s committed rL339249: [libFuzzer] Optimize handle unstable checks by reducing iterations.
[libFuzzer] Optimize handle unstable checks by reducing iterations
Aug 8 2018, 7:33 AM
Dor1s committed rCRT339249: [libFuzzer] Optimize handle unstable checks by reducing iterations.
[libFuzzer] Optimize handle unstable checks by reducing iterations
Aug 8 2018, 7:33 AM
Dor1s closed D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.
Aug 8 2018, 7:33 AM
Dor1s updated the summary of D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.
Aug 8 2018, 6:46 AM
Dor1s updated the diff for D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.

Rebase and getting ready to land

Aug 8 2018, 6:46 AM

Aug 7 2018

Dor1s accepted D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations.

Nice! Do you have an estimate on the performance improvement? The code becomes slightly harder to read, but I guess it's worth it.

Aug 7 2018, 3:33 PM
Dor1s added a reviewer for D50411: [libFuzzer] Optimize handle unstable checks by reducing iterations: morehouse.
Aug 7 2018, 3:33 PM
Dor1s committed rL339143: [libFuzzer] Disable print_unstable_stats.test for aarch64..
[libFuzzer] Disable print_unstable_stats.test for aarch64.
Aug 7 2018, 7:22 AM
Dor1s committed rCRT339143: [libFuzzer] Disable print_unstable_stats.test for aarch64..
[libFuzzer] Disable print_unstable_stats.test for aarch64.
Aug 7 2018, 7:22 AM
Dor1s closed D50386: [libFuzzer] Disable print_unstable_stats.test for aarch64..
Aug 7 2018, 7:22 AM
Dor1s accepted D50386: [libFuzzer] Disable print_unstable_stats.test for aarch64..

Self-approval for a trivial change.

Aug 7 2018, 7:22 AM
Dor1s created D50386: [libFuzzer] Disable print_unstable_stats.test for aarch64..
Aug 7 2018, 7:21 AM

Aug 6 2018

Dor1s committed rL339081: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
[libFuzzer] Add unstable function printing to print_unstable_stats flag
Aug 6 2018, 4:15 PM
Dor1s committed rCRT339081: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
[libFuzzer] Add unstable function printing to print_unstable_stats flag
Aug 6 2018, 4:14 PM
Dor1s closed D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
Aug 6 2018, 4:14 PM
Dor1s updated the diff for D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

rebase and getting ready to land

Aug 6 2018, 4:14 PM
Dor1s updated the summary of D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.
Aug 6 2018, 4:00 PM
Dor1s accepted D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

LGTM, will land soon

Aug 6 2018, 3:40 PM
Dor1s added a comment to D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

Please update the CL summary and description. LGTM, otherwise.

Aug 6 2018, 9:20 AM

Aug 3 2018

Dor1s added a comment to D50264: [libFuzzer] Add unstable function printing to print_unstable_stats flag.

Very nice!

Aug 3 2018, 12:32 PM

Aug 2 2018

Dor1s committed rL338776: [libFuzzer] Initial implementation of weighted mutation leveraging during….
[libFuzzer] Initial implementation of weighted mutation leveraging during…
Aug 2 2018, 3:30 PM
Dor1s committed rCRT338776: [libFuzzer] Initial implementation of weighted mutation leveraging during….
[libFuzzer] Initial implementation of weighted mutation leveraging during…
Aug 2 2018, 3:30 PM
Dor1s closed D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 3:30 PM
Dor1s updated the diff for D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Rebase

Aug 2 2018, 3:28 PM
Dor1s updated the summary of D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 3:19 PM
Dor1s updated the diff for D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Getting ready to land.

Aug 2 2018, 3:14 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 1:52 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Aug 2 2018, 9:21 AM
Dor1s accepted D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

LGTM

Aug 2 2018, 7:51 AM

Aug 1 2018

Dor1s added a comment to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

Left a couple minor comments. Looks good otherwise. Still not happy with the test, but can't think of anything better so far.

Aug 1 2018, 4:14 PM
Dor1s added a reviewer for D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime.: morehouse.
Aug 1 2018, 4:13 PM
Dor1s added a comment to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..

I don't like the test as it only tests that we do not completely break libFuzzer, but doesn't test the feature itself. I'll play with some ideas locally, will share those if anything works out. Otherwise, I guess we'll proceed with this test.

Aug 1 2018, 8:54 AM

Jul 31 2018

Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 31 2018, 4:21 PM
Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 31 2018, 11:26 AM

Jul 30 2018

Dor1s added inline comments to D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime..
Jul 30 2018, 5:27 PM

Jul 27 2018

Dor1s added inline comments to D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Jul 27 2018, 2:28 PM