- User Since
- Feb 14 2017, 7:36 AM (105 w, 1 h)
Mon, Feb 11
Removed my comment here and posted it on the review: https://reviews.llvm.org/D57597
You may need to use double backticks to put something into monospaced font, see https://reviews.llvm.org/rL352890. Maybe that's why the docs are still not updated.
Fri, Feb 1
Clarify that only linkers other than LLD are affected.
Wed, Jan 30
I'm not sure if I wrote down the information correctly, PTAL :)
Jan 15 2019
Thanks a ton, Jonathan!
Dec 11 2018
Dec 4 2018
Thanks @eugenis for explaining the issue to me over chat. I've updated the CL and the description. I can abandon it though, if you find it useless.
Restore the message with a couple clarifying words.
Dec 3 2018
Nov 30 2018
PTAL, it's a single line change, I just need someone to confirm that I'm not mistaken :)
Nov 29 2018
Nov 21 2018
Roman, I can land this CL for you next week, unless other reviewers have any complains :)
Nov 9 2018
Self-approval for this minor fix.
Nov 8 2018
Very nice!! LGTM!
Nov 6 2018
I guess it might be worth adding the binary mode argument to FuzzerMerge.cpp and FuzzerDataFlowTrace.cpp as well, since apparently we may have some unexpected platform-dependent specifics when reading files.
Oct 26 2018
Oct 25 2018
@greened, thanks for the patch. Could you please share which tests were failing for you?
Oct 12 2018
Oct 11 2018
Move GlobalsToAppendToUsed.push_back call into CreateFunctionLocalArrayInSection
Oct 10 2018
The test is added in https://reviews.llvm.org/D53114, similarly to the existing https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/gc-sections.test
Oct 9 2018
Btw, @george.karpenkov, have you every experienced anything similar to https://bugs.chromium.org/p/chromium/issues/detail?id=892167 ?
I should admit that I'm not familiar with ARM offsets, but since the change fixes the test, LGTM.
Sep 28 2018
Sep 6 2018
LGTM! I like your comment https://reviews.llvm.org/D51760#1226757, maybe you could paste it into the CL description too?
getting ready to land.
I wonder if there is any trick in lit to resolve this .exe issue. How do other tests work on windows? I see that /compiler-rt/test/asan/TestCases/Windows/ has a bunch of tests that don't use .exe, but some of them have .exe too.
Sep 5 2018
Getting ready to commit.
Will commit this shortly.
fix the filepaths
Aug 30 2018
Doesn't compiler optimize it anyway? Would it make more sense to mark GetSeparator() inline or just put the separator into a constant variable?
Aug 29 2018
Aug 8 2018
Rebase and getting ready to land
Aug 7 2018
Nice! Do you have an estimate on the performance improvement? The code becomes slightly harder to read, but I guess it's worth it.
Self-approval for a trivial change.
Aug 6 2018
rebase and getting ready to land
LGTM, will land soon
Please update the CL summary and description. LGTM, otherwise.
Aug 3 2018
Aug 2 2018