Page MenuHomePhabricator

Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (123 w, 12 h)

Recent Activity

Thu, Jun 20

Dor1s accepted D63581: (Reland with changes) Adding a function for setting coverage output file..

LGTM, thanks @sajjadm !

Thu, Jun 20, 4:21 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63571: Fix lcov coverage report contains functions from other compilation units..

+1, the change looks good, but if you could modify the existing test for lcov export in a way so that it starts failing with the existing implementation but will pass after your chance, that'd be awesome.

Thu, Jun 20, 7:01 AM · Restricted Project
Dor1s added a comment to D63571: Fix lcov coverage report contains functions from other compilation units..

+1, the change looks good, but if you could modify the existing test for lcov export in a way so that it starts failing with the existing implementation but will pass after your chance, that'd be awesome.

Thu, Jun 20, 6:57 AM · Restricted Project

Wed, Jun 19

Dor1s committed rG46972b065c8a: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider. (authored by Dor1s).
[libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider.
Wed, Jun 19, 7:12 AM
Dor1s committed rL363805: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..
[libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider.
Wed, Jun 19, 7:12 AM
Dor1s closed D63553: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..
Wed, Jun 19, 7:12 AM · Restricted Project, Restricted Project
Dor1s created D63553: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..
Wed, Jun 19, 7:11 AM · Restricted Project, Restricted Project
Dor1s accepted D63553: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..

Self-approval for a minor fix.

Wed, Jun 19, 7:11 AM · Restricted Project, Restricted Project

Tue, Jun 18

Dor1s committed rGa0eb49c26e53: [libFuzzer] Improve FuzzedDataProvider helper. (authored by Dor1s).
[libFuzzer] Improve FuzzedDataProvider helper.
Tue, Jun 18, 1:27 PM
Dor1s committed rL363735: [libFuzzer] Improve FuzzedDataProvider helper..
[libFuzzer] Improve FuzzedDataProvider helper.
Tue, Jun 18, 1:26 PM
Dor1s closed D63348: [libFuzzer] Improve FuzzedDataProvider helper..
Tue, Jun 18, 1:26 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Trying rebase, re-running the tests, and committing again.

Tue, Jun 18, 1:21 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Hm, I'm doing the following:

Tue, Jun 18, 1:21 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Thanks a lot, Matt!

Tue, Jun 18, 8:40 AM · Restricted Project, Restricted Project

Mon, Jun 17

Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Ping :)

Mon, Jun 17, 1:21 PM · Restricted Project, Restricted Project

Fri, Jun 14

Dor1s committed rG0784e01a98a0: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used. (authored by Dor1s).
[libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used.
Fri, Jun 14, 12:33 PM
Dor1s committed rL363443: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..
[libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used.
Fri, Jun 14, 12:31 PM
Dor1s closed D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..
Fri, Jun 14, 12:31 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

Added a test, thanks @metzman for the idea how to test it.

Fri, Jun 14, 12:23 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

The change is tested and ready for review. Please take a look :)

Fri, Jun 14, 11:53 AM · Restricted Project, Restricted Project
Dor1s updated the summary of D63348: [libFuzzer] Improve FuzzedDataProvider helper..
Fri, Jun 14, 11:53 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D63348: [libFuzzer] Improve FuzzedDataProvider helper..

rebase

Fri, Jun 14, 11:30 AM · Restricted Project, Restricted Project
Dor1s added a comment to D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

maybe test?

Fri, Jun 14, 11:24 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Add static_assert guards to ConvertUnsignedToSigned.

Fri, Jun 14, 11:18 AM · Restricted Project, Restricted Project
Dor1s created D63348: [libFuzzer] Improve FuzzedDataProvider helper..
Fri, Jun 14, 11:14 AM · Restricted Project, Restricted Project
Dor1s created D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..
Fri, Jun 14, 7:17 AM · Restricted Project, Restricted Project

Thu, Jun 13

Dor1s accepted D63232: [Coverage] Load code coverage data from archives.

Thanks for the replies, Vedant. Still LGTM!

Thu, Jun 13, 10:34 AM · Restricted Project
Dor1s accepted D63232: [Coverage] Load code coverage data from archives.

Left some questions / suggestions, but don't see any problems, LGTM!

Thu, Jun 13, 8:44 AM · Restricted Project

Tue, Jun 11

Dor1s committed rG10ed68189a85: Add FuzzedDataProvider helper class / single header library. (authored by Dor1s).
Add FuzzedDataProvider helper class / single header library.
Tue, Jun 11, 7:29 AM
Dor1s committed rL363071: Add FuzzedDataProvider helper class / single header library..
Add FuzzedDataProvider helper class / single header library.
Tue, Jun 11, 7:29 AM
Dor1s closed D62733: Add FuzzedDataProvider helper class / single header library..
Tue, Jun 11, 7:29 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D62733: Add FuzzedDataProvider helper class / single header library..

Fix CMakeLists.txt as per Matt's comment

Tue, Jun 11, 7:28 AM · Restricted Project, Restricted Project

Mon, Jun 10

Dor1s added a comment to D62733: Add FuzzedDataProvider helper class / single header library..

Yay, the current version works across Linux / Windows / Mac without any hacks. Thanks again, Reid!

Mon, Jun 10, 1:09 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D62733: Add FuzzedDataProvider helper class / single header library..

Fix linking on Windows, get rid of unnecessary RTFuzzer dependency.

Mon, Jun 10, 12:47 PM · Restricted Project, Restricted Project
Dor1s added a comment to D62733: Add FuzzedDataProvider helper class / single header library..
In D62733#1536561, @rnk wrote:

As a fix, try adding /defaultlib:libcmt to link flags.

Mon, Jun 10, 11:36 AM · Restricted Project, Restricted Project

Fri, Jun 7

Dor1s added a comment to D62733: Add FuzzedDataProvider helper class / single header library..

Nico, Reid, Jonathan, I'd greatly appreciate your Windows expertise here. If I remove lines 11-16 from lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp, I'm getting the following link errors on Windows:

Fri, Jun 7, 11:39 PM · Restricted Project, Restricted Project
Dor1s updated subscribers of D62733: Add FuzzedDataProvider helper class / single header library..
Fri, Jun 7, 11:37 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D62733: Add FuzzedDataProvider helper class / single header library..
Fri, Jun 7, 11:31 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D62733: Add FuzzedDataProvider helper class / single header library..

Workaround Windows-specific linking issue.

Fri, Jun 7, 11:23 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D62733: Add FuzzedDataProvider helper class / single header library..
Fri, Jun 7, 11:24 AM · Restricted Project, Restricted Project
Dor1s retitled D62733: Add FuzzedDataProvider helper class / single header library. from [WORK IN PROGRESS] Add FuzzedDataProvider helper class / single header library. to Add FuzzedDataProvider helper class / single header library..
Fri, Jun 7, 11:21 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D62733: Add FuzzedDataProvider helper class / single header library..

Remove commented line

Fri, Jun 7, 11:13 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D62733: Add FuzzedDataProvider helper class / single header library..

Add the tests.

Fri, Jun 7, 11:12 AM · Restricted Project, Restricted Project

Thu, Jun 6

Dor1s added a comment to D62541: Adding a function for setting coverage output file..

LGTM (was OOO), thanks a lot David for Sajjad for multiple iterations here. One question: was the test landed? I see it in the latest patchset (https://reviews.llvm.org/D62541?id=203034), but not in the code that was committed.

Thu, Jun 6, 7:49 AM · Restricted Project, Restricted Project

Mon, Jun 3

Dor1s updated the diff for D62733: Add FuzzedDataProvider helper class / single header library..

WIP

Mon, Jun 3, 9:44 AM · Restricted Project, Restricted Project

Fri, May 31

Dor1s created D62733: Add FuzzedDataProvider helper class / single header library..
Fri, May 31, 7:10 AM · Restricted Project, Restricted Project

Wed, May 29

Dor1s added a comment to D62541: Adding a function for setting coverage output file..

I think it'll be bad if we lose merging with this approach. Should the change be done in a way that openFileForMerging can also use the runtime provided file pointer?

Wed, May 29, 9:16 AM · Restricted Project, Restricted Project

May 20 2019

Dor1s committed rG52fa90a348c1: This change adds an API to allow setting the flag to indicate that the profile… (authored by Dor1s).
This change adds an API to allow setting the flag to indicate that the profile…
May 20 2019, 1:01 PM
Dor1s committed rL361194: This change adds an API to allow setting the flag to indicate that the profile….
This change adds an API to allow setting the flag to indicate that the profile…
May 20 2019, 1:00 PM
Dor1s committed rCRT361194: This change adds an API to allow setting the flag to indicate that the profile….
This change adds an API to allow setting the flag to indicate that the profile…
May 20 2019, 1:00 PM
Dor1s closed D62078: This change adds an API to allow setting the flag to indicate that the profile data has been dumped to the file..
May 20 2019, 1:00 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D62078: This change adds an API to allow setting the flag to indicate that the profile data has been dumped to the file..

Getting ready to commit

May 20 2019, 1:00 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D62078: This change adds an API to allow setting the flag to indicate that the profile data has been dumped to the file..
May 20 2019, 12:27 PM · Restricted Project, Restricted Project
Dor1s accepted D62078: This change adds an API to allow setting the flag to indicate that the profile data has been dumped to the file..
May 20 2019, 12:27 PM · Restricted Project, Restricted Project
Dor1s added a comment to D62078: This change adds an API to allow setting the flag to indicate that the profile data has been dumped to the file..

The change looks good to me, with one minor edit requested.

May 20 2019, 11:15 AM · Restricted Project, Restricted Project

Apr 12 2019

Dor1s committed rGb6e6d3c740a4: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. (authored by Dor1s).
[libFuzzer] Fix DataFlow.cpp logic when tracing long inputs.
Apr 12 2019, 1:59 PM
Dor1s committed rCRT358311: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
[libFuzzer] Fix DataFlow.cpp logic when tracing long inputs.
Apr 12 2019, 1:58 PM
Dor1s committed rL358311: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
[libFuzzer] Fix DataFlow.cpp logic when tracing long inputs.
Apr 12 2019, 1:58 PM
Dor1s closed D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Apr 12 2019, 1:58 PM · Restricted Project, Restricted Project
Dor1s retitled D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. from [Draft] [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. to [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Apr 12 2019, 1:30 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

fix a typo

Apr 12 2019, 1:29 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Add the test, remove debug logging, fix python3 division.

Apr 12 2019, 1:28 PM · Restricted Project, Restricted Project
Dor1s added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Btw, I did some testing locally, with a 5 bytes input. I was tracing it 3 times:

  • full
  • 0 3 bytes
  • 3 5 bytes
Apr 12 2019, 11:27 AM · Restricted Project, Restricted Project
Dor1s added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Please see this draft proposal / explanation for the issue. The bisection in python is fine! :)

Apr 12 2019, 11:14 AM · Restricted Project, Restricted Project
Dor1s updated the summary of D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Apr 12 2019, 11:10 AM · Restricted Project, Restricted Project
Dor1s retitled D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs. from [libFuzzer] Skip too long inputs in the data flow scripts. to [Draft] [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Apr 12 2019, 11:10 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

This patch fixes the issue with the long inputs by not creating DFSan labels
for the bytes which we do not trace, and by offseting the resulting labels to
make the dumps easily mergeable.

Apr 12 2019, 11:07 AM · Restricted Project, Restricted Project
Dor1s added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Hey @kcc, I've figured out what's the problem here. Will update the description and the CL shortly.

Apr 12 2019, 11:07 AM · Restricted Project, Restricted Project

Apr 11 2019

Dor1s committed rGbcb93a35c02f: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input. (authored by Dor1s).
[libFuzzer] Make MutateWithMask work when the Mask is shorter than the input.
Apr 11 2019, 11:24 AM
Dor1s committed rL358207: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
[libFuzzer] Make MutateWithMask work when the Mask is shorter than the input.
Apr 11 2019, 11:24 AM
Dor1s committed rCRT358207: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
[libFuzzer] Make MutateWithMask work when the Mask is shorter than the input.
Apr 11 2019, 11:24 AM
Dor1s closed D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
Apr 11 2019, 11:24 AM · Restricted Project, Restricted Project
Dor1s added a comment to D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..

With this change my target is finally running! :)

Apr 11 2019, 11:11 AM · Restricted Project, Restricted Project
Dor1s created D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
Apr 11 2019, 11:11 AM · Restricted Project, Restricted Project
Dor1s committed rG9d5e7ee29665: [libFuzzer] Fallback to default Mutate when MutateWithMask fails. (authored by Dor1s).
[libFuzzer] Fallback to default Mutate when MutateWithMask fails.
Apr 11 2019, 9:24 AM
Dor1s committed rL358190: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
[libFuzzer] Fallback to default Mutate when MutateWithMask fails.
Apr 11 2019, 9:24 AM
Dor1s committed rCRT358190: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
[libFuzzer] Fallback to default Mutate when MutateWithMask fails.
Apr 11 2019, 9:24 AM
Dor1s closed D60567: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
Apr 11 2019, 9:24 AM · Restricted Project, Restricted Project
Dor1s created D60567: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
Apr 11 2019, 8:21 AM · Restricted Project, Restricted Project

Apr 10 2019

Dor1s updated the diff for D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Update the test to reflect the change and make sure it passes.

Apr 10 2019, 1:45 PM · Restricted Project, Restricted Project
Dor1s created D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..
Apr 10 2019, 1:42 PM · Restricted Project, Restricted Project

Apr 4 2019

Dor1s committed rGb25040359018: [libFuzzer] Another follow up fix for Data Flow scripts in Py3. (authored by Dor1s).
[libFuzzer] Another follow up fix for Data Flow scripts in Py3.
Apr 4 2019, 3:54 PM
Dor1s committed rL357732: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
[libFuzzer] Another follow up fix for Data Flow scripts in Py3.
Apr 4 2019, 3:54 PM
Dor1s committed rCRT357732: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
[libFuzzer] Another follow up fix for Data Flow scripts in Py3.
Apr 4 2019, 3:54 PM
Dor1s closed D60289: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
Apr 4 2019, 3:54 PM · Restricted Project, Restricted Project
Dor1s accepted D60289: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..

TBR

Apr 4 2019, 3:54 PM · Restricted Project, Restricted Project
Dor1s created D60289: [libFuzzer] Another follow up fix for Data Flow scripts in Py3..
Apr 4 2019, 3:53 PM · Restricted Project, Restricted Project
Dor1s committed rG665b6b30ddea: [libFuzzer] Fix output format in data flow merge script after Py3 change. (authored by Dor1s).
[libFuzzer] Fix output format in data flow merge script after Py3 change.
Apr 4 2019, 3:21 PM
Dor1s committed rL357730: [libFuzzer] Fix output format in data flow merge script after Py3 change..
[libFuzzer] Fix output format in data flow merge script after Py3 change.
Apr 4 2019, 3:21 PM
Dor1s committed rCRT357730: [libFuzzer] Fix output format in data flow merge script after Py3 change..
[libFuzzer] Fix output format in data flow merge script after Py3 change.
Apr 4 2019, 3:21 PM
Dor1s closed D60288: [libFuzzer] Fix output format in data flow merge script after Py3 change..
Apr 4 2019, 3:21 PM · Restricted Project, Restricted Project
Dor1s accepted D60288: [libFuzzer] Fix output format in data flow merge script after Py3 change..

TBR

Apr 4 2019, 3:21 PM · Restricted Project, Restricted Project
Dor1s created D60288: [libFuzzer] Fix output format in data flow merge script after Py3 change..
Apr 4 2019, 3:21 PM · Restricted Project, Restricted Project
Dor1s committed rGc815210013f2: [libFuzzer] Make DataFlow scripts Python3 compatible. (authored by Dor1s).
[libFuzzer] Make DataFlow scripts Python3 compatible.
Apr 4 2019, 2:20 PM
Dor1s committed rL357726: [libFuzzer] Make DataFlow scripts Python3 compatible..
[libFuzzer] Make DataFlow scripts Python3 compatible.
Apr 4 2019, 2:19 PM
Dor1s committed rCRT357726: [libFuzzer] Make DataFlow scripts Python3 compatible..
[libFuzzer] Make DataFlow scripts Python3 compatible.
Apr 4 2019, 2:19 PM
Dor1s closed D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..
Apr 4 2019, 2:19 PM · Restricted Project, Restricted Project
Dor1s added a comment to D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..

Kostya / Matt, this is fairly minor change, PTAL.

Apr 4 2019, 12:35 PM · Restricted Project, Restricted Project
Dor1s created D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..
Apr 4 2019, 12:32 PM · Restricted Project, Restricted Project

Mar 14 2019

Dor1s committed rGa80d9ce5cfa1: Speeding up llvm-cov export with multithreaded renderFiles implementation. (authored by Dor1s).
Speeding up llvm-cov export with multithreaded renderFiles implementation.
Mar 14 2019, 10:51 AM