Page MenuHomePhabricator

Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (131 w, 3 d)

Recent Activity

Fri, Aug 16

Dor1s added a comment to D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..
In D66107#1633546, @kcc wrote:

I would prefer to not introduce this complexity.
For periodic pruning we can use an empty dir, like you describe.
For stats, we can use the overal corpus size (in bytes and in files)

Fri, Aug 16, 1:29 PM · Restricted Project, Restricted Project

Wed, Aug 14

Dor1s added a comment to D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

Guys, thanks a lot for the feedback! Some answers below, I'll get back to the code soon.

Wed, Aug 14, 7:31 AM · Restricted Project, Restricted Project

Tue, Aug 13

Dor1s added a comment to D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

Friendly ping :) Feedback on the description would be the most important at this point, as I feel like I can improve the code a bit more. But if you could check out the code, that would be also great. Note there are at least two TODOs that I'll address before merging. It's still a draft, even though it works.

Tue, Aug 13, 3:47 PM · Restricted Project, Restricted Project

Mon, Aug 12

Dor1s updated the diff for D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

Update the test a bit more

Mon, Aug 12, 2:52 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..
Mon, Aug 12, 2:52 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..
Mon, Aug 12, 2:52 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..
Mon, Aug 12, 2:31 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

Actually updated the test to prove everyone (including myself) that this works.

Mon, Aug 12, 2:25 PM · Restricted Project, Restricted Project
Dor1s committed rG74cec618f304: [libFuzzer] Merge: print feature coverage number as well. (authored by Dor1s).
[libFuzzer] Merge: print feature coverage number as well.
Mon, Aug 12, 1:22 PM
Dor1s committed rL368617: [libFuzzer] Merge: print feature coverage number as well..
[libFuzzer] Merge: print feature coverage number as well.
Mon, Aug 12, 1:22 PM
Dor1s closed D66030: [libFuzzer] Merge: print feature coverage number as well..
Mon, Aug 12, 1:22 PM · Restricted Project, Restricted Project
Dor1s added a comment to D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

Hi everyone,

Mon, Aug 12, 1:10 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

fix a typo

Mon, Aug 12, 1:10 PM · Restricted Project, Restricted Project
Dor1s created D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..
Mon, Aug 12, 1:10 PM · Restricted Project, Restricted Project
Dor1s added a comment to D66030: [libFuzzer] Merge: print feature coverage number as well..

@morehouse or @hctim please take a look when possible :)

Mon, Aug 12, 7:52 AM · Restricted Project, Restricted Project

Fri, Aug 9

Dor1s created D66030: [libFuzzer] Merge: print feature coverage number as well..
Fri, Aug 9, 1:58 PM · Restricted Project, Restricted Project
Dor1s committed rG3653aeeffa19: [libFuzzer] Merge: print stats after reading the output corpus dir. (authored by Dor1s).
[libFuzzer] Merge: print stats after reading the output corpus dir.
Fri, Aug 9, 11:21 AM
Dor1s committed rL368461: [libFuzzer] Merge: print stats after reading the output corpus dir..
[libFuzzer] Merge: print stats after reading the output corpus dir.
Fri, Aug 9, 11:21 AM
Dor1s closed D66020: [libFuzzer] Merge: print stats after reading the output corpus dir..
Fri, Aug 9, 11:21 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D66020: [libFuzzer] Merge: print stats after reading the output corpus dir..

Use LOADED instead of INITED, plus fix alignment of keywords in the log

Fri, Aug 9, 11:12 AM · Restricted Project, Restricted Project
Dor1s created D66020: [libFuzzer] Merge: print stats after reading the output corpus dir..
Fri, Aug 9, 11:03 AM · Restricted Project, Restricted Project
Dor1s committed rGf8744ab57a79: [compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix. (authored by Dor1s).
[compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix.
Fri, Aug 9, 9:01 AM
Dor1s committed rL368448: [compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix..
[compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix.
Fri, Aug 9, 9:01 AM
Dor1s closed D66017: [compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix..
Fri, Aug 9, 9:01 AM · Restricted Project, Restricted Project
Dor1s accepted D66017: [compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix..

Trivial change.

Fri, Aug 9, 9:00 AM · Restricted Project, Restricted Project
Dor1s created D66017: [compiler-rt] FuzzedDataProvider: use C++ headers only instead of a C/C++ mix..
Fri, Aug 9, 9:00 AM · Restricted Project, Restricted Project

Thu, Aug 8

Dor1s added a comment to D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..

FTR, changed the extension back to .h in r368331.

Thu, Aug 8, 5:16 PM · Restricted Project, Restricted Project
Dor1s committed rGdf3b465c9c4f: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP. (authored by Dor1s).
[compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP.
Thu, Aug 8, 12:51 PM
Dor1s committed rL368331: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
[compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP.
Thu, Aug 8, 12:51 PM
Dor1s closed D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Thu, Aug 8, 12:50 PM · Restricted Project, Restricted Project
Dor1s added a comment to D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..

@morehouse the CL got a little messy because of the renaming, but I'd appreciate if you could take a look at the new version of ConsumeFloatingPointInRange, it's ~20 lines. Thanks!

Thu, Aug 8, 8:39 AM · Restricted Project, Restricted Project
Dor1s updated the summary of D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Thu, Aug 8, 8:37 AM · Restricted Project, Restricted Project
Dor1s added a comment to D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..

Re-written ConsumeFloatingPointInRange in another fashion. Will describe the new logic in the description.

Thu, Aug 8, 8:33 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..

Re-write ConsumeFloatingPointInRange, change extension back to .h

Thu, Aug 8, 8:33 AM · Restricted Project, Restricted Project

Wed, Aug 7

Dor1s added inline comments to D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Wed, Aug 7, 9:16 PM · Restricted Project, Restricted Project
Dor1s added a comment to D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..

Objection: .hpp is not idiomatic in LLVM.

Thanks for the comment! I was wondering about that, but haven't found any guidelines restricting or discouraging this. Also, I've seen some .hpp files in LLVM.

IMO .hpp makes much more sense for a header like this (C++ with implementation), especially given that it's a public header provided via "include" directory.

With all of that, I'd prefer setting up a precedent for respecting .hpp files, assuming that I'm not violating any strict requirements :)

$ git ls-files '*.hpp' | wc -l
      43
$ git ls-files '*.h' | wc -l
    7151

And almost all of the existing 43 hpp files are test inputs. So +1 to the objection – we virtually don't have .hpp files in LLVM.

Wed, Aug 7, 9:13 PM · Restricted Project, Restricted Project
Dor1s added a comment to D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..

@morehouse Ready for review, PTAL once you get a chance :)

Wed, Aug 7, 2:41 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Wed, Aug 7, 2:40 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Wed, Aug 7, 2:35 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Wed, Aug 7, 2:35 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..

Add parens to the condition for better readability

Wed, Aug 7, 2:19 PM · Restricted Project, Restricted Project
Dor1s created D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Wed, Aug 7, 2:18 PM · Restricted Project, Restricted Project

Tue, Aug 6

Dor1s added a comment to D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..

Objection: .hpp is not idiomatic in LLVM.

Tue, Aug 6, 12:25 PM · Restricted Project, Restricted Project
Dor1s committed rG6c619aadc4cc: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes. (authored by Dor1s).
[compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes.
Tue, Aug 6, 9:03 AM
Dor1s committed rL368054: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..
[compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes.
Tue, Aug 6, 9:02 AM
Dor1s closed D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..
Tue, Aug 6, 9:01 AM · Restricted Project, Restricted Project
Dor1s accepted D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..

Self-approval for a minor change.

Tue, Aug 6, 9:01 AM · Restricted Project, Restricted Project
Dor1s created D65812: [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes..
Tue, Aug 6, 9:00 AM · Restricted Project, Restricted Project

Mon, Aug 5

Dor1s committed rGf1b0a93e3a77: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use. (authored by Dor1s).
[compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use.
Mon, Aug 5, 12:57 PM
Dor1s committed rL367917: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..
[compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use.
Mon, Aug 5, 12:55 PM
Dor1s closed D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..
Mon, Aug 5, 12:55 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

Rebase + re-run the tests locally

Mon, Aug 5, 12:54 PM · Restricted Project, Restricted Project

Fri, Aug 2

Dor1s updated the summary of D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..
Fri, Aug 2, 8:42 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

Keep the header at the old location as well for smooth migration.

Fri, Aug 2, 8:37 PM · Restricted Project, Restricted Project
Dor1s added a comment to D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

But seriously, GCC users can just grab this header and use it -- that's the current state of the world, so this CL doesn't make life for GCC users harder.

Fri, Aug 2, 10:16 AM · Restricted Project, Restricted Project
Dor1s added a comment to D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

If this change gets accepted, any clang user should be able to use it via #include <fuzzer/FuzzedDataProvider.h>, rather than have it somewhere in their repo. It is not tied to -fsanitizer=fuzzer or any other compiler flags.

I think that misses the point, it's still a compiler lock-in - does that work with gcc?

Fri, Aug 2, 10:10 AM · Restricted Project, Restricted Project
Dor1s added a comment to D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

If this change gets accepted, any clang user should be able to use it via #include <fuzzer/FuzzedDataProvider.h>, rather than have it somewhere in their repo. It is not tied to -fsanitizer=fuzzer or any other compiler flags.

Fri, Aug 2, 10:04 AM · Restricted Project, Restricted Project
Dor1s added a comment to D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

the terminology here means those are 2 separate inputs, right?

Fri, Aug 2, 9:04 AM · Restricted Project, Restricted Project
Dor1s added a comment to D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

I'm not opposing, but i have a question - this is not fuzzer specific at all, right?

Fri, Aug 2, 8:42 AM · Restricted Project, Restricted Project
Dor1s created D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..
Fri, Aug 2, 8:13 AM · Restricted Project, Restricted Project

Jul 23 2019

Dor1s committed rG374398afb784: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def (authored by Dor1s).
[libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
Jul 23 2019, 11:28 AM
Dor1s committed rL366834: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def.
[libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
Jul 23 2019, 11:28 AM
Dor1s closed D65160: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def.
Jul 23 2019, 11:28 AM · Restricted Project, Restricted Project
Dor1s accepted D65160: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def.

TBR as it seems to be a trivial fix. Tests do not break locally. Will revert if anything goes wrong :)

Jul 23 2019, 11:28 AM · Restricted Project, Restricted Project
Dor1s created D65160: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def.
Jul 23 2019, 11:28 AM · Restricted Project, Restricted Project

Jul 9 2019

Dor1s committed rG2d7399404669: [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir. (authored by Dor1s).
[libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir.
Jul 9 2019, 12:29 PM
Dor1s committed rL365544: [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir..
[libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir.
Jul 9 2019, 12:28 PM
Dor1s closed D64440: [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir..
Jul 9 2019, 12:28 PM · Restricted Project, Restricted Project
Dor1s created D64440: [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir..
Jul 9 2019, 12:20 PM · Restricted Project, Restricted Project

Jun 28 2019

Dor1s committed rG176b9f651685: [llvm-cov[ Fix lcov coverage report contains functions from other compilation… (authored by Dor1s).
[llvm-cov[ Fix lcov coverage report contains functions from other compilation…
Jun 28 2019, 8:39 AM
Dor1s committed rL364653: [llvm-cov[ Fix lcov coverage report contains functions from other compilation….
[llvm-cov[ Fix lcov coverage report contains functions from other compilation…
Jun 28 2019, 8:38 AM
Dor1s closed D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..
Jun 28 2019, 8:38 AM · Restricted Project
Dor1s updated the diff for D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..

Getting ready to commit.

Jun 28 2019, 8:38 AM · Restricted Project
Dor1s retitled D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units. from Fix lcov coverage report contains functions from other compilation units. to [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..
Jun 28 2019, 8:25 AM · Restricted Project

Jun 27 2019

Dor1s added a comment to D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..

No problem, I'll commit it tomorrow on your behalf.

Jun 27 2019, 8:27 PM · Restricted Project
Dor1s accepted D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..

Apologies for the delayed review. LGTM and thanks for the fix!

Jun 27 2019, 10:32 AM · Restricted Project

Jun 20 2019

Dor1s accepted D63581: (Reland with changes) Adding a function for setting coverage output file..

LGTM, thanks @sajjadm !

Jun 20 2019, 4:21 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..

+1, the change looks good, but if you could modify the existing test for lcov export in a way so that it starts failing with the existing implementation but will pass after your chance, that'd be awesome.

Jun 20 2019, 7:01 AM · Restricted Project
Dor1s added a comment to D63571: [llvm-cov[ Fix lcov coverage report contains functions from other compilation units..

+1, the change looks good, but if you could modify the existing test for lcov export in a way so that it starts failing with the existing implementation but will pass after your chance, that'd be awesome.

Jun 20 2019, 6:57 AM · Restricted Project

Jun 19 2019

Dor1s committed rG46972b065c8a: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider. (authored by Dor1s).
[libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider.
Jun 19 2019, 7:12 AM
Dor1s committed rL363805: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..
[libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider.
Jun 19 2019, 7:12 AM
Dor1s closed D63553: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..
Jun 19 2019, 7:12 AM · Restricted Project, Restricted Project
Dor1s created D63553: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..
Jun 19 2019, 7:11 AM · Restricted Project, Restricted Project
Dor1s accepted D63553: [libFuzzer] Remove too aggressive static_assert in FuzzedDataProvider..

Self-approval for a minor fix.

Jun 19 2019, 7:11 AM · Restricted Project, Restricted Project

Jun 18 2019

Dor1s committed rGa0eb49c26e53: [libFuzzer] Improve FuzzedDataProvider helper. (authored by Dor1s).
[libFuzzer] Improve FuzzedDataProvider helper.
Jun 18 2019, 1:27 PM
Dor1s committed rL363735: [libFuzzer] Improve FuzzedDataProvider helper..
[libFuzzer] Improve FuzzedDataProvider helper.
Jun 18 2019, 1:26 PM
Dor1s closed D63348: [libFuzzer] Improve FuzzedDataProvider helper..
Jun 18 2019, 1:26 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Trying rebase, re-running the tests, and committing again.

Jun 18 2019, 1:21 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Hm, I'm doing the following:

Jun 18 2019, 1:21 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Thanks a lot, Matt!

Jun 18 2019, 8:40 AM · Restricted Project, Restricted Project

Jun 17 2019

Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Ping :)

Jun 17 2019, 1:21 PM · Restricted Project, Restricted Project

Jun 14 2019

Dor1s committed rG0784e01a98a0: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used. (authored by Dor1s).
[libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used.
Jun 14 2019, 12:33 PM
Dor1s committed rL363443: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..
[libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used.
Jun 14 2019, 12:31 PM
Dor1s closed D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..
Jun 14 2019, 12:31 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

Added a test, thanks @metzman for the idea how to test it.

Jun 14 2019, 12:23 PM · Restricted Project, Restricted Project
Dor1s added a comment to D63348: [libFuzzer] Improve FuzzedDataProvider helper..

The change is tested and ready for review. Please take a look :)

Jun 14 2019, 11:53 AM · Restricted Project, Restricted Project
Dor1s updated the summary of D63348: [libFuzzer] Improve FuzzedDataProvider helper..
Jun 14 2019, 11:53 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D63348: [libFuzzer] Improve FuzzedDataProvider helper..

rebase

Jun 14 2019, 11:30 AM · Restricted Project, Restricted Project
Dor1s added a comment to D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

maybe test?

Jun 14 2019, 11:24 AM · Restricted Project, Restricted Project
Dor1s updated the diff for D63348: [libFuzzer] Improve FuzzedDataProvider helper..

Add static_assert guards to ConvertUnsignedToSigned.

Jun 14 2019, 11:18 AM · Restricted Project, Restricted Project