- User Since
- Feb 14 2017, 7:36 AM (66 w, 1 d)
Thanks for the hint! All tests passed now, I'm committing.
An update: no tests seem to be failing due to this, but I have some build issue with dataflow.test:
Remove unnecessary test modification, the default value works as well.
Stop being stupid and write conditions right (i.e. remove "!")
FYI, this breaks some tests, but I can fix that if we agree that we need this change.
Tue, May 22
Wed, May 16
Address review comments: remove unused header + add a comment regarding "noinline"
Tue, May 15
Wed, May 9
LGTM! Left some questions though, mostly for my own education, I guess 😛
Tue, May 8
remove the header from the proper file
remove unnecessary header include
Use hash-based DenseMap for filenames and hash-based DenseSet for function names
Added filenames into consideration whether a record should be loaded or skipped
Mon, May 7
Another option would be to implement loadFunctionRecord in a way that it would pass the updated CoverageMappingTest.cpp test.
update skip_duplicate_function_record to reflect a change necessary to fix the issue
fix a typo
Well, it doesn't look like skip_duplicate_function_record make a lot of sense...
Added an example of test that would fail without the change and pass with it.
Thanks Vedant! The following tests trigger that branch:
Fri, May 4
Please take a look. That doesn't seem to break any tests. If there aren't any concerns, I'll add a test that would pass with this change and would fail without it.
Apr 9 2018
Apr 6 2018
Add one more test to ensure that ignore-filename-regex is applied even when SOURCES are specified.
Vedant, thanks for the awesome suggestions. I've addressed those.
Address review comments: rename "source" to "filename" and move new logic into CoverageFilters.
Apr 5 2018
Sure! I've reverted all changes that are not necessary for adding the new option.
Finish revert of clang-format.
Revert clang-format and remove CoverageExporter.cpp which is unnecessary at this point.
Please take a look when you get a chance :)
Use clang-format on the modified and added files.
Minor fixes after self-review + update the documentation page.
This version works, but I need to self-review it first.
Apr 4 2018
Resolve merge conflicts and fix whitespaces.
Still draft, in the middle of refactoring
Thanks a lot, Vedant! No worries, I'll commit it on behalf of Yuke @liaoyuke
Apr 3 2018
Friendly ping. We'll probably land it tomorrow anyway, as it blocks another fix needed for llvm-cov, but having another pair of eyes to look at this would be still helpful :)
Apr 2 2018
Looks good from my perspective, added Peter and Zachary who might know this code better :)
Mar 28 2018
Mar 27 2018
Feb 28 2018
Jan 31 2018
Self-approval for a single character change.
Minor test improvement
Update the tests
Jan 24 2018
Vedant, friendly ping :)
Jan 16 2018
Jan 15 2018
I need to fix some style-related tests, but first I'd like to see what you think about the change.
Jan 12 2018
Clean up the code
Refactor methods for file rendering