- User Since
- Feb 14 2017, 7:36 AM (139 w, 2 d)
Wed, Oct 9
@Dor1s - any chance you know more folks actively working on sancov who have the bandwidth to review?
Wed, Oct 2
@vsk Vedant, sorry I'm a bit swamped right now and may not be able to review this promptly. Please let me know If my feedback is important here, I'll try to make up some time in that case. Sorry!
Wed, Sep 25
I think Matt is right, but I wouldn't mind to have the stacktrace and stats just to be consistent with the other crashes. Also, having a stacktrace should increase the chances that such a crash would be handled by fuzzing infrastructure and reported to people.
Sep 16 2019
Self-approval, removing a stale file that I've gradually migrated to another location.
Sep 13 2019
Sep 11 2019
Hm, doesn't fail for me, but I guess the feature detection might be platform-dependent to some extent, so I'm fine with replacing the number of the features with a regex. Do you want to upload a change, or should I?
Address review comments
Sep 10 2019
Sep 9 2019
Made the regexp more explicit. TBRing to fix the broken buildbot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/23356/steps/check-sanitizer%20in%20gcc%20build/logs/stdio
Added a test
Thanks everyone! Good point regarding the test, added!
Removed @kcc as a "blocking" reviewer, since we've discussed this offline last week. I'll check with @vitalybuka regarding potential breakages and also ping @samsonov. Other than that, should be good to go.
Sep 6 2019
Sep 4 2019
Sep 3 2019
Implement another solution brainstromed with kcc@
Aug 29 2019
Pardon my ignorance, but what does rdar://54843625 mean? I guess it's not http://openradar.appspot.com/54843625 ? Is it something I can access? :)
Aug 16 2019
Aug 14 2019
Guys, thanks a lot for the feedback! Some answers below, I'll get back to the code soon.
Aug 13 2019
Friendly ping :) Feedback on the description would be the most important at this point, as I feel like I can improve the code a bit more. But if you could check out the code, that would be also great. Note there are at least two TODOs that I'll address before merging. It's still a draft, even though it works.
Aug 12 2019
Update the test a bit more
Actually updated the test to prove everyone (including myself) that this works.
fix a typo
Aug 9 2019
Use LOADED instead of INITED, plus fix alignment of keywords in the log
Aug 8 2019
FTR, changed the extension back to .h in r368331.
@morehouse the CL got a little messy because of the renaming, but I'd appreciate if you could take a look at the new version of ConsumeFloatingPointInRange, it's ~20 lines. Thanks!
Re-written ConsumeFloatingPointInRange in another fashion. Will describe the new logic in the description.
Re-write ConsumeFloatingPointInRange, change extension back to .h
Aug 7 2019
@morehouse Ready for review, PTAL once you get a chance :)
Add parens to the condition for better readability
Aug 6 2019
Objection: .hpp is not idiomatic in LLVM.
Self-approval for a minor change.
Aug 5 2019
Rebase + re-run the tests locally
Aug 2 2019
Keep the header at the old location as well for smooth migration.