Page MenuHomePhabricator

Dor1s (Max Moroz)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2017, 7:36 AM (193 w, 3 d)

Recent Activity

Fri, Oct 23

Dor1s committed rGdc62d5ec9726: [libFuzzer] Added -print_full_coverage flag. (authored by Dor1s).
[libFuzzer] Added -print_full_coverage flag.
Fri, Oct 23, 4:09 PM
Dor1s closed D85928: [libFuzzer] Added -print_full_coverage flag..
Fri, Oct 23, 4:09 PM · Restricted Project, Restricted Project
Dor1s added inline comments to D85928: [libFuzzer] Added -print_full_coverage flag..
Fri, Oct 23, 4:04 PM · Restricted Project, Restricted Project
Dor1s added a comment to D85928: [libFuzzer] Added -print_full_coverage flag..

Not that I like to merge CLs on Friday afternoon, but I'm OOO next week, so taking a shot now while I'm still online.

Fri, Oct 23, 4:04 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D85928: [libFuzzer] Added -print_full_coverage flag..

print "U" and "C" unconditionally

Fri, Oct 23, 4:03 PM · Restricted Project, Restricted Project
Dor1s added inline comments to D85928: [libFuzzer] Added -print_full_coverage flag..
Fri, Oct 23, 3:04 PM · Restricted Project, Restricted Project
Dor1s added a comment to D85928: [libFuzzer] Added -print_full_coverage flag..

Matt, I'm trying to finish this on behalf of Ryan. Marty has been enabling the use of that feature on ClusterFuzz already, so it makes sense to move forward with this. Please take another look when you can :)

Fri, Oct 23, 12:41 PM · Restricted Project, Restricted Project
Dor1s updated the summary of D85928: [libFuzzer] Added -print_full_coverage flag..
Fri, Oct 23, 12:40 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D85928: [libFuzzer] Added -print_full_coverage flag..

addressing review feedback from Matt

Fri, Oct 23, 12:39 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D85928: [libFuzzer] Added -print_full_coverage flag..

Rebase

Fri, Oct 23, 11:33 AM · Restricted Project, Restricted Project

Sep 11 2020

Dor1s accepted D87476: [libFuzzer] Enable entropic by default..

LGTM

Sep 11 2020, 9:59 AM · Restricted Project

Sep 10 2020

Dor1s added inline comments to D87476: [libFuzzer] Enable entropic by default..
Sep 10 2020, 12:12 PM · Restricted Project
Dor1s added inline comments to D87476: [libFuzzer] Enable entropic by default..
Sep 10 2020, 11:57 AM · Restricted Project

Sep 9 2020

Dor1s added a comment to D87067: [llvm-symbolizer] Add back --use-symbol-table=true.

LGTM, thanks for adding this back!

Sep 9 2020, 1:21 PM · Restricted Project
Dor1s added a comment to D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable.

To be more constructive, do you have a use case where this option or its inverse is needed?

Sep 9 2020, 12:55 PM · Restricted Project

Sep 2 2020

Dor1s added inline comments to D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable.
Sep 2 2020, 5:28 PM · Restricted Project
Dor1s added a comment to D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable.

Fangrui, what made you think it's fine to remove documented options and break compatibility for the users of the tool?

Sep 2 2020, 5:26 PM · Restricted Project

Sep 1 2020

Dor1s added a comment to D85928: [libFuzzer] Added -print_full_coverage flag..

@morehouse could you please take a look as well, when you get a chance?

Sep 1 2020, 5:09 PM · Restricted Project, Restricted Project

Aug 13 2020

Dor1s added a comment to D85928: [libFuzzer] Added -print_full_coverage flag..

Good job on uploading this for review, Ryan!

Aug 13 2020, 5:26 PM · Restricted Project, Restricted Project
Dor1s retitled D85928: [libFuzzer] Added -print_full_coverage flag. from Added -print-raw-coverage flag. to [libFuzzer] Added -print-raw-coverage flag..
Aug 13 2020, 5:25 PM · Restricted Project, Restricted Project

Jul 10 2020

Dor1s abandoned D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

Alright, we've ended up disabling that behavior in honggfuzz build, so I'll just close this CL for now.

Jul 10 2020, 3:31 PM · Restricted Project

Jul 6 2020

Dor1s added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Jul 6 2020, 11:26 AM · Restricted Project
Dor1s added a comment to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
In D82685#2133565, @kcc wrote:

My preference would be to reject weird file names instead of adding this extra complexity.

Jul 6 2020, 11:24 AM · Restricted Project

Jul 1 2020

Dor1s added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Jul 1 2020, 5:18 PM · Restricted Project
Dor1s updated the diff for D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

Updated the version of ExecuteCommand with piped output.

Jul 1 2020, 5:18 PM · Restricted Project
Dor1s added a comment to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

Should be better now, ready for review again :)

Jul 1 2020, 4:13 PM · Restricted Project
Dor1s added a comment to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

Ready for review, PTAL.

Jul 1 2020, 3:40 PM · Restricted Project
Dor1s retitled D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system(). from [libFuzzer] Add Command::addPathArgument method to wrap bad paths with quotes. to [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Jul 1 2020, 2:04 PM · Restricted Project
Dor1s added a comment to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

Ready for review, PTAL.

Jul 1 2020, 2:04 PM · Restricted Project
Dor1s updated the diff for D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

Re-write to use fork-exec instead of system() on Linux.

Jul 1 2020, 2:04 PM · Restricted Project
Dor1s added a comment to D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).

If we still decide to proceed with this, would it make sense to expand it to sanitizer_coverage based on any sancov instrumentation being enabled? As you mentioned in the description, there might be users who manually enable certain sancov flags. I think it's good to be able to support those usecases too (e.g. other fuzzing engines).

Jul 1 2020, 10:48 AM · Restricted Project
Dor1s added a comment to D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).

What usecase(s) do you have for this in mind?

Jul 1 2020, 9:42 AM · Restricted Project

Jun 30 2020

Dor1s added a comment to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

I've split the implementation into platform specific files, but I still don't like it. Plus, as Jonathan mentioned, it still has edge cases e.g. if a filename has a single quote. I'll give a shot at refactoring ExecuteCommand into fork-exec. It looks like I need to re-write only Posix implementation, as Fuchsia is already doing good and Windows is less prone to such issues due to its more restrictive file naming.

Jun 30 2020, 5:23 PM · Restricted Project
Dor1s updated the diff for D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..

split the implementation into platform specific files

Jun 30 2020, 5:23 PM · Restricted Project

Jun 29 2020

Dor1s added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Jun 29 2020, 4:07 PM · Restricted Project

Jun 26 2020

Dor1s added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Jun 26 2020, 2:08 PM · Restricted Project
Dor1s created D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Jun 26 2020, 2:08 PM · Restricted Project

Mar 25 2020

Dor1s committed rG6d0488f75bb2: [compiler-rt] Mark FDP non-template methods inline to avoid ODR violations. (authored by Dor1s).
[compiler-rt] Mark FDP non-template methods inline to avoid ODR violations.
Mar 25 2020, 2:06 PM
Dor1s added a comment to D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..

@leonardchan I've committed https://github.com/llvm/llvm-project/commit/6d0488f75bb2f37bcfe93fc8f59f6e78c9a0c939, that should help, I'll monitor the buildbot.

Mar 25 2020, 2:05 PM · Restricted Project
Dor1s added a comment to D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..

Hi. I think this patch might be leading to the linker error we're seeing:

>>> defined at FuzzedDataProvider.h:283 (/b/s/w/ir/k/recipe_cleanup/clangKqmrKj/lib/clang/11.0.0/include/fuzzer/FuzzedDataProvider.h:283)
>>>            obj/zircon/system/ulib/fs/journal/test/journal-replay-fuzzer_test.replay_fuzztest.cc.o:(FuzzedDataProvider::ConsumeBool())
>>> defined at FuzzedDataProvider.h:283 (/b/s/w/ir/k/recipe_cleanup/clangKqmrKj/lib/clang/11.0.0/include/fuzzer/FuzzedDataProvider.h:283)
>>>            obj/zircon/system/ulib/fs/journal/test/fuzz-utils.fuzzer_utils.cc.o:(.text+0x3F0)

ld.lld: error: duplicate symbol: FuzzedDataProvider::ConsumeData(void*, unsigned long)
>>> defined at FuzzedDataProvider.h:318 (/b/s/w/ir/k/recipe_cleanup/clangKqmrKj/lib/clang/11.0.0/include/fuzzer/FuzzedDataProvider.h:318)
>>>            obj/zircon/system/ulib/fs/journal/test/journal-replay-fuzzer_test.replay_fuzztest.cc.o:(FuzzedDataProvider::ConsumeData(void*, unsigned long))
>>> defined at FuzzedDataProvider.h:318 (/b/s/w/ir/k/recipe_cleanup/clangKqmrKj/lib/clang/11.0.0/include/fuzzer/FuzzedDataProvider.h:318)
>>>            obj/zircon/system/ulib/fs/journal/test/fuzz-utils.fuzzer_utils.cc.o:(.text+0x420)

... a bunch more

Would you mind taking a look? Thanks.

Builder: https://ci.chromium.org/p/fuchsia/builders/ci/clang_toolchain.fuchsia-x64-debug-subbuild/b8884854137402901888

Mar 25 2020, 1:33 PM · Restricted Project
Dor1s committed rG1e65209e0455: [compiler-rt] FuzzedDataProvider: make linter happy. (authored by Dor1s).
[compiler-rt] FuzzedDataProvider: make linter happy.
Mar 25 2020, 1:03 AM
Dor1s committed rG1262db1b6a99: [compiler-rt] Refactor FuzzedDataProvider for better readability. (authored by Dor1s).
[compiler-rt] Refactor FuzzedDataProvider for better readability.
Mar 25 2020, 12:30 AM
Dor1s closed D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..
Mar 25 2020, 12:30 AM · Restricted Project
Dor1s updated the diff for D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..

rebase + add a comment for ConsumeProbability

Mar 25 2020, 12:30 AM · Restricted Project
Dor1s added a comment to D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..

thanks, Mitch!

Mar 25 2020, 12:30 AM · Restricted Project

Mar 23 2020

Dor1s added inline comments to D73776: Entropic: Boosting LibFuzzer Performance.
Mar 23 2020, 11:57 PM · Restricted Project, Restricted Project
Dor1s added a comment to D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..

The failure seems to be clang-tidy again -- I'm not going to change names of the methods. PTAL at lines 37-78, if you find time. The rest is existing code moved out of the class definition block. If no one takes a look, I'll land it in a couple days anyways, no worries.

Mar 23 2020, 10:17 PM · Restricted Project
Dor1s committed rG2136d17d8dec: [compiler-rt] Add ConsumeRandomLengthString() version without arguments. (authored by Dor1s).
[compiler-rt] Add ConsumeRandomLengthString() version without arguments.
Mar 23 2020, 4:54 PM
Dor1s closed D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..
Mar 23 2020, 4:54 PM · Restricted Project
Dor1s updated the diff for D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..

updated CL description

Mar 23 2020, 4:54 PM · Restricted Project
Dor1s created D76651: [compiler-rt] Refactor FuzzedDataProvider for better readability..
Mar 23 2020, 4:54 PM · Restricted Project
Dor1s updated the diff for D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..

rebase

Mar 23 2020, 4:54 PM · Restricted Project

Mar 19 2020

Dor1s added inline comments to D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..
Mar 19 2020, 3:22 PM · Restricted Project
Dor1s updated the diff for D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..

make the linter happy #2

Mar 19 2020, 3:22 PM · Restricted Project
Dor1s updated the diff for D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..

fix tidy error

Mar 19 2020, 2:15 PM · Restricted Project
Dor1s added inline comments to D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..
Mar 19 2020, 2:14 PM · Restricted Project
Dor1s retitled D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments. from [compiler-rt] Add ConsumeRandomLengthString() version without arguments. to [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..
Mar 19 2020, 1:09 PM · Restricted Project
Dor1s added a comment to D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..

PTAL, this is a small change requested/suggested by Mitch. I have another one ready (which is a large refactoring) that would come after.

Mar 19 2020, 1:09 PM · Restricted Project
Dor1s created D76448: [compiler-rt] FDP: add ConsumeRandomLengthString() version without arguments..
Mar 19 2020, 1:09 PM · Restricted Project

Mar 18 2020

Dor1s added inline comments to D73776: Entropic: Boosting LibFuzzer Performance.
Mar 18 2020, 10:15 PM · Restricted Project, Restricted Project

Feb 25 2020

Dor1s committed rG5517d3b80b13: [compiler-rt] Fix a typo in a comment in FuzzedDataProvider.h. (authored by Dor1s).
[compiler-rt] Fix a typo in a comment in FuzzedDataProvider.h.
Feb 25 2020, 5:12 PM

Feb 19 2020

Dor1s committed rG076475713c23: [libFuzzer] Fix denominator in the "inputs have DFT" log line. (authored by Dor1s).
[libFuzzer] Fix denominator in the "inputs have DFT" log line.
Feb 19 2020, 11:09 AM
Dor1s closed D74779: [libFuzzer] Fix denominator in the "inputs have DFT" log line..
Feb 19 2020, 11:09 AM · Restricted Project, Restricted Project
Dor1s accepted D74779: [libFuzzer] Fix denominator in the "inputs have DFT" log line..

TBR

Feb 19 2020, 10:58 AM · Restricted Project, Restricted Project

Feb 18 2020

Dor1s created D74779: [libFuzzer] Fix denominator in the "inputs have DFT" log line..
Feb 18 2020, 10:07 AM · Restricted Project, Restricted Project
Dor1s added a comment to D74779: [libFuzzer] Fix denominator in the "inputs have DFT" log line..

Small change. PTAL, or I'll land it myself it a day or so :)

Feb 18 2020, 10:07 AM · Restricted Project, Restricted Project

Feb 11 2020

Dor1s added inline comments to D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..
Feb 11 2020, 1:55 PM · Restricted Project, Restricted Project
Dor1s committed rG20a604d3f5bc: [compiler-rt] FuzzedDataProvider: add ConsumeData and method. (authored by Dor1s).
[compiler-rt] FuzzedDataProvider: add ConsumeData and method.
Feb 11 2020, 1:55 PM
Dor1s closed D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..
Feb 11 2020, 1:55 PM · Restricted Project, Restricted Project
Dor1s retitled D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method. from [compiler-rt] FuzzedDataProvider: add ConsumeMemory and hash methods. to [compiler-rt] FuzzedDataProvider: add ConsumeData method..
Feb 11 2020, 1:46 PM · Restricted Project, Restricted Project
Dor1s added a comment to D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..

I'm gonna rebase and commit, since there isn't much to review compared to the PS#1 (just a test).

Feb 11 2020, 1:46 PM · Restricted Project, Restricted Project
Dor1s added a comment to D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..

Thanks for the review. I can't think of a good application for the hash. Anything I come up with is better to be done either without hashing or even without FDP.

  • Removed the hash
  • Added test
  • Renamed ConsumeMemory to ConsumeData, as the former sounds a bit ambiguous (like memory consumption is more about memory being allocated, while here it's just values being copied, i.e. data)
Feb 11 2020, 1:46 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..

remove hash method, rename ConsumeMemory to ConsumeData, add test

Feb 11 2020, 1:46 PM · Restricted Project, Restricted Project

Feb 10 2020

Dor1s added a comment to D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..

Jonathan @metzman please take a look when you get a chance. I'll add the tests later. Two comments:

Feb 10 2020, 2:33 PM · Restricted Project, Restricted Project
Dor1s created D74359: [compiler-rt] FuzzedDataProvider: add ConsumeData method..
Feb 10 2020, 2:25 PM · Restricted Project, Restricted Project
Dor1s committed rG405093045feb: [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm. (authored by Dor1s).
[compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.
Feb 10 2020, 10:29 AM
Dor1s closed D74343: [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137..
Feb 10 2020, 10:29 AM · Restricted Project, Restricted Project
Dor1s accepted D74343: [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137..

Self-approval for a quick fix (reverting two lines in https://reviews.llvm.org/D74137).

Feb 10 2020, 10:23 AM · Restricted Project, Restricted Project
Dor1s created D74343: [compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137..
Feb 10 2020, 10:23 AM · Restricted Project, Restricted Project
Dor1s added a comment to D74137: [compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp..

Looks like there is potentially relevant failure in: http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/29265

Feb 10 2020, 9:23 AM · Restricted Project, Restricted Project
Dor1s committed rG5ad62d3b7f7e: [compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp. (authored by Dor1s).
[compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp.
Feb 10 2020, 7:07 AM
Dor1s closed D74137: [compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp..
Feb 10 2020, 7:07 AM · Restricted Project, Restricted Project

Feb 6 2020

Dor1s created D74137: [compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp..
Feb 6 2020, 8:50 AM · Restricted Project, Restricted Project

Feb 3 2020

Dor1s added a comment to D73776: Entropic: Boosting LibFuzzer Performance.

I'm happy to take a review pass too. Just ping me when / if this is needed.

Feb 3 2020, 3:14 PM · Restricted Project, Restricted Project
Dor1s updated subscribers of rG2ddff6fab024: [libFuzzer] Minor documentation fixes..

@kcc FYI

Feb 3 2020, 2:53 PM
Dor1s committed rG2ddff6fab024: [libFuzzer] Minor documentation fixes. (authored by Dor1s).
[libFuzzer] Minor documentation fixes.
Feb 3 2020, 2:44 PM
Dor1s added a comment to D73813: [libFuzzer] Make dataflow and focus functions more user friendly..

The next build succeeded. Must be a flake. And I'm seeing some other unrelated failures locally, but not this one. False alarm

Feb 3 2020, 2:19 PM · Restricted Project, Restricted Project
Dor1s added a comment to D73813: [libFuzzer] Make dataflow and focus functions more user friendly..

Hm, there is a failure in http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25533, but I don't understand how it can be related... Looking more.

Feb 3 2020, 1:33 PM · Restricted Project, Restricted Project
Dor1s added a comment to D73813: [libFuzzer] Make dataflow and focus functions more user friendly..

Hm, there is a failure in http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25533, but I don't understand how it can be related... Looking more.

Feb 3 2020, 1:24 PM · Restricted Project, Restricted Project
Dor1s committed rGad7b908b4ef9: [libFuzzer] Make dataflow and focus functions more user friendly. (authored by Dor1s).
[libFuzzer] Make dataflow and focus functions more user friendly.
Feb 3 2020, 8:49 AM
Dor1s closed D73813: [libFuzzer] Make dataflow and focus functions more user friendly..
Feb 3 2020, 8:48 AM · Restricted Project, Restricted Project

Jan 31 2020

Dor1s created D73813: [libFuzzer] Make dataflow and focus functions more user friendly..
Jan 31 2020, 3:03 PM · Restricted Project, Restricted Project

Jan 22 2020

Dor1s committed rG15f1d5d14425: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found. (authored by Dor1s).
[libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found.
Jan 22 2020, 1:01 PM
Dor1s closed D73136: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found..
Jan 22 2020, 1:00 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D73136: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found..

one rebase is never enough

Jan 22 2020, 1:00 PM · Restricted Project, Restricted Project
Dor1s updated the diff for D73136: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found..

rebase

Jan 22 2020, 1:00 PM · Restricted Project, Restricted Project
Dor1s added a comment to D73136: [libFuzzer] Add INFO output when LLVMFuzzerCustomMutator is found..

Given that this is a simple change and Kostya is a busy man I'm going to go ahead and land this. We can always revert if there is any concern.

Jan 22 2020, 1:00 PM · Restricted Project, Restricted Project
Dor1s committed rG8ded83ff7e04: [llvm-cov] Add support for -skip-functions to lcov (authored by keith).
[llvm-cov] Add support for -skip-functions to lcov
Jan 22 2020, 12:51 PM
Dor1s closed D73160: [llvm-cov] Add support for -skip-functions to lcov.
Jan 22 2020, 12:51 PM · Restricted Project
Dor1s updated the diff for D73160: [llvm-cov] Add support for -skip-functions to lcov.

rebase + getting ready to commit

Jan 22 2020, 12:51 PM · Restricted Project