- User Since
- Feb 14 2017, 7:36 AM (113 w, 3 d)
Fri, Apr 12
fix a typo
Add the test, remove debug logging, fix python3 division.
Btw, I did some testing locally, with a 5 bytes input. I was tracing it 3 times:
- 0 3 bytes
- 3 5 bytes
Please see this draft proposal / explanation for the issue. The bisection in python is fine! :)
This patch fixes the issue with the long inputs by not creating DFSan labels
for the bytes which we do not trace, and by offseting the resulting labels to
make the dumps easily mergeable.
Hey @kcc, I've figured out what's the problem here. Will update the description and the CL shortly.
Thu, Apr 11
With this change my target is finally running! :)
Wed, Apr 10
Update the test to reflect the change and make sure it passes.
Thu, Apr 4
Kostya / Matt, this is fairly minor change, PTAL.
Mar 14 2019
Verified that the tests are passing, getting ready to commit.
Mar 13 2019
Thanks for the patch, @sajjadm ! I left some comments. You would also need to update the documentation page and add a test for the new behavior you're introducing.
Feb 26 2019
Btw, if there is a way to automatically detect those unnecessary semicolons, isn't there a way to automatically remove them?
Not sure if it's worth spending time on, but the change LGTM
Feb 11 2019
Removed my comment here and posted it on the review: https://reviews.llvm.org/D57597
You may need to use double backticks to put something into monospaced font, see https://reviews.llvm.org/rL352890. Maybe that's why the docs are still not updated.
Feb 1 2019
Clarify that only linkers other than LLD are affected.
Jan 30 2019
I'm not sure if I wrote down the information correctly, PTAL :)
Jan 15 2019
Thanks a ton, Jonathan!
Dec 11 2018
Dec 4 2018
Thanks @eugenis for explaining the issue to me over chat. I've updated the CL and the description. I can abandon it though, if you find it useless.
Restore the message with a couple clarifying words.
Dec 3 2018
Nov 30 2018
PTAL, it's a single line change, I just need someone to confirm that I'm not mistaken :)
Nov 29 2018
Nov 21 2018
Roman, I can land this CL for you next week, unless other reviewers have any complains :)
Nov 9 2018
Self-approval for this minor fix.
Nov 8 2018
Very nice!! LGTM!
Nov 6 2018
I guess it might be worth adding the binary mode argument to FuzzerMerge.cpp and FuzzerDataFlowTrace.cpp as well, since apparently we may have some unexpected platform-dependent specifics when reading files.
Oct 26 2018
Oct 25 2018
@greened, thanks for the patch. Could you please share which tests were failing for you?
Oct 12 2018
Oct 11 2018
Move GlobalsToAppendToUsed.push_back call into CreateFunctionLocalArrayInSection
Oct 10 2018
The test is added in https://reviews.llvm.org/D53114, similarly to the existing https://github.com/llvm-mirror/compiler-rt/blob/master/test/fuzzer/gc-sections.test