The register index can only really be an SGPR. Lie that a VGPR index
is legal, and then rewrite the instruction in a waterfall loop to
handle the index.
Details
- Reviewers
tstellar scott.linder rampitec qcolombet
Diff Detail
Event Timeline
lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp | ||
---|---|---|
333–336 | Could you indicate the current limitations? I.e. only one, 32-bit operand per machine instruction. | |
385 | Is this because we wouldn't gain anything more in regbankselect/instructionselect? Or because we don't need the type checking in G_PHI when we control the types? Or something else? I'm just curious as I'm not very familiar with GISel. | |
460 | condition |
lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp | ||
---|---|---|
333–336 | There's not much point since I have patches queued up to implement most of the rest of these restrictions | |
385 | We can't really do anything with it, so might as well select it to the final instruction. The same kind of applies to the other phis, so I might revisit those later. |
LGTM then, but like I said I'm not very familiar with GlobalISel so more eyes might be good
Could you indicate the current limitations? I.e. only one, 32-bit operand per machine instruction.