This is an archive of the discontinued LLVM Phabricator instance.

Differential D58423

ELF: Remove field for .gdb_index in InStruct. NFC.
ClosedPublic

Authored by MaskRay on Feb 19 2019, 6:24 PM.

Details

Reviewers
ruiu
pcc
• espindola
grimar
Commits
rLLD354449: ELF: Remove field for .gdb_index in InStruct. NFC.
rGeaa0db021f9b: ELF: Remove field for .gdb_index in InStruct. NFC.
rL354449: ELF: Remove field for .gdb_index in InStruct. NFC.
Summary

This field is unreferenced outside of createSyntheticSections.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Feb 19 2019, 6:24 PM
Herald added a reviewer: • espindola. · View Herald TranscriptFeb 19 2019, 6:24 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, arphaman, arichardson, emaste. · View Herald Transcript
Harbormaster completed remote builds in B28312: Diff 187486.Feb 19 2019, 6:25 PM
grimar accepted this revision.Feb 20 2019, 1:45 AM
grimar added a subscriber: grimar.

LGTM

This revision is now accepted and ready to land.Feb 20 2019, 1:45 AM
MaskRay updated this revision to Diff 187541.Feb 20 2019, 3:32 AM

Rebase

Harbormaster completed remote builds in B28322: Diff 187541.Feb 20 2019, 3:33 AM
Closed by commit rL354449: ELF: Remove field for .gdb_index in InStruct. NFC. (authored by MaskRay). · Explain WhyFeb 20 2019, 3:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
ELF/
1 line
6 lines

Diff 187542

lld/trunk/ELF/SyntheticSections.h

Show First 20 Lines • Show All 1,001 Lines • ▼ Show 20 Linesstruct InStruct {
BuildIdSection *BuildId; BuildIdSection *BuildId;
EhFrameHeader *EhFrameHdr; EhFrameHeader *EhFrameHdr;
EhFrameSection *EhFrame; EhFrameSection *EhFrame;
SyntheticSection *Dynamic; SyntheticSection *Dynamic;
StringTableSection *DynStrTab; StringTableSection *DynStrTab;
SymbolTableBaseSection *DynSymTab; SymbolTableBaseSection *DynSymTab;
GnuHashTableSection *GnuHashTab; GnuHashTableSection *GnuHashTab;
HashTableSection *HashTab; HashTableSection *HashTab;
GdbIndexSection *GdbIndex;
GotSection *Got; GotSection *Got;
GotPltSection *GotPlt; GotPltSection *GotPlt;
IgotPltSection *IgotPlt; IgotPltSection *IgotPlt;
PPC64LongBranchTargetSection *PPC64LongBranchTarget; PPC64LongBranchTargetSection *PPC64LongBranchTarget;
MipsGotSection *MipsGot; MipsGotSection *MipsGot;
MipsRldMapSection *MipsRldMap; MipsRldMapSection *MipsRldMap;
PltSection *Plt; PltSection *Plt;
PltSection *Iplt; PltSection *Iplt;
Show All 24 Lines

lld/trunk/ELF/Writer.cpp

Show First 20 Lines • Show All 376 Lines • ▼ Show 20 Lines if (Config->EMachine == EM_PPC64) {
Add(In.PPC64LongBranchTarget); Add(In.PPC64LongBranchTarget);
} }
In.GotPlt = make<GotPltSection>(); In.GotPlt = make<GotPltSection>();
Add(In.GotPlt); Add(In.GotPlt);
In.IgotPlt = make<IgotPltSection>(); In.IgotPlt = make<IgotPltSection>();
Add(In.IgotPlt); Add(In.IgotPlt);
if (Config->GdbIndex) { if (Config->GdbIndex)
In.GdbIndex = GdbIndexSection::create<ELFT>(); Add(GdbIndexSection::create<ELFT>());
Add(In.GdbIndex);
}
// We always need to add rel[a].plt to output if it has entries. // We always need to add rel[a].plt to output if it has entries.
// Even for static linking it can contain R_[*]_IRELATIVE relocations. // Even for static linking it can contain R_[*]_IRELATIVE relocations.
In.RelaPlt = make<RelocationSection<ELFT>>( In.RelaPlt = make<RelocationSection<ELFT>>(
Config->IsRela ? ".rela.plt" : ".rel.plt", false /*Sort*/); Config->IsRela ? ".rela.plt" : ".rel.plt", false /*Sort*/);
Add(In.RelaPlt); Add(In.RelaPlt);
// The RelaIplt immediately follows .rel.plt (.rel.dyn for ARM) to ensure // The RelaIplt immediately follows .rel.plt (.rel.dyn for ARM) to ensure
▲ Show 20 Lines • Show All 2,181 Lines • Show Last 20 Lines