This is an archive of the discontinued LLVM Phabricator instance.

[msan] Remove cxa_atexit_race.cc
ClosedPublic

Authored by vitalybuka on Feb 19 2019, 11:14 AM.

Details

Summary

The goal of the test to check that msan does not crash when code is racy on __cxa_atexit. Original crash was caused by race condition in the glibc. With
the msan patch the msan does not crashes however the race is still there and the test triggers it.

Because the test relies on triggering of undefined behavior results are not
very predictable and it may occasionally crashes or hangs.

I don't see how to reasonably improve the test, so I remove it.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka created this revision.Feb 19 2019, 11:14 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 19 2019, 11:14 AM
Herald added subscribers: llvm-commits, Restricted Project, jdoerfert, jfb. · View Herald Transcript
This revision is now accepted and ready to land.Feb 19 2019, 11:24 AM
This revision was automatically updated to reflect the committed changes.