This is an archive of the discontinued LLVM Phabricator instance.

[lit] Remove LitTestCase
ClosedPublic

Authored by yln on Feb 14 2019, 4:54 PM.

Details

Summary

From the docs: class LitTestCase(unittest.TestCase)
LitTestCase is an adaptor for providing a 'unittest' compatible
interface to 'lit' tests so that we can run lit tests with standard
python test runners.

It does not seem to be used anywhere. Can we remove it?

Event Timeline

yln created this revision.Feb 14 2019, 4:54 PM
yln added a reviewer: rnk.Feb 14 2019, 4:55 PM
yln updated this revision to Diff 186949.Feb 14 2019, 5:01 PM

Delete test input folder.

rnk accepted this revision.Feb 15 2019, 1:07 PM

lgtm

I think there may have been some idea in the past that we might use this to integrate into LLDB dotest, but they don't use Python unittest at the top level, so I don't think this is useful anymore.

This revision is now accepted and ready to land.Feb 15 2019, 1:07 PM
This revision was automatically updated to reflect the committed changes.
llvm/utils/lit/lit/run.py