Page MenuHomePhabricator

[Darwin][NFC] Refactor throttling of 64bit sanitizer tests on Darwin
ClosedPublic

Authored by yln on Feb 15 2019, 3:09 PM.

Details

Summary

Underlying condition for throttling is "has large mmap'd regions" (i.e.,
shadow memory) and not sanitizers in general (e.g., UBSan does not need
to be throttled).

Rename parallelism group darwin-64bit-sanitizer to shadow-memory and
apply it unconditionally to all tests which require it. We can then have
all the Darwin throttling logic in one place in the commen lit config.

Throttle sanitizer_common unit tests. Configuration was previously
missing from sanitizer_common/Unit/lit.site.cfg.

Event Timeline

yln created this revision.Feb 15 2019, 3:09 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project, jdoerfert, kubamracek. · View Herald Transcript
kubamracek accepted this revision.Feb 27 2019, 10:15 AM
This revision is now accepted and ready to land.Feb 27 2019, 10:15 AM
yln closed this revision.Feb 27 2019, 11:51 AM

Close manually (accidentally used wrong revision ID in commit message).
https://github.com/llvm/llvm-project/commit/6eef7d05249fb88bf5b31289f4c27d75f50c1ae4