Remove no-op code.

[ruiu]

Summary

I believe relocations are sorted by offset, so this code is redundant.
We have the same assumption for other targets.

[PkmX]

GNU as for RISC-V does actually produce out-of-order relocations so lld cannot assume they are always sorted by offset. This was previously discussed at:

https://github.com/riscv/riscv-binutils-gdb/issues/107

Some parts of the code in lld like OffsetGetter::get() for merging .eh_frame also depends on the relocations being sorted by offset, so sorting here isn't simply a performance optimization to do binary search.

[lenary]

Given this code is not redundant, please can you mark this patch as abandoned?

lld/ELF/Relocations.cpp

 static void scanRelocs(InputSectionBase &Sec, ArrayRef<RelTy> Rels) {
   OffsetGetter GetOffset(Sec);
 
   // Not all relocations end up in Sec.Relocations, but a lot do.
   Sec.Relocations.reserve(Rels.size());
 
   for (auto I = Rels.begin(), End = Rels.end(); I != End;)
     scanReloc<ELFT>(Sec, GetOffset, I, End);
-
-  // Sort relocations by offset to binary search for R_RISCV_PCREL_HI20
-  if (Config->EMachine == EM_RISCV)
-    std::stable_sort(Sec.Relocations.begin(), Sec.Relocations.end(),
-                     [](const Relocation &LHS, const Relocation &RHS) {
-                       return LHS.Offset < RHS.Offset;
-                     });
 }
 
 template <class ELFT> void elf::scanRelocations(InputSectionBase &S) {
   if (S.AreRelocsRela)
     scanRelocs<ELFT>(S, S.relas<ELFT>());
   else
     scanRelocs<ELFT>(S, S.rels<ELFT>());
 }