Page MenuHomePhabricator

[Driver] Default all Android ARM targets to NEON.
ClosedPublic

Authored by danalbert on Feb 12 2019, 3:25 PM.

Details

Summary

There are an insignificant number of ARM Android devices that don't
support NEON. Default to using NEON since that will improve
performance on the majority of devices. Users that need to target
non-NEON devices can still explicitly disable NEON.

Diff Detail

Repository
rL LLVM

Event Timeline

danalbert created this revision.Feb 12 2019, 3:25 PM
pirama accepted this revision.Feb 12 2019, 3:29 PM
This revision is now accepted and ready to land.Feb 12 2019, 3:29 PM

The official documentation still says "Your app must perform runtime detection to confirm that NEON-capable machine code can be run on the target device" (https://developer.android.com/ndk/guides/cpu-arm-neon#runtime_detection). Is that wrong?

The official documentation still says "Your app must perform runtime detection to confirm that NEON-capable machine code can be run on the target device" (https://developer.android.com/ndk/guides/cpu-arm-neon#runtime_detection). Is that wrong?

I'll update those docs when this change lands in the NDK (thanks for spotting that). Since there are so few devices affected by this we're instead advising developers to blacklist these CPUs or explicitly set their -mfpu to vfp3-d16 if they want to continue supporting those devices.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 12:31 PM