This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Enable deprecation warnings by default
ClosedPublic

Authored by ldionne on Feb 12 2019, 11:25 AM.

Details

Summary

In r342843, I added deprecation warnings to some facilities that were
deprectated in C++14 and C++17. However, those deprecation warnings
were not enabled by default.

After discussing this on IRC, we had finally gotten consensus to enable
those warnings by default, and I'm getting around to doing that only
now.

Event Timeline

ldionne created this revision.Feb 12 2019, 11:25 AM

I'd like to enable this early in the LLVM 9 cycle.

ldionne updated this revision to Diff 186531.Feb 12 2019, 12:24 PM

Added missing #defines in tests

This seems sensible to me, but I leave it to the libc++ maintainers to sign off on the review. Thank you for working on this!

Last ping. We discussed this on the IRC months ago and other maintainers were fine with it. I'll commit this at the end of the week unless somebody changed their mind.

mclow.lists accepted this revision.Mar 12 2019, 11:11 AM

Go for it. I'm curious to see how it works out :-)

This revision is now accepted and ready to land.Mar 12 2019, 11:11 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 1:09 PM