Page MenuHomePhabricator

docs: Update the ShadowCallStack documentation.
ClosedPublic

Authored by pcc on Feb 11 2019, 11:49 PM.

Details

Summary
  • Remove most of the discussion of the x86_64 implementation; link to an older version of the documentation for details of that implementation.
  • Add description of the compatibility and security issues discovered during the development of the aarch64 implementation for Android.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Feb 11 2019, 11:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 11:49 PM
kristof.beyls added inline comments.Feb 12 2019, 1:20 AM
clang/docs/ShadowCallStack.rst
62–71 ↗(On Diff #186408)

Thanks for the documentation - I thought it was easy to read through and understand.
The only nit pick: would it be worthwhile to also call out here that because of the use of register x18, the ShadowCallStack feature is incompatible with any other feature that may use x18?

vlad.tsyrklevich accepted this revision.Feb 12 2019, 2:11 PM
vlad.tsyrklevich added inline comments.
clang/docs/ShadowCallStack.rst
28 ↗(On Diff #186408)

nit: https

This revision is now accepted and ready to land.Feb 12 2019, 2:11 PM
This revision was automatically updated to reflect the committed changes.
pcc marked 3 inline comments as done.
pcc added inline comments.Feb 12 2019, 2:44 PM
clang/docs/ShadowCallStack.rst
62–71 ↗(On Diff #186408)

Yes, I added a paragraph about that after this one.