Details
Details
Diff Detail
Diff Detail
Event Timeline
test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir | ||
---|---|---|
20 | Thanks, there were a bunch of these I had been copying between tests. I thought I had found all of them already |
Comment Actions
LGTM. Minor comment that's not really concerning - but if you feel like it please fix that as well.
test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir | ||
---|---|---|
62 | It's a bit weird mixing integer truncates with FPExts, but as this is just a test, it probably can't hurt. |
test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir | ||
---|---|---|
62 | This is correct, the ABI is passing half as the low 16 bits of a 32-bit register |
test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir | ||
---|---|---|
62 | That makes sense. Thanks |
IIUC, there needs to be a side effecting user of %1 otherwise it'll be DCEd. Is a
missing here?