This is an archive of the discontinued LLVM Phabricator instance.

[GISel][NFC]: Add missing call to record CSE hits in the CSEMIRBuilder
ClosedPublic

Authored by aditya_nandakumar on Feb 7 2019, 4:55 PM.

Details

Summary

Missing call to record CSE hits. Can be used to figure out what opcodes are CSEd frequently and how many times.
NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2019, 4:55 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added a comment.Feb 7 2019, 8:11 PM

Can this be tested?

Updated to add test case for CSE debug output and standardize the debug printing format inside CSE.

arsenm added inline comments.Feb 8 2019, 11:16 AM
test/CodeGen/AArch64/GlobalISel/legalize-ext-csedebug-output.mir
2 ↗(On Diff #186006)

Needs a REQUIRES: asserts?

Added missing REQUIRES: asserts to the test.

aditya_nandakumar marked an inline comment as done.Feb 8 2019, 11:25 AM
arsenm accepted this revision.Feb 8 2019, 11:26 AM

LGTM

This revision is now accepted and ready to land.Feb 8 2019, 11:26 AM

Thanks. r353553