kristina jhenderson grimar jakehehrlich rupprecht rafauler
- rG0f4367714be7: Revert "Revert "[llvm-objdump] Allow short options without arguments to be…
rL354375: Revert "Revert "[llvm-objdump] Allow short options without arguments to be…
rG77e1f27476c8: [llvm-objdump] Allow short options without arguments to be grouped
rL353998: [llvm-objdump] Allow short options without arguments to be grouped
This conflicts with -d and -f when grouped args are allowed
I'm very much interested in this being supported (i.e. I've seen objdump -sj.foo as mentioned in the bug), but according to http://llvm.org/docs/CommandLine.html#grouping, grouped args can't take values.
Yep, it should be fine to rename it to "disassemble-functions" or something equally reasonable. You'll have to update test/tools/llvm-objdump/X86/disasm-specific-funcs.test.
I think you can still add tests for the other options, e.g. test/tools/llvm-objdump/X86/macho-disassembly-g-dsym.test tests -d -g, so you could add another run statement to that test with -dg and use cmp to verify it produces the same thing
This should also verify it produces the same output as -a -f -x -z
Just a couple comments, but feel free to commit once those are fixed. Thanks!
|2 ↗||(On Diff #187029)|
These should use cmp to verify the files are identical, instead of just checking they match the same patterns
Instead of tee, the standard way of doing this is to pass the file via FileCheck --input-file, e.g.
Before relanding this @ormris, it's probably worth getting @rafauler to confirm he's okay with the option name change, as he was the original one to add it. I've added him as a reviewer. Personally, I think the justification is good, but if it is going to cause horrendous pain, perhaps we should consider alternatives?