This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Enabled getpw_getgr.cc on iOS
ClosedPublic

Authored by vitalybuka on Feb 5 2019, 1:53 PM.

Event Timeline

vitalybuka created this revision.Feb 5 2019, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 1:53 PM
Herald added subscribers: Restricted Project, kubamracek. · View Herald Transcript
eugenis edited reviewers, added: kubamracek; removed: eugenis.Feb 5 2019, 2:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 11:09 AM
vitalybuka added subscribers: delcypher, yln.

@delcypher, @yln maybe you can check if this works on iOS

@vitalybuka Sorry. I didn't see this before.

Unfortunately the CMake code doesn't generate an iOS testing configuration for the sanitizer_common tests currently. This is something we are thinking about enabling but just haven't had time to do.

However just to see what happened I moved the test into ASan's test directory and ran on an iOS device and in the iOS simulator (12.2 runtime). The test passed so this change LGTM.

delcypher accepted this revision.Jun 24 2019, 4:49 PM
This revision is now accepted and ready to land.Jun 24 2019, 4:49 PM
This revision was automatically updated to reflect the committed changes.