This is an archive of the discontinued LLVM Phabricator instance.

Differential D57785

[sanitizer] Re-enabled getpw_getgr.cc on Android
ClosedPublic

Authored by vitalybuka on Feb 5 2019, 1:52 PM.

Details

Reviewers
eugenis
Commits
rG2b93ef7ef66a: [sanitizer] Re-enabled getpw_getgr.cc on Android
rL353366: [sanitizer] Re-enabled getpw_getgr.cc on Android
rCRT353366: [sanitizer] Re-enabled getpw_getgr.cc on Android

Diff Detail

Event Timeline

vitalybuka created this revision.Feb 5 2019, 1:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 1:53 PM
Herald added subscribers: Restricted Project, kubamracek, srhines. · View Herald Transcript
Harbormaster completed remote builds in B27768: Diff 185397.Feb 5 2019, 1:53 PM
vitalybuka added a parent revision: D57731: [sanitizer] Don't unpoison buffer in getpw/getgr functions.Feb 5 2019, 1:54 PM
eugenis accepted this revision.Feb 5 2019, 2:37 PM

LGTM

This revision is now accepted and ready to land.Feb 5 2019, 2:37 PM
Closed by commit rCRT353366: [sanitizer] Re-enabled getpw_getgr.cc on Android (authored by vitalybuka). · Explain WhyFeb 6 2019, 5:54 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 5:54 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
test/
sanitizer_common/
TestCases/
Posix/
2 lines

Diff 185689

test/sanitizer_common/TestCases/Posix/getpw_getgr.cc

// RUN: %clangxx %s -o %t && %run %t // RUN: %clangxx %s -o %t && %run %t
// UNSUPPORTED: android, ios // UNSUPPORTED: ios
#include <assert.h> #include <assert.h>
#include <grp.h> #include <grp.h>
#include <memory> #include <memory>
#include <pwd.h> #include <pwd.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
▲ Show 20 Lines • Show All 102 Lines • Show Last 20 Lines