A number of of tests were using imm operands, not cimm. Since CSE
relies on the exact ConstantInt* pointer used, and implicit
conversions are generally evil, also enforce the bitsize of the types.
Details
Details
Diff Detail
Diff Detail
Paths
| Differential D57650
GlobalISel: Enforce operand types for constants ClosedPublic Authored by arsenm on Feb 3 2019, 6:32 AM.
Details Summary A number of of tests were using imm operands, not cimm. Since CSE
Diff Detail Event TimelineHerald added subscribers: Petar.Avramovic, javed.absar, kristof.beyls and 4 others. · View Herald TranscriptFeb 3 2019, 6:32 AM This revision is now accepted and ready to land.Feb 4 2019, 7:14 AM
Revision Contents
Diff 184948 lib/CodeGen/MachineVerifier.cpp
test/CodeGen/AArch64/GlobalISel/localizer.mir
test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-extending-loads.mir
test/CodeGen/AArch64/GlobalISel/regbankselect-default.mir
test/CodeGen/AArch64/GlobalISel/select-binop.mir
test/CodeGen/AMDGPU/GlobalISel/inst-select-implicit-def.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-and.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-extract-vector-elt.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-icmp.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-or.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-select.mir
test/CodeGen/AMDGPU/GlobalISel/legalize-xor.mir
test/CodeGen/AMDGPU/GlobalISel/regbankselect-and.mir
test/CodeGen/AMDGPU/GlobalISel/regbankselect-default.mir
test/CodeGen/AMDGPU/GlobalISel/regbankselect-sadde.mir
test/CodeGen/AMDGPU/GlobalISel/regbankselect-ssube.mir
test/CodeGen/AMDGPU/GlobalISel/regbankselect-uadde.mir
test/CodeGen/AMDGPU/GlobalISel/regbankselect-usube.mir
test/CodeGen/ARM/GlobalISel/arm-instruction-select.mir
test/CodeGen/ARM/GlobalISel/arm-legalize-consts.mir
test/CodeGen/ARM/GlobalISel/arm-regbankselect.mir
test/CodeGen/ARM/GlobalISel/select-revsh.mir
test/CodeGen/X86/GlobalISel/select-ashr-scalar.mir
test/CodeGen/X86/GlobalISel/select-lshr-scalar.mir
test/CodeGen/X86/GlobalISel/select-shl-scalar.mir
test/Verifier/test_g_constant.mir
test/Verifier/test_g_fconstant.mir
|