This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Enforce operand types for constants
ClosedPublic

Authored by arsenm on Feb 3 2019, 6:32 AM.

Details

Summary

A number of of tests were using imm operands, not cimm. Since CSE
relies on the exact ConstantInt* pointer used, and implicit
conversions are generally evil, also enforce the bitsize of the types.

Diff Detail

Event Timeline

arsenm created this revision.Feb 3 2019, 6:32 AM
aditya_nandakumar accepted this revision.Feb 4 2019, 7:14 AM

Looks great. Thanks for fixing this..

This revision is now accepted and ready to land.Feb 4 2019, 7:14 AM
arsenm closed this revision.Feb 4 2019, 3:29 PM

r353113