This patch adds the SBReproducer macros needed to capture and reply the corresponding calls.
The patch was generated using the SBRepro tool (D56822).
Paths
| Differential D57475
[Reproducers] Add SBReproducer macros ClosedPublic Authored by JDevlieghere on Jan 30 2019, 2:39 PM.
Details Summary This patch adds the SBReproducer macros needed to capture and reply the corresponding calls. The patch was generated using the SBRepro tool (D56822).
Diff Detail Event TimelineJDevlieghere added a parent revision: D56322: [Reproducers] SBReproducer framework.Jan 30 2019, 2:39 PM Comment Actions BTW, it would be nice to mention somewhere how to use this tool. Do you just run it, or does it needs some special arguments, or something?
JDevlieghere added inline comments.
This revision is now accepted and ready to land.Feb 18 2019, 11:09 PM Closed by commit rLLDB355459: [Reproducers] Add SBReproducer macros (authored by JDevlieghere). · Explain WhyMar 5 2019, 4:07 PM This revision was automatically updated to reflect the committed changes. Comment Actions This is still breaking NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/19339/steps/ninja%20build%20local/logs/stdio FAILED: tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFINED -DLLDB_CONFIGURATION_RELEASE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/lldb/source/API -I/home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/API -Itools/lldb/include -I/home/motus/netbsd8/netbsd8/llvm/tools/lldb/include -Iinclude -I/home/motus/netbsd8/netbsd8/llvm/include -I/usr/pkg/include/python2.7 -I/home/motus/netbsd8/netbsd8/llvm/tools/clang/include -Itools/lldb/../clang/include -I/usr/pkg/include/libxml2 -I/home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/. -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG -fPIC -fno-exceptions -fno-rtti -MD -MT tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o -MF tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o.d -o tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o -c /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/API/SBHostOS.cpp In file included from /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/API/SBReproducerPrivate.h:18:0, from /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/API/SBHostOS.cpp:13: /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Utility/ReproducerInstrumentation.h: In instantiation of 'void lldb_private::repro::Serializer::Serialize(T&) [with T = __pthread_st]': /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Utility/ReproducerInstrumentation.h:518:7: required from 'void lldb_private::repro::Serializer::Serialize(T*) [with T = __pthread_st]' /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Utility/ReproducerInstrumentation.h:506:5: required from 'void lldb_private::repro::Serializer::SerializeAll(const Head&, const Tail& ...) [with Head = __pthread_st*; Tail = {lldb::SBError*}]' /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Utility/ReproducerInstrumentation.h:601:5: required from 'void lldb_private::repro::Recorder::Record(Result (*)(FArgs ...), const RArgs& ...) [with Result = bool; FArgs = {__pthread_st*, lldb::SBError*}; RArgs = {__pthread_st*, lldb::SBError*}]' /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/API/SBHostOS.cpp:135:3: required from here /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Utility/ReproducerInstrumentation.h:530:64: error: invalid application of 'sizeof' to incomplete type '__pthread_st' m_stream.write(reinterpret_cast<const char *>(&t), sizeof(T)); ^ It looks like it's trying to serialize opaque types. Comment Actions Jonas, would it be possible to just not intercept the functions which work with thread IDs and similar stuff (an all OSs)?
Revision Contents
Diff 185432 source/API/SBAddress.cpp
source/API/SBAttachInfo.cpp
source/API/SBBlock.cpp
source/API/SBBreakpoint.cpp
source/API/SBBreakpointLocation.cpp
source/API/SBBreakpointName.cpp
source/API/SBBreakpointOptionCommon.cpp
source/API/SBBroadcaster.cpp
source/API/SBCommandInterpreter.cpp
source/API/SBCommandReturnObject.cpp
source/API/SBCommunication.cpp
source/API/SBCompileUnit.cpp
source/API/SBData.cpp
source/API/SBDebugger.cpp
source/API/SBDeclaration.cpp
source/API/SBError.cpp
source/API/SBEvent.cpp
source/API/SBExecutionContext.cpp
source/API/SBExpressionOptions.cpp
source/API/SBFileSpec.cpp
source/API/SBFileSpecList.cpp
source/API/SBFrame.cpp
source/API/SBFunction.cpp
source/API/SBHostOS.cpp
source/API/SBInitializerOptions.cpp
source/API/SBInstruction.cpp
source/API/SBInstructionList.cpp
source/API/SBLanguageRuntime.cpp
source/API/SBLaunchInfo.cpp
source/API/SBLineEntry.cpp
source/API/SBListener.cpp
source/API/SBMemoryRegionInfo.cpp
source/API/SBMemoryRegionInfoList.cpp
source/API/SBModule.cpp
source/API/SBModuleSpec.cpp
source/API/SBPlatform.cpp
source/API/SBProcess.cpp
source/API/SBProcessInfo.cpp
source/API/SBQueue.cpp
source/API/SBQueueItem.cpp
source/API/SBReproducer.cpp
source/API/SBSection.cpp
source/API/SBSourceManager.cpp
source/API/SBStream.cpp
source/API/SBStringList.cpp
source/API/SBStructuredData.cpp
source/API/SBSymbol.cpp
source/API/SBSymbolContext.cpp
source/API/SBSymbolContextList.cpp
source/API/SBTarget.cpp
source/API/SBThread.cpp
source/API/SBThreadCollection.cpp
source/API/SBThreadPlan.cpp
source/API/SBTrace.cpp
source/API/SBTraceOptions.cpp
source/API/SBType.cpp
source/API/SBTypeCategory.cpp
source/API/SBTypeEnumMember.cpp
source/API/SBTypeFilter.cpp
source/API/SBTypeFormat.cpp
source/API/SBTypeNameSpecifier.cpp
source/API/SBTypeSummary.cpp
source/API/SBTypeSynthetic.cpp
source/API/SBUnixSignals.cpp
source/API/SBValue.cpp
source/API/SBValueList.cpp
source/API/SBVariablesOptions.cpp
source/API/SBWatchpoint.cpp
source/Utility/ReproducerInstrumentation.cpp
|
It looks like some functions have a newline after the macro, and some don't. What's the reason for that?