Page MenuHomePhabricator

tatyana-krasnukha (Tatyana Krasnukha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2017, 8:23 AM (177 w, 5 d)

Recent Activity

Mon, Sep 14

tatyana-krasnukha accepted D86866: Add Option to sphinx-build for custom conf file location.

Looks reasonable to me.

Mon, Sep 14, 3:41 AM · Restricted Project

Aug 5 2020

tatyana-krasnukha added a comment to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

I'm not familiar with the z/OS target, so I cannot check the correctness of the target-specific changes. The overall patch looks good.

Aug 5 2020, 2:40 PM · Restricted Project
tatyana-krasnukha committed rGbc056b3aa713: [lldb] Suppress MSVC warning C4065 (authored by tatyana-krasnukha).
[lldb] Suppress MSVC warning C4065
Aug 5 2020, 2:11 AM
tatyana-krasnukha committed rG75012a80440f: [lldb] Use PyUnicode_GetLength instead of PyUnicode_GetSize (authored by tatyana-krasnukha).
[lldb] Use PyUnicode_GetLength instead of PyUnicode_GetSize
Aug 5 2020, 2:11 AM
tatyana-krasnukha committed rGcc68c122cd00: [lldb/TestingSupport] Manually disable GTEST_HAS_TR1_TUPLE (authored by tatyana-krasnukha).
[lldb/TestingSupport] Manually disable GTEST_HAS_TR1_TUPLE
Aug 5 2020, 2:11 AM

Aug 4 2020

tatyana-krasnukha committed rG4f5ccc72f6a6: Partially revert "[cmake] Make MSVC generate appropriate __cplusplus macro… (authored by tatyana-krasnukha).
Partially revert "[cmake] Make MSVC generate appropriate __cplusplus macro…
Aug 4 2020, 2:22 AM
tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

I see. The option "/Zc:__cplusplus" affects GTEST_LANG_CXX11 but not GTEST_HAS_TR1_TUPLE. I didn't have warnings just because my LLVM fork uses C++17.

Aug 4 2020, 2:00 AM · Restricted Project

Aug 3 2020

tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

The option "/Zc:__cplusplus" solves this problem. With this option passed, Gtest doesn't try using namespace tr1. I don't have such warnings if pass this option.

Aug 3 2020, 2:25 PM · Restricted Project
tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

LLVM documentation says: "You will need Visual Studio 2017 or higher, with the latest Update installed". Does this mean Visual Studio 2017 version 15.9? Because the /Zc:__cplusplus option is available starting in Visual Studio 2017 version 15.7.

Aug 3 2020, 4:40 AM · Restricted Project
tatyana-krasnukha committed rGe97c693bb0ec: [lldb/Process/Windows] Attempting to kill exited/detached process in not an… (authored by tatyana-krasnukha).
[lldb/Process/Windows] Attempting to kill exited/detached process in not an…
Aug 3 2020, 2:53 AM
tatyana-krasnukha committed rGc3339e3e921c: [cmake] Make MSVC generate appropriate __cplusplus macro definition (authored by tatyana-krasnukha).
[cmake] Make MSVC generate appropriate __cplusplus macro definition
Aug 3 2020, 2:53 AM
tatyana-krasnukha closed D84023: Make MSVC generate appropriate __cplusplus macro definition.
Aug 3 2020, 2:53 AM · Restricted Project
tatyana-krasnukha closed D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.
Aug 3 2020, 2:53 AM · Restricted Project
tatyana-krasnukha added a comment to D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.

Thank you! I fixed the commit title and description as you suggested.

Aug 3 2020, 2:53 AM · Restricted Project

Jul 30 2020

tatyana-krasnukha updated the diff for D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints.

TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check.

Jul 30 2020, 1:19 PM · Restricted Project
tatyana-krasnukha retitled D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error from [lldb/Process/Windows] Trying to kill exited/detached process in not error to [lldb/Process/Windows] Attempt to kill exited/detached process in not error.
Jul 30 2020, 11:00 AM · Restricted Project
tatyana-krasnukha added a reviewer for D84023: Make MSVC generate appropriate __cplusplus macro definition: asmith.
Jul 30 2020, 10:57 AM · Restricted Project
tatyana-krasnukha requested review of D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.
Jul 30 2020, 10:56 AM · Restricted Project
tatyana-krasnukha requested review of D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints.
Jul 30 2020, 10:48 AM · Restricted Project

Jul 29 2020

tatyana-krasnukha committed rGda0bba5c9abb: [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its… (authored by tatyana-krasnukha).
[lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its…
Jul 29 2020, 12:08 PM
tatyana-krasnukha closed D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation.
Jul 29 2020, 12:08 PM · Restricted Project
tatyana-krasnukha committed rGd5c1f686e34f: [lldb/BreakpointSite] Handle all ways of control flow (authored by tatyana-krasnukha).
[lldb/BreakpointSite] Handle all ways of control flow
Jul 29 2020, 11:53 AM
tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

Ups... Pushed it occationaly with the other patchs.

Jul 29 2020, 11:32 AM · Restricted Project
tatyana-krasnukha committed rGebaa8b1c6074: [lldb] Don't use hardware index to determine whether a breakpoint site is… (authored by tatyana-krasnukha).
[lldb] Don't use hardware index to determine whether a breakpoint site is…
Jul 29 2020, 11:27 AM
tatyana-krasnukha committed rGb352e62feadd: [lldb] Make process plugins check whether a hardware breakpoint is required (authored by tatyana-krasnukha).
[lldb] Make process plugins check whether a hardware breakpoint is required
Jul 29 2020, 11:27 AM
tatyana-krasnukha committed rGf7ec3e3be70d: [lldb] Skip overlapping hardware and external breakpoints when writing memory (authored by tatyana-krasnukha).
[lldb] Skip overlapping hardware and external breakpoints when writing memory
Jul 29 2020, 11:27 AM
tatyana-krasnukha closed D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.
Jul 29 2020, 11:27 AM · Restricted Project
tatyana-krasnukha closed D84255: [lldb] Make process plugins check whether a hardware breakpoint is required.
Jul 29 2020, 11:27 AM · Restricted Project
tatyana-krasnukha closed D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory.
Jul 29 2020, 11:27 AM · Restricted Project
tatyana-krasnukha committed rGc114352edfe0: [lldb/test] Put hardware breakpoint tests together, NFC (authored by tatyana-krasnukha).
[lldb/test] Put hardware breakpoint tests together, NFC
Jul 29 2020, 11:20 AM
tatyana-krasnukha closed D84311: [lldb/test] Put hardware breakpoint tests together, NFC.
Jul 29 2020, 11:20 AM · Restricted Project
tatyana-krasnukha updated the diff for D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation.

Addressed comments.

Jul 29 2020, 8:22 AM · Restricted Project
tatyana-krasnukha updated the diff for D84255: [lldb] Make process plugins check whether a hardware breakpoint is required.

Un-skip TestRequireHWBreakpoints.py on Windows, now it works as expected.

Jul 29 2020, 8:10 AM · Restricted Project
tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

It also fixes warnings about using deprecated std::tr1, which became errors in VS 2019, produced while compiling lldbUtilityHelpers project (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17887/steps/test/logs/stdio).

Jul 29 2020, 8:07 AM · Restricted Project

Jul 24 2020

tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that.

Jul 24 2020, 6:54 AM · Restricted Project
tatyana-krasnukha updated the diff for D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

@omjavaid, thank you for verifying this!

Jul 24 2020, 6:52 AM · Restricted Project
tatyana-krasnukha updated the summary of D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation.
Jul 24 2020, 6:43 AM · Restricted Project
Herald added a project to D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation: Restricted Project.
Jul 24 2020, 6:43 AM · Restricted Project

Jul 22 2020

tatyana-krasnukha created D84311: [lldb/test] Put hardware breakpoint tests together, NFC.
Jul 22 2020, 5:22 AM · Restricted Project
tatyana-krasnukha updated the diff for D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory.

BreakpointSite::IntersectsRange returns false for hardware breakpoints, that's why the assertion fails.

Jul 22 2020, 5:22 AM · Restricted Project
tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.
Jul 22 2020, 2:58 AM · Restricted Project

Jul 21 2020

tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64.

Jul 21 2020, 12:00 PM · Restricted Project
tatyana-krasnukha created D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.
Jul 21 2020, 11:25 AM · Restricted Project
tatyana-krasnukha created D84255: [lldb] Make process plugins check whether a hardware breakpoint is required.
Jul 21 2020, 11:23 AM · Restricted Project
tatyana-krasnukha created D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory.
Jul 21 2020, 11:21 AM · Restricted Project
tatyana-krasnukha added a reviewer for D84023: Make MSVC generate appropriate __cplusplus macro definition: stella.stamenova.
Jul 21 2020, 6:31 AM · Restricted Project

Jul 20 2020

tatyana-krasnukha updated the diff for D84023: Make MSVC generate appropriate __cplusplus macro definition.

No updates, just to trigger rebasing onto master where tests should be already fixed.

Jul 20 2020, 3:43 AM · Restricted Project

Jul 17 2020

Herald added a project to D84023: Make MSVC generate appropriate __cplusplus macro definition: Restricted Project.
Jul 17 2020, 6:36 AM · Restricted Project

Mar 26 2020

tatyana-krasnukha committed rGa92673fe9a08: [lldb-vscode] Convert launch_info and attach_info to local variables (authored by anton.kolesov).
[lldb-vscode] Convert launch_info and attach_info to local variables
Mar 26 2020, 9:13 AM
tatyana-krasnukha closed D76593: [lldb-vscode] Convert launch_info and attach_info to local variables.
Mar 26 2020, 9:12 AM · Restricted Project
tatyana-krasnukha committed rG2bfe2b878a62: [lldb][testsuite] Check that process is launched successfully in inline tests (authored by tatyana-krasnukha).
[lldb][testsuite] Check that process is launched successfully in inline tests
Mar 26 2020, 5:23 AM
tatyana-krasnukha committed rGccf1c30cde6e: [lldb][testsuite] Add lldb-server category (authored by tatyana-krasnukha).
[lldb][testsuite] Add lldb-server category
Mar 26 2020, 5:23 AM
tatyana-krasnukha abandoned D76309: Add wait timeout to process properties.

Lit option --timeout partly solves the problem, so these changes are unnecessary.

Mar 26 2020, 5:23 AM

Mar 20 2020

tatyana-krasnukha committed rG0b18b568e91a: [lldb-vscode] Don't use SBLaunchInfo in request_attach (authored by anton.kolesov).
[lldb-vscode] Don't use SBLaunchInfo in request_attach
Mar 20 2020, 10:18 AM
tatyana-krasnukha closed D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach.
Mar 20 2020, 10:18 AM · Restricted Project

Mar 17 2020

tatyana-krasnukha created D76309: Add wait timeout to process properties.
Mar 17 2020, 11:49 AM

Mar 16 2020

tatyana-krasnukha committed rG332edcc6bd1d: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame (authored by tatyana-krasnukha).
[lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame
Mar 16 2020, 6:29 AM
tatyana-krasnukha committed rG0a840ef80059: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update (authored by tatyana-krasnukha).
[lldb] Copy m_behaves_like_zeroth_frame on stack frame update
Mar 16 2020, 6:29 AM
tatyana-krasnukha closed D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame.
Mar 16 2020, 6:29 AM · Restricted Project
tatyana-krasnukha closed D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update.
Mar 16 2020, 6:29 AM · Restricted Project

Mar 12 2020

tatyana-krasnukha added a comment to D75537: Clear all settings during a test's setUp.

platform.module-cache-directory should be fixed by rGfe74df01a909.

Mar 12 2020, 1:01 PM · Restricted Project
tatyana-krasnukha committed rGfe74df01a909: [lldb] Specify default value for platform.module-cache-directory (authored by tatyana-krasnukha).
[lldb] Specify default value for platform.module-cache-directory
Mar 12 2020, 12:29 PM
tatyana-krasnukha added a comment to D75537: Clear all settings during a test's setUp.

Thank you for details, I'm looking at these failures, however, I'm not able to debug on the macOS.

Mar 12 2020, 8:08 AM · Restricted Project
tatyana-krasnukha committed rGdf90a15b1ac9: [lldb] Clear all settings during a test's setUp (authored by tatyana-krasnukha).
[lldb] Clear all settings during a test's setUp
Mar 12 2020, 7:03 AM
tatyana-krasnukha closed D75537: Clear all settings during a test's setUp.
Mar 12 2020, 7:03 AM · Restricted Project
tatyana-krasnukha updated the diff for D75537: Clear all settings during a test's setUp.

Addressed comments

Mar 12 2020, 5:13 AM · Restricted Project

Mar 5 2020

tatyana-krasnukha committed rGef38283a0980: [lldb][test] Temporarily X-fail TestPtrRefs.py and TestPtrRefsObjC.py (authored by tatyana-krasnukha).
[lldb][test] Temporarily X-fail TestPtrRefs.py and TestPtrRefsObjC.py
Mar 5 2020, 3:52 AM
tatyana-krasnukha committed rGaafd65ad9ff0: [lldb][test] Replace HandleCommand with runCmd to check that a command succeeded (authored by tatyana-krasnukha).
[lldb][test] Replace HandleCommand with runCmd to check that a command succeeded
Mar 5 2020, 1:41 AM
tatyana-krasnukha committed rGd2e397f15616: [lldb][test] These tests don't fail on Windows anymore (authored by tatyana-krasnukha).
[lldb][test] These tests don't fail on Windows anymore
Mar 5 2020, 1:41 AM
tatyana-krasnukha committed rG7a11cc06a4fd: [lldb][test] TestFileHandle: flush the output after write (authored by tatyana-krasnukha).
[lldb][test] TestFileHandle: flush the output after write
Mar 5 2020, 1:09 AM
tatyana-krasnukha committed rGeecef3af2ca8: [lldb][test] Enable fix-its for the test case that expects them enabled (authored by tatyana-krasnukha).
[lldb][test] Enable fix-its for the test case that expects them enabled
Mar 5 2020, 12:03 AM
tatyana-krasnukha updated the diff for D75537: Clear all settings during a test's setUp.

Removed TestFixIts.py as those changes relate to the parent revision.

Mar 5 2020, 12:03 AM · Restricted Project

Mar 4 2020

tatyana-krasnukha committed rGa31130f6fcf2: [lldb][testsuite] Create a SBDebugger instance for each test (authored by tatyana-krasnukha).
[lldb][testsuite] Create a SBDebugger instance for each test
Mar 4 2020, 11:31 PM
tatyana-krasnukha closed D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Mar 4 2020, 11:31 PM · Restricted Project
tatyana-krasnukha updated the diff for D75537: Clear all settings during a test's setUp.

Added --all property to settings clear + added a test

Mar 4 2020, 9:32 AM · Restricted Project
tatyana-krasnukha committed rG6c17cc531f9f: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to… (authored by tatyana-krasnukha).
[lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to…
Mar 4 2020, 6:12 AM
tatyana-krasnukha committed rGb1324e74da26: [lldb][NFC] Move local variables near to their usage (authored by tatyana-krasnukha).
[lldb][NFC] Move local variables near to their usage
Mar 4 2020, 6:12 AM
tatyana-krasnukha closed D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.
Mar 4 2020, 6:12 AM · Restricted Project

Mar 3 2020

tatyana-krasnukha updated the diff for D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

Moved settings clearing to the separate patch D75537

Mar 3 2020, 9:39 AM · Restricted Project
tatyana-krasnukha created D75537: Clear all settings during a test's setUp.
Mar 3 2020, 9:39 AM · Restricted Project
tatyana-krasnukha updated the diff for D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

Clear all settings during a test's setUp

Mar 3 2020, 8:34 AM · Restricted Project
tatyana-krasnukha planned changes to D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

As Pavel wrote, there are global properties that all debuggers share. That's why this approach doesn't work for me.
I'm going to add settings clear mode without arguments that will revert all the settings to their default values.

Mar 3 2020, 7:46 AM · Restricted Project
tatyana-krasnukha updated the diff for D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Mar 3 2020, 4:11 AM · Restricted Project
tatyana-krasnukha added a comment to D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.

@jingham Is it Ok with you?

Mar 3 2020, 2:40 AM · Restricted Project

Feb 21 2020

tatyana-krasnukha added a comment to D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

I like this idea and ready to implement, but I'm not aware of the reasons why the current implementation was chosen. Suppose that initializing the Debugger for each test will slow down the test-suite significantly.

Feb 21 2020, 12:32 AM · Restricted Project

Feb 20 2020

tatyana-krasnukha retitled D74903: [lldb][testsuite] Create a SBDebugger instance for each test from [lldb][test] Add two wrapper-functions to manage settings in test-suite to [lldb][test] Add two wrapper functions to manage settings in test-suite.
Feb 20 2020, 8:03 AM · Restricted Project
tatyana-krasnukha created D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Feb 20 2020, 7:45 AM · Restricted Project

Feb 18 2020

tatyana-krasnukha committed rGdb23825970b0: [lldb][test] Remove expected failure decorator from test_copy_from_dummy_target… (authored by tatyana-krasnukha).
[lldb][test] Remove expected failure decorator from test_copy_from_dummy_target…
Feb 18 2020, 4:05 AM
tatyana-krasnukha closed D74558: [lldb] Make shared_from_this-related code safer .

Closed by commit b624b7dfd087

Feb 18 2020, 3:26 AM · Restricted Project
tatyana-krasnukha closed D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor.

Closed by commit 185ef697ef5c

Feb 18 2020, 3:26 AM · Restricted Project
tatyana-krasnukha committed rG7fb06796abfd: [lldb][NFC] Remove unused parameter (authored by tatyana-krasnukha).
[lldb][NFC] Remove unused parameter
Feb 18 2020, 2:51 AM
tatyana-krasnukha committed rGb624b7dfd087: [lldb] Make shared_from_this-related code safer (authored by tatyana-krasnukha).
[lldb] Make shared_from_this-related code safer
Feb 18 2020, 2:50 AM
tatyana-krasnukha committed rG185ef697ef5c: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor (authored by tatyana-krasnukha).
[lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor
Feb 18 2020, 2:50 AM

Feb 14 2020

tatyana-krasnukha updated the diff for D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.

Just realized that BreakpointResolverScripted::CreateImplementationIfNeeded should work when m_breakpoint == nullptr.
GetBreakpoint with assertion is not suitable here, so I pass the breakpoint as a parameter.

Feb 14 2020, 11:53 AM · Restricted Project
tatyana-krasnukha updated the diff for D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.

Moved assertion into GetBreakpoint().

Feb 14 2020, 6:51 AM · Restricted Project

Feb 13 2020

tatyana-krasnukha committed rG21d09ccf268d: [lldb-vscode] Ensure that target matches the executable file (authored by tatyana-krasnukha).
[lldb-vscode] Ensure that target matches the executable file
Feb 13 2020, 8:43 AM
tatyana-krasnukha closed D70847: [lldb-vscode] Ensure that target matches the executable file.
Feb 13 2020, 8:42 AM · Restricted Project
tatyana-krasnukha created D74558: [lldb] Make shared_from_this-related code safer .
Feb 13 2020, 7:12 AM · Restricted Project
tatyana-krasnukha created D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.
Feb 13 2020, 7:12 AM · Restricted Project
tatyana-krasnukha created D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor.
Feb 13 2020, 7:12 AM · Restricted Project