tatyana-krasnukha (Tatyana Krasnukha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2017, 8:23 AM (37 w, 4 d)

Recent Activity

Thu, Jan 11

tatyana-krasnukha closed D41584: Check existence of each required component during construction of LLVMCDisassembler..
Thu, Jan 11, 4:07 AM
tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..

Fixed comment spacing. Changed the comment slightly (words “I added this class to…” sound now like I did this, so, replaced it with passive voice).

Thu, Jan 11, 3:46 AM

Wed, Jan 10

tatyana-krasnukha added a comment to D41584: Check existence of each required component during construction of LLVMCDisassembler..

There is the function GetDisasmToUse in InstructionLLVMC class that can return nullptr. But this case is not handled in any usage. I suppose that caller functions cannot be invoked if !DisassemblerLLVMC::IsValid(). But it still looks dangerous for me. May be GetDisasmToUse should assert if neither m_disasm_up nor m_alternate_disasm_up exists? And may return a reference then.

Wed, Jan 10, 6:42 AM
tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..

Added "_up" suffix to each unique_ptr, renamed MCDisasmToolset to MCDisasmInstance.

Wed, Jan 10, 6:16 AM
tatyana-krasnukha added inline comments to D41584: Check existence of each required component during construction of LLVMCDisassembler..
Wed, Jan 10, 4:09 AM

Tue, Jan 9

tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..

Added function Create that creates an instance of LLVMCDisassembler only if pass all constraints.
Moved LLVMCDisassembler declaration to .cpp file, renamed to MCDisasmToolset (is this name ok?).
Added const qualifier to some functions of the class.
I also had the courage to remove ‘_ap’ suffixes from unique pointers.

Tue, Jan 9, 10:56 AM
tatyana-krasnukha added a comment to D41584: Check existence of each required component during construction of LLVMCDisassembler..

Thank you, Pavel.
Would you mind if I move LLVMCDisassembler declaration in .cpp also? It looks like perfect candidate for pimpl.

Tue, Jan 9, 5:33 AM

Tue, Dec 26

tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..
Tue, Dec 26, 9:00 AM
tatyana-krasnukha created D41584: Check existence of each required component during construction of LLVMCDisassembler..
Tue, Dec 26, 8:11 AM

Nov 28 2017

tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete,
Now I have commit after approval access and would land this revision. May I do it now?

Nov 28 2017, 2:37 AM

Nov 22 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

When I added instructions, I didn't care about properties like isBranch, isBarrier, etc., because didn't know its purpose. But it was found that debugger cannot step over a range of instructions correctly without this knowing, thus, I've added appropriate fields to instructions.

Nov 22 2017, 9:38 AM
tatyana-krasnukha closed D40022: Remove extra minuses from command option.
Nov 22 2017, 9:07 AM
tatyana-krasnukha updated the diff for D40022: Remove extra minuses from command option.

Made diff with full paths (studying to use arcanist)...

Nov 22 2017, 9:06 AM
tatyana-krasnukha updated the diff for D40022: Remove extra minuses from command option.

Things that didn't require review was committed separately.

Nov 22 2017, 7:28 AM

Nov 16 2017

tatyana-krasnukha added a comment to D39742: Add backend name to Target to enable runtime info to be fed back into TableGen.

Build for ARC fails, fix TargetInfo for this target please.

Nov 16 2017, 6:04 AM

Nov 15 2017

tatyana-krasnukha added inline comments to D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Nov 15 2017, 3:10 AM
tatyana-krasnukha added a comment to D39967: Refactoring of MemoryWrite function.

Still have a feeling that it is not enough to clarify for function users that "if (bytes_written != bytes_to_write)" is not always criteria of error, as well as "if (error.Success())" doesn't mean that whole area was written to memory...

Nov 15 2017, 12:17 AM
tatyana-krasnukha updated the diff for D39967: Refactoring of MemoryWrite function.

Same for comment in the header file.

Nov 15 2017, 12:01 AM

Nov 14 2017

tatyana-krasnukha added a comment to D40022: Remove extra minuses from command option.

I have not commit access, that is why I've decided to group all typos in one patch...

Nov 14 2017, 10:59 PM
tatyana-krasnukha updated the diff for D39969: Set error status in ObjectFile::LoadInMemory if it is not set .

Removed clang-format changes.

Nov 14 2017, 10:55 PM
tatyana-krasnukha updated the diff for D39967: Refactoring of MemoryWrite function.

Sorry for wrong formatting, I've removed it.

Nov 14 2017, 10:45 PM
tatyana-krasnukha added inline comments to D40022: Remove extra minuses from command option.
Nov 14 2017, 5:22 AM
tatyana-krasnukha created D40022: Remove extra minuses from command option.
Nov 14 2017, 5:20 AM
tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete,

Nov 14 2017, 4:31 AM

Nov 13 2017

tatyana-krasnukha created D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Nov 13 2017, 10:45 AM
tatyana-krasnukha added inline comments to D39967: Refactoring of MemoryWrite function.
Nov 13 2017, 10:32 AM
tatyana-krasnukha created D39967: Refactoring of MemoryWrite function.
Nov 13 2017, 10:29 AM

Nov 8 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Removed accidentally added file.

Nov 8 2017, 11:44 AM
tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Use type of instruction for its fields instead of 'auto'.

Nov 8 2017, 11:28 AM
tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

I agree that matching the style in other backends is very important, but it is hard to be consistent with last, because it was written long before even c++11 was released...

Nov 8 2017, 11:25 AM
tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete,

Nov 8 2017, 10:40 AM

Oct 12 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Corrupted it by merging...

Oct 12 2017, 9:57 AM
tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Thanks for comment, Pete!

Oct 12 2017, 9:22 AM

Oct 6 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Forgot to change decoder method name.

Oct 6 2017, 9:19 AM

Sep 22 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Applied fixes from 2nd comment.

Sep 22 2017, 10:39 AM
tatyana-krasnukha added inline comments to D37983: Add instruction subset for the ARC backend.
Sep 22 2017, 10:37 AM
tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Added tests, fixed ARCDisassembler.cpp according suggestions.

Sep 22 2017, 10:15 AM

Sep 19 2017

tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete, thank you for review!

Sep 19 2017, 6:35 AM

Sep 18 2017

tatyana-krasnukha created D37983: Add instruction subset for the ARC backend.
Sep 18 2017, 10:42 AM
tatyana-krasnukha added a comment to D37934: Fix compatibility with OpenOCD debug stub..

This obvious solution works well for me and seems safe.

Sep 18 2017, 10:22 AM · Restricted Project

Jul 3 2017

tatyana-krasnukha retitled D34942: [PYTHON] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL" from [PYTHON][Windows] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL" to [PYTHON] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL".
Jul 3 2017, 8:40 AM
tatyana-krasnukha updated the summary of D34942: [PYTHON] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL".
Jul 3 2017, 8:40 AM
tatyana-krasnukha created D34942: [PYTHON] Fix crash with "Fatal Python error: Python memory allocator called without holding the GIL".
Jul 3 2017, 7:34 AM

Jun 30 2017

tatyana-krasnukha added a comment to D4672: For expression evaluation, a new ThreadPlanCallFunctionGDB for executing a function call on target via register manipulation..
Jun 30 2017, 7:37 AM

Jun 27 2017

tatyana-krasnukha added a comment to D34681: [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections.

Saying about clear intent, it would be even much more better if class name doesn't start with DWARF ;)

Jun 27 2017, 12:53 PM

Jun 26 2017

tatyana-krasnukha added a comment to D34613: Add debug_frame section support.

Works well for me. Thank you a lot for bringing it up to scratch!

Jun 26 2017, 7:36 AM

Jun 7 2017

tatyana-krasnukha updated the diff for D33504: Fix FDE indexing while scan debug_info section.

Removed non-printable characters from DWARFCallFrameInfo::GetFDEIndex and redundant version checks from UnwindTable::Initialize.

Jun 7 2017, 6:06 AM

Jun 5 2017

tatyana-krasnukha added inline comments to D33504: Fix FDE indexing while scan debug_info section.
Jun 5 2017, 9:59 AM

Jun 2 2017

tatyana-krasnukha updated the diff for D33504: Fix FDE indexing while scan debug_info section.

Added support of DWARF <= 5. For unsupported versions GetUnwindPlan will return false and next behavior should be like without debug_frame at all. Checked it on binaries with v.2 and v.4 on x86-linux target, but have not a chance to run tests for arm-android and other. I'd appreciate it if someone, who has adjusted environment, would check it.

Jun 2 2017, 9:46 AM

May 25 2017

tatyana-krasnukha added a comment to D33504: Fix FDE indexing while scan debug_info section.

Yes, give those binaries, please.

May 25 2017, 6:40 AM

May 24 2017

tatyana-krasnukha created D33504: Fix FDE indexing while scan debug_info section.
May 24 2017, 9:48 AM

May 23 2017

tatyana-krasnukha added a comment to D32366: Set "success" status correctly.

It can make sense to add

assert(eReturnStatusStarted != result);

after cmd_obj->Execute() invocation at CommandInterpreter::HandleCommand, do you think?

May 23 2017, 1:19 PM · Restricted Project
tatyana-krasnukha added a comment to D31275: Fix lldb build on musl.

Looks reasonable, limits.h really is not included by any of these system headers in musl.

May 23 2017, 12:45 PM · Restricted Project