Page MenuHomePhabricator

tatyana-krasnukha (Tatyana Krasnukha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2017, 8:23 AM (107 w, 4 d)

Recent Activity

Today

tatyana-krasnukha committed rGe0cc56e038df: [lldb-mi] Include full path in the -data-disassemble response (authored by tatyana-krasnukha).
[lldb-mi] Include full path in the -data-disassemble response
Tue, May 21, 6:24 AM

Fri, Apr 26

tatyana-krasnukha committed rGedebf12acfe2: Replace local utility class OnExit with llvm::scope_exit (NFC) (authored by tatyana-krasnukha).
Replace local utility class OnExit with llvm::scope_exit (NFC)
Fri, Apr 26, 9:39 AM

Apr 3 2019

tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Hi, currently we have a private build server that executes the test-suite on ARC. There are failures for now, mostly due to unimplemented features for ARC like expressions support.
I'll take care of a public build-bot, if it is required.

Apr 3 2019, 6:15 AM · Restricted Project

Mar 27 2019

tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

TBE, the best way would be no not even hardcode that info but ask llvm about these things.

Mar 27 2019, 12:39 PM · Restricted Project
tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Back in 2015 I added some code in r247121 that would fill in eh_frame and dwarf register numbers from the ABI plugin if the remote stub didn't provide them in ProcessGDBRemote's AugmentRegisterInfoViaABI. It might be better for ARC to hardcode these generic register additions some place like that.

Mar 27 2019, 8:20 AM · Restricted Project

Mar 26 2019

tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Kind reminder. I believe all discussions have been resolved.

Mar 26 2019, 6:24 AM · Restricted Project

Mar 6 2019

tatyana-krasnukha committed rG1b6700eff4a9: Re-apply "Fix embedded Python initialization according to changes in version 3. (authored by tatyana-krasnukha).
Re-apply "Fix embedded Python initialization according to changes in version 3.
Mar 6 2019, 9:28 AM
tatyana-krasnukha added reviewers for D59015: [lldb-mi] Include full path in the -data-disassemble response: ki.stfu, deepak2427, abidh.
Mar 6 2019, 7:03 AM · Restricted Project, Restricted Project
tatyana-krasnukha added a comment to D57475: [Reproducers] Add SBReproducer macros.

Run into a few compilation errors building on Windows with msvc.

Mar 6 2019, 2:30 AM · Restricted Project

Mar 5 2019

tatyana-krasnukha committed rG622862987f34: Revert "Fix embedded Python initialization according to changes in version 3.7" (authored by tatyana-krasnukha).
Revert "Fix embedded Python initialization according to changes in version 3.7"
Mar 5 2019, 7:27 AM
tatyana-krasnukha committed rGb30c1d571bde: Fix embedded Python initialization according to changes in version 3.7 (authored by tatyana-krasnukha).
Fix embedded Python initialization according to changes in version 3.7
Mar 5 2019, 3:18 AM

Mar 1 2019

tatyana-krasnukha created D58833: Fix embedded Python initialization according to changes in version 3.7.
Mar 1 2019, 10:16 AM · Restricted Project, Restricted Project

Feb 26 2019

tatyana-krasnukha committed rG9e1929305c82: Fix short options syntax in Minidump test (authored by tatyana-krasnukha).
Fix short options syntax in Minidump test
Feb 26 2019, 7:40 AM
tatyana-krasnukha committed rGf388d17d7cad: Fix error handling in Options::Parse (authored by tatyana-krasnukha).
Fix error handling in Options::Parse
Feb 26 2019, 6:51 AM

Feb 25 2019

tatyana-krasnukha committed rGa20bd2735e0e: [lldb-mi] Return source line number in proper format (authored by tatyana-krasnukha).
[lldb-mi] Return source line number in proper format
Feb 25 2019, 10:32 AM
tatyana-krasnukha committed rG96585d11fbf5: [lldb-mi] Fix conversion warning for 64-bit build (authored by tatyana-krasnukha).
[lldb-mi] Fix conversion warning for 64-bit build
Feb 25 2019, 10:24 AM
tatyana-krasnukha committed rG2a4c1f3e5b28: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment (authored by tatyana-krasnukha).
[lldb-mi] Check raw pointers before passing them to std::string ctor/assignment
Feb 25 2019, 8:42 AM
tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Removed new lines from MIUtilString.h

Feb 25 2019, 8:38 AM · Restricted Project

Feb 20 2019

tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

LLDB_PROJECT_ROOT -> LLDB_SOURCE_DIR

Feb 20 2019, 10:21 AM · Restricted Project
tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Thanks for the review!

Feb 20 2019, 9:49 AM · Restricted Project

Feb 16 2019

tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Thank you for mentioning StringRef, you gave me the idea to keep pointers check inside the CMIUtilString to obviate undefined behavior. This is the best place to do it, however, a caller still should examine pointers he passes to CMIUtilString::Format as the ellipsis parameter.

Feb 16 2019, 8:02 PM · Restricted Project
tatyana-krasnukha committed rGb81d715cd251: Add PythonBoolean type to the PythonDataObjects (authored by tatyana-krasnukha).
Add PythonBoolean type to the PythonDataObjects
Feb 16 2019, 10:39 AM

Feb 14 2019

tatyana-krasnukha added a comment to D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Thanks for the review!

Feb 14 2019, 12:41 PM · Restricted Project
tatyana-krasnukha added reviewers for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment: sgraenitz, jingham.
Feb 14 2019, 11:51 AM · Restricted Project
tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Fixed misspelling

Feb 14 2019, 11:48 AM · Restricted Project

Feb 11 2019

tatyana-krasnukha added a comment to D57990: Use std::make_shared in LLDB (NFC).

Yes, of course!

Feb 11 2019, 10:43 AM · Restricted Project
tatyana-krasnukha added a comment to D57990: Use std::make_shared in LLDB (NFC).

These also don't relate directly but intersect with your changes:

Feb 11 2019, 7:40 AM · Restricted Project
tatyana-krasnukha added a comment to D57990: Use std::make_shared in LLDB (NFC).

A few modernizations which though don't directly relate to make_shared:

Feb 11 2019, 6:48 AM · Restricted Project

Feb 6 2019

tatyana-krasnukha created D57817: Add PythonBoolean type to PythonDataObjects.
Feb 6 2019, 6:38 AM · Restricted Project

Jan 31 2019

tatyana-krasnukha updated the diff for D55724: [ARC] Add SystemV ABI.

Updated file headers to reflect the new license;
Updated according to the last revision of D55718.

Jan 31 2019, 3:55 PM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Changed configuration register handling logic: if an RSP-server doesn't provide a register, don't count this as a failure - just use default values for flags.

Jan 31 2019, 1:13 PM · Restricted Project

Jan 24 2019

tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Updated new file headers to reflect the new license

Jan 24 2019, 7:10 AM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Moved ARC flags enum inside the ArchitectureArc class;

Jan 24 2019, 6:38 AM · Restricted Project
tatyana-krasnukha added inline comments to D55718: [ARC] Basic support in gdb-remote process plugin.
Jan 24 2019, 5:44 AM · Restricted Project

Jan 23 2019

tatyana-krasnukha updated the diff for D55724: [ARC] Add SystemV ABI.

Updated according to D55718

Jan 23 2019, 9:05 AM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Addressed comments

Jan 23 2019, 9:01 AM · Restricted Project

Jan 21 2019

tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Keep trying to hide the processor's specifics from the ProcessGDBRemote

Jan 21 2019, 10:24 PM · Restricted Project
tatyana-krasnukha added inline comments to D55718: [ARC] Basic support in gdb-remote process plugin.
Jan 21 2019, 12:02 PM · Restricted Project
tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Why lldb_private::Flags is required? std::bitset provides the same functionality and even more.

Jan 21 2019, 11:18 AM · Restricted Project

Jan 19 2019

tatyana-krasnukha added inline comments to D55718: [ARC] Basic support in gdb-remote process plugin.
Jan 19 2019, 7:13 AM · Restricted Project

Jan 18 2019

tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

After all, I moved ARC configuring routines to the ArchitechtureArc plug-in.

Jan 18 2019, 5:00 AM · Restricted Project

Jan 17 2019

tatyana-krasnukha updated the diff for D55724: [ARC] Add SystemV ABI.

Addressed the comment

Jan 17 2019, 11:10 AM · Restricted Project
tatyana-krasnukha updated the diff for D55724: [ARC] Add SystemV ABI.

Added a list of registers with correct dwarf numbers

Jan 17 2019, 9:51 AM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Removed registers adjustment, dwarf numbers are corrected by AugmentRegisterInfoViaABI now.

Jan 17 2019, 9:51 AM · Restricted Project
tatyana-krasnukha added inline comments to D55718: [ARC] Basic support in gdb-remote process plugin.
Jan 17 2019, 8:25 AM · Restricted Project

Jan 14 2019

tatyana-krasnukha added inline comments to D55718: [ARC] Basic support in gdb-remote process plugin.
Jan 14 2019, 12:09 PM · Restricted Project
tatyana-krasnukha updated subscribers of D55718: [ARC] Basic support in gdb-remote process plugin.
Jan 14 2019, 11:18 AM · Restricted Project
tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Friendly ping. I would like to have this in the nearest release.

Jan 14 2019, 8:46 AM · Restricted Project
tatyana-krasnukha abandoned D55827: Update current working directory to avoid test crashes.

It is fixed.

Jan 14 2019, 8:23 AM · Restricted Project

Dec 19 2018

tatyana-krasnukha updated the diff for D55472: Speadup memory regions handling and cleanup related code.

Rid off of including std::vector at the cost of adding a wrapper class that can be forward declared.
Without this, it is not possible to do https://reviews.llvm.org/D55472#inline-491159

Dec 19 2018, 12:21 PM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Clear m_register_info if it is incorrect.

Dec 19 2018, 11:56 AM · Restricted Project
tatyana-krasnukha updated the diff for D55841: GetMemoryRegions for the ProcessMinidump.

Removed dump file from the patch

Dec 19 2018, 11:54 AM · Restricted Project
tatyana-krasnukha added inline comments to D55718: [ARC] Basic support in gdb-remote process plugin.
Dec 19 2018, 11:32 AM · Restricted Project
tatyana-krasnukha updated the diff for D55841: GetMemoryRegions for the ProcessMinidump.

Add a test

Dec 19 2018, 10:37 AM · Restricted Project
tatyana-krasnukha updated the diff for D55472: Speadup memory regions handling and cleanup related code.

Minor change: replace using with typedef since old swig versions don't understand c++11's aliases.

Dec 19 2018, 7:29 AM · Restricted Project
tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

ARCflags are used by ABISysV_arc (related patch D55724). I would be glad to move it to architecture plugin, but I ought to add SetFlags/GetFlags to Architecture interface in this case. Then we'll have the same members in ArchSpec and in Architecture, that may look confusing.

Dec 19 2018, 2:45 AM · Restricted Project

Dec 18 2018

tatyana-krasnukha created D55841: GetMemoryRegions for the ProcessMinidump.
Dec 18 2018, 10:52 AM · Restricted Project
tatyana-krasnukha updated the diff for D55472: Speadup memory regions handling and cleanup related code.

Addressed more comments

Dec 18 2018, 10:39 AM · Restricted Project
tatyana-krasnukha updated the diff for D55472: Speadup memory regions handling and cleanup related code.

Replace vector of unique pointers with vector of values, revert some API changes, remove MinidumpParser changes.
I will put overridden GetMemoryRegions in a separate patch.

Dec 18 2018, 8:48 AM · Restricted Project
tatyana-krasnukha created D55827: Update current working directory to avoid test crashes.
Dec 18 2018, 8:05 AM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Addressed review comments

Dec 18 2018, 5:10 AM · Restricted Project
tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

My intent was to move ARC-specific code to the architecture plugin as much as possible, but it requires to add undesired dependencies to Architecture interface. So, you are right, it seems to be better to keep these functions in ProcessGDBRemote.cpp and remove ArcArchitecture plugin at all.

Dec 18 2018, 4:47 AM · Restricted Project

Dec 14 2018

tatyana-krasnukha added a parent revision for D55724: [ARC] Add SystemV ABI: D55718: [ARC] Basic support in gdb-remote process plugin.
Dec 14 2018, 2:50 PM · Restricted Project
tatyana-krasnukha added a child revision for D55718: [ARC] Basic support in gdb-remote process plugin: D55724: [ARC] Add SystemV ABI.
Dec 14 2018, 2:50 PM · Restricted Project
tatyana-krasnukha created D55724: [ARC] Add SystemV ABI.
Dec 14 2018, 2:50 PM · Restricted Project
tatyana-krasnukha created D55718: [ARC] Basic support in gdb-remote process plugin.
Dec 14 2018, 1:56 PM · Restricted Project

Dec 13 2018

tatyana-krasnukha created D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.
Dec 13 2018, 6:12 AM · Restricted Project

Dec 10 2018

tatyana-krasnukha added a comment to D55472: Speadup memory regions handling and cleanup related code.

Thanks to all for comments!

Dec 10 2018, 12:31 PM · Restricted Project
tatyana-krasnukha added a comment to D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available..

Don't you mind to take overridden GetMemoryRegions in this patch so that I can remove all minidump-related changes from D55472?

Dec 10 2018, 12:19 PM
tatyana-krasnukha added a comment to D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available..

Without overriding Process::GetMemoryRegions still does a lot of unnecessary job (FindMemoryRegion for each element in the vector).
With these changes, it may just return m_regions (if not empty), doesn't it?

Dec 10 2018, 11:20 AM

Dec 7 2018

tatyana-krasnukha created D55472: Speadup memory regions handling and cleanup related code.
Dec 7 2018, 10:52 PM · Restricted Project

Nov 26 2018

tatyana-krasnukha updated the diff for D53100: clang: Add ARCTargetInfo.

Minor change: remove splitting big numeric arguments on 32-bit integers. Backend lowering code does this work.

Nov 26 2018, 10:45 AM · Restricted Project

Oct 10 2018

tatyana-krasnukha created D53101: [ARC] Add option for enabling reduced register file mode.
Oct 10 2018, 11:55 AM · Restricted Project
tatyana-krasnukha added a child revision for D53100: clang: Add ARCTargetInfo: D53101: [ARC] Add option for enabling reduced register file mode.
Oct 10 2018, 11:55 AM · Restricted Project
tatyana-krasnukha added a parent revision for D53101: [ARC] Add option for enabling reduced register file mode: D53100: clang: Add ARCTargetInfo.
Oct 10 2018, 11:55 AM · Restricted Project
tatyana-krasnukha added a child revision for D43089: clang: Add ARCTargetInfo: D53100: clang: Add ARCTargetInfo.
Oct 10 2018, 11:46 AM
tatyana-krasnukha added a parent revision for D53100: clang: Add ARCTargetInfo: D43089: clang: Add ARCTargetInfo.
Oct 10 2018, 11:46 AM · Restricted Project
tatyana-krasnukha created D53100: clang: Add ARCTargetInfo.
Oct 10 2018, 11:45 AM · Restricted Project

Sep 28 2018

tatyana-krasnukha added inline comments to D52604: Clean-up usage of OptionDefinition arrays.
Sep 28 2018, 7:48 AM · Restricted Project
tatyana-krasnukha updated the diff for D52604: Clean-up usage of OptionDefinition arrays.

Modifies Driver::ParseArgs checks

Sep 28 2018, 7:41 AM · Restricted Project

Sep 27 2018

tatyana-krasnukha added inline comments to D52604: Clean-up usage of OptionDefinition arrays.
Sep 27 2018, 4:49 AM · Restricted Project
tatyana-krasnukha created D52604: Clean-up usage of OptionDefinition arrays.
Sep 27 2018, 4:34 AM · Restricted Project

Sep 26 2018

tatyana-krasnukha added a comment to D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef.

It seems you are speaking about OptionDefinition, not PropertyDefinition. I was going to create a separate revision for it. Should I add OptionDefinition-related changes here?

Sep 26 2018, 4:40 PM · Restricted Project
tatyana-krasnukha added a comment to D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef.

Hmm... There is no such logic left, isn't it?
If you mean iterating OptionValueProperties::m_properties vector, I can replace cycles with range based for loop, but this doesn't seem to be related to these changes.

Sep 26 2018, 4:26 PM · Restricted Project
tatyana-krasnukha created D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef.
Sep 26 2018, 1:41 PM · Restricted Project
tatyana-krasnukha retitled D49017: Replace "nullptr-terminated" C-arrays of OptionValueEnumeration with safer llvm::ArrayRef from Replace "nullptr-terminated" C-array with safer llvm::ArrayRef for PropertyDefinition and OptionDefinition. to Replace "nullptr-terminated" C-arrays of OptionValueEnumeration with safer llvm::ArrayRef.
Sep 26 2018, 11:52 AM

Sep 25 2018

tatyana-krasnukha added inline comments to D49739: Add new API to SBTarget class.
Sep 25 2018, 10:30 AM
tatyana-krasnukha added a comment to D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Now works with Python 3.1 too. LGTM.

Sep 25 2018, 9:57 AM
tatyana-krasnukha added a comment to D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Forget that the test calls default python, not which was passed to cmake. So, it is enough to replace (3,0) pair with (3,2) to fix.

Sep 25 2018, 9:32 AM
tatyana-krasnukha added a comment to D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

It seems I ran into an unrelated issue like this. If the revision works for others, you may ignore this.

Sep 25 2018, 9:12 AM
tatyana-krasnukha added a comment to D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Sorry, it was added in 3.2. Anyway, the test fails due to __init__() got an unexpected keyword argument 'pass_fds'.

Sep 25 2018, 8:43 AM
tatyana-krasnukha added a comment to D49017: Replace "nullptr-terminated" C-arrays of OptionValueEnumeration with safer llvm::ArrayRef.

Could you look at it again, please?

Sep 25 2018, 7:42 AM
tatyana-krasnukha abandoned D48384: WIP: Let OptionArgParser fix up address arguments depending on intended use..

Adding address adjustment to OptionArgParser doesn't help when disassembling is requested through API. Close the revision, since I have not a centralized solution for now.

Sep 25 2018, 7:41 AM

Sep 24 2018

tatyana-krasnukha accepted D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

A lot of tests are failing with Python 3, at least on CentOS. So, I agree the problem doesn't block this review.

Sep 24 2018, 11:35 AM
tatyana-krasnukha updated the diff for D52376: [Swig] Merge typemaps with same bodies.

Thanks for the information I missed. Removed all changes of API and joined together more typemap implementations.

Sep 24 2018, 11:03 AM · Restricted Project

Sep 21 2018

tatyana-krasnukha created D52376: [Swig] Merge typemaps with same bodies.
Sep 21 2018, 1:07 PM · Restricted Project
tatyana-krasnukha added a comment to D48623: Move architecture-specific address adjustment to architecture plugins..

Thanks for your patience;)

Sep 21 2018, 11:55 AM
tatyana-krasnukha updated the diff for D48623: Move architecture-specific address adjustment to architecture plugins..
Sep 21 2018, 11:16 AM
tatyana-krasnukha updated the diff for D51999: build: add libedit to include paths.

LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't propagate lldbHost's include directories to lldbCore and lldbInterpreter.
For lldbHost itself, I had to use PUBLIC, because its sources require includes libedit headers and unittests inherit this path too.

Sep 21 2018, 10:44 AM
tatyana-krasnukha updated the diff for D48623: Move architecture-specific address adjustment to architecture plugins..

Make overriding functions public.

Sep 21 2018, 7:24 AM