Page MenuHomePhabricator

tatyana-krasnukha (Tatyana Krasnukha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2017, 8:23 AM (207 w, 4 d)

Recent Activity

Feb 28 2021

tatyana-krasnukha abandoned D96817: Fix deep copying for OptionValue classes.

D96952 is landed instead.

Feb 28 2021, 8:29 AM · Restricted Project
tatyana-krasnukha added inline comments to D96952: CRTP-based version of D96817.
Feb 28 2021, 8:27 AM · Restricted Project
tatyana-krasnukha committed rG1d6a6f3b0c71: [lldb/Target] Remove outdated code (authored by tatyana-krasnukha).
[lldb/Target] Remove outdated code
Feb 28 2021, 8:25 AM
tatyana-krasnukha committed rGf0f183ee4ad9: [lldb/Interpreter] Fix deep copying for OptionValue classes (authored by tatyana-krasnukha).
[lldb/Interpreter] Fix deep copying for OptionValue classes
Feb 28 2021, 8:24 AM
tatyana-krasnukha committed rGef447fe0088c: [lldb] OptionValueProperties::Get[Set]PropertyAtIndexAsArgs should handle… (authored by tatyana-krasnukha).
[lldb] OptionValueProperties::Get[Set]PropertyAtIndexAsArgs should handle…
Feb 28 2021, 8:24 AM
tatyana-krasnukha committed rGb2faf3018944: [lldb][NFC] Make OptionValueArgs::GetArgs constant (authored by tatyana-krasnukha).
[lldb][NFC] Make OptionValueArgs::GetArgs constant
Feb 28 2021, 8:24 AM
tatyana-krasnukha committed rG8cdcd41e384b: [lldb/Interpreter][NFC] Remove explicit default initialization of members and… (authored by tatyana-krasnukha).
[lldb/Interpreter][NFC] Remove explicit default initialization of members and…
Feb 28 2021, 8:24 AM
tatyana-krasnukha closed D96952: CRTP-based version of D96817.
Feb 28 2021, 8:24 AM · Restricted Project
tatyana-krasnukha committed rG54d03a4985bc: [lldb/Interpreter][NFC] Replace default constructors/destructors bodies with… (authored by tatyana-krasnukha).
[lldb/Interpreter][NFC] Replace default constructors/destructors bodies with…
Feb 28 2021, 8:24 AM
tatyana-krasnukha committed rG918211786189: [lldb/Interpreter][NFC] Remove more deleted const char* overloads (authored by tatyana-krasnukha).
[lldb/Interpreter][NFC] Remove more deleted const char* overloads
Feb 28 2021, 8:24 AM

Feb 19 2021

tatyana-krasnukha updated the diff for D96952: CRTP-based version of D96817.

Removed unrelated changes from the patch.

Feb 19 2021, 2:54 PM · Restricted Project
tatyana-krasnukha added a comment to D96952: CRTP-based version of D96817.

Thanks for such a detailed review, David!
I would love to split off the changes into separate patches, but if I do so, this patch just will not be compileable.

Feb 19 2021, 2:53 PM · Restricted Project

Feb 18 2021

tatyana-krasnukha added a comment to D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support.

clang-tidy would not be happy;)

Feb 18 2021, 8:13 AM · Restricted Project
tatyana-krasnukha added a comment to D96817: Fix deep copying for OptionValue classes.

I created D96952 - a demonstrative example of the CRTP-based version of this patch. Please, take a look.

Feb 18 2021, 7:51 AM · Restricted Project
tatyana-krasnukha updated the summary of D96952: CRTP-based version of D96817.
Feb 18 2021, 7:47 AM · Restricted Project
tatyana-krasnukha requested review of D96952: CRTP-based version of D96817.
Feb 18 2021, 5:35 AM · Restricted Project

Feb 17 2021

tatyana-krasnukha updated the diff for D96817: Fix deep copying for OptionValue classes.

Removed explicit conversions to StringRef from the test with respect to D96861.

Feb 17 2021, 2:59 PM · Restricted Project
tatyana-krasnukha accepted D96861: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString.
Feb 17 2021, 5:52 AM · Restricted Project
tatyana-krasnukha added a comment to D96817: Fix deep copying for OptionValue classes.

CRTP was my first implementation, however, I discarded it as more bug-prone. Virtual Clone function at the interface is so common that, I believe, everyone knows it must be overridden by a new derived class. The necessity of inheriting from base_clone_helper is not so obvious.

Feb 17 2021, 3:34 AM · Restricted Project

Feb 16 2021

tatyana-krasnukha requested review of D96817: Fix deep copying for OptionValue classes.
Feb 16 2021, 2:15 PM · Restricted Project

Feb 8 2021

tatyana-krasnukha committed rG05d7d6949c7c: [lldb/tests] Removed add_test_categories decorator for python API tests, NFC (authored by tatyana-krasnukha).
[lldb/tests] Removed add_test_categories decorator for python API tests, NFC
Feb 8 2021, 4:13 AM
tatyana-krasnukha committed rGf9c5e1664e08: [lldb/tests] Un-skip TestGuiBasicDebug.py on Arm and AArch64 (authored by tatyana-krasnukha).
[lldb/tests] Un-skip TestGuiBasicDebug.py on Arm and AArch64
Feb 8 2021, 4:13 AM
tatyana-krasnukha committed rG36de94cf54ef: Reland "[lldb] Make CommandInterpreter's execution context the same as… (authored by tatyana-krasnukha).
Reland "[lldb] Make CommandInterpreter's execution context the same as…
Feb 8 2021, 4:13 AM
tatyana-krasnukha committed rGa39bcbca92e1: [lldb] Debugger: reuse ExecutionContextRef to create ExecutionContext from… (authored by tatyana-krasnukha).
[lldb] Debugger: reuse ExecutionContextRef to create ExecutionContext from…
Feb 8 2021, 4:13 AM

Feb 3 2021

tatyana-krasnukha added a comment to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.

I just triaged the gcc 5.4 build break. It appears that std::is_trivially_copy_constructible<T> instantiates the copy constructor (which is... strange). So we can't query a compile-time property without the compiler forcing instantiation of the deleted copy constructor in this case.

This bug exists all the way up through gcc 7.3. Here's a godbolt link which reproduces the problem:
https://godbolt.org/z/ETW7f1

Feb 3 2021, 4:57 AM · Restricted Project

Feb 2 2021

tatyana-krasnukha added a comment to D92164: Make CommandInterpreter's execution context the same as debugger's one..

I think your test case is even better, the one in D95761 doesn't try to run commands.

Feb 2 2021, 5:14 AM · Restricted Project

Feb 1 2021

tatyana-krasnukha updated the diff for D92164: Make CommandInterpreter's execution context the same as debugger's one..

Removed test since the same case was added by D95761.

Feb 1 2021, 12:24 PM · Restricted Project
tatyana-krasnukha updated the diff for D92164: Make CommandInterpreter's execution context the same as debugger's one..

It turns out that the Debugger recalculated the selected stack frame without taking the Process's run lock. I replaced the whole context evaluation with creating ExecutionContextRef which does these things right.

Feb 1 2021, 12:02 PM · Restricted Project

Jan 20 2021

tatyana-krasnukha added a comment to D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..

D92164 was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as soon as possible.

Jan 20 2021, 2:34 AM · Restricted Project

Dec 19 2020

tatyana-krasnukha added a comment to D92164: Make CommandInterpreter's execution context the same as debugger's one..

With this version of the patch, I am unable to reproduce the issue using the approach I described in the previous comment. However, it still reproduces when issuing the equivalent commands via the "gui" (either "by hand" or by running TestGuiBasicDebug.py).

Dec 19 2020, 2:39 PM · Restricted Project

Dec 18 2020

tatyana-krasnukha updated the diff for D92164: Make CommandInterpreter's execution context the same as debugger's one..

Fixed CommandInterpreter::GetProcessOutput to avoid deadlock in Windows process plugin. This should also fix the problem @labath described above.

Dec 18 2020, 5:47 AM · Restricted Project

Dec 12 2020

tatyana-krasnukha committed rGa01b26fb51c7: [lldb] Make CommandInterpreter's execution context the same as debugger's one. (authored by tatyana-krasnukha).
[lldb] Make CommandInterpreter's execution context the same as debugger's one.
Dec 12 2020, 5:41 AM
tatyana-krasnukha committed rG7832d7e95ace: [lldb] Modernize TargetList for-loops, NFC (authored by tatyana-krasnukha).
[lldb] Modernize TargetList for-loops, NFC
Dec 12 2020, 5:41 AM
tatyana-krasnukha committed rG2634ec6ce900: [lldb] "target create" shouldn't save target if the command failed (authored by tatyana-krasnukha).
[lldb] "target create" shouldn't save target if the command failed
Dec 12 2020, 5:41 AM
tatyana-krasnukha closed D92164: Make CommandInterpreter's execution context the same as debugger's one..
Dec 12 2020, 5:41 AM · Restricted Project
tatyana-krasnukha closed D93052: "target create" shouldn't save target if the command failed.
Dec 12 2020, 5:41 AM · Restricted Project

Dec 11 2020

tatyana-krasnukha updated the diff for D93052: "target create" shouldn't save target if the command failed.

Removed do_select's default value.

Dec 11 2020, 12:16 AM · Restricted Project

Dec 10 2020

tatyana-krasnukha updated the diff for D92164: Make CommandInterpreter's execution context the same as debugger's one..

Thanks for pointing to the nested command problem! Replaced pointer to the execution context with the stack of contexts.

Dec 10 2020, 10:10 PM · Restricted Project
tatyana-krasnukha requested review of D93052: "target create" shouldn't save target if the command failed.
Dec 10 2020, 9:42 AM · Restricted Project
tatyana-krasnukha updated the diff for D92164: Make CommandInterpreter's execution context the same as debugger's one..

Addressed comments

Dec 10 2020, 9:20 AM · Restricted Project

Nov 30 2020

tatyana-krasnukha updated the diff for D92164: Make CommandInterpreter's execution context the same as debugger's one..

Removed refactoring to make the changes clearer.

Nov 30 2020, 4:46 AM · Restricted Project

Nov 26 2020

tatyana-krasnukha requested review of D92164: Make CommandInterpreter's execution context the same as debugger's one..
Nov 26 2020, 2:56 AM · Restricted Project

Oct 7 2020

tatyana-krasnukha accepted D88967: [lldb] Add a cmake warning about the python/swig incompatibility.
Oct 7 2020, 10:15 AM · Restricted Project

Oct 6 2020

tatyana-krasnukha added inline comments to D88769: [trace] Scaffold "thread trace dump instructions".
Oct 6 2020, 11:10 AM · Restricted Project
tatyana-krasnukha accepted D88906: [lldb/docs] Clarify python/swig version incompatibility.

I used Swig 3.0.12 + cherry-picked commit that fixes that bug (https://github.com/swig/swig/issues/1321) on Windows. It worked well with both Python 3.7 and 3.8.

Oct 6 2020, 9:29 AM · Restricted Project

Sep 14 2020

tatyana-krasnukha accepted D86866: Add Option to sphinx-build for custom conf file location.

Looks reasonable to me.

Sep 14 2020, 3:41 AM · Restricted Project

Aug 5 2020

tatyana-krasnukha added a comment to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

I'm not familiar with the z/OS target, so I cannot check the correctness of the target-specific changes. The overall patch looks good.

Aug 5 2020, 2:40 PM · Restricted Project
tatyana-krasnukha committed rGbc056b3aa713: [lldb] Suppress MSVC warning C4065 (authored by tatyana-krasnukha).
[lldb] Suppress MSVC warning C4065
Aug 5 2020, 2:11 AM
tatyana-krasnukha committed rG75012a80440f: [lldb] Use PyUnicode_GetLength instead of PyUnicode_GetSize (authored by tatyana-krasnukha).
[lldb] Use PyUnicode_GetLength instead of PyUnicode_GetSize
Aug 5 2020, 2:11 AM
tatyana-krasnukha committed rGcc68c122cd00: [lldb/TestingSupport] Manually disable GTEST_HAS_TR1_TUPLE (authored by tatyana-krasnukha).
[lldb/TestingSupport] Manually disable GTEST_HAS_TR1_TUPLE
Aug 5 2020, 2:11 AM

Aug 4 2020

tatyana-krasnukha committed rG4f5ccc72f6a6: Partially revert "[cmake] Make MSVC generate appropriate __cplusplus macro… (authored by tatyana-krasnukha).
Partially revert "[cmake] Make MSVC generate appropriate __cplusplus macro…
Aug 4 2020, 2:22 AM
tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

I see. The option "/Zc:__cplusplus" affects GTEST_LANG_CXX11 but not GTEST_HAS_TR1_TUPLE. I didn't have warnings just because my LLVM fork uses C++17.

Aug 4 2020, 2:00 AM · Restricted Project

Aug 3 2020

tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

The option "/Zc:__cplusplus" solves this problem. With this option passed, Gtest doesn't try using namespace tr1. I don't have such warnings if pass this option.

Aug 3 2020, 2:25 PM · Restricted Project
tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

LLVM documentation says: "You will need Visual Studio 2017 or higher, with the latest Update installed". Does this mean Visual Studio 2017 version 15.9? Because the /Zc:__cplusplus option is available starting in Visual Studio 2017 version 15.7.

Aug 3 2020, 4:40 AM · Restricted Project
tatyana-krasnukha committed rGe97c693bb0ec: [lldb/Process/Windows] Attempting to kill exited/detached process in not an… (authored by tatyana-krasnukha).
[lldb/Process/Windows] Attempting to kill exited/detached process in not an…
Aug 3 2020, 2:53 AM
tatyana-krasnukha committed rGc3339e3e921c: [cmake] Make MSVC generate appropriate __cplusplus macro definition (authored by tatyana-krasnukha).
[cmake] Make MSVC generate appropriate __cplusplus macro definition
Aug 3 2020, 2:53 AM
tatyana-krasnukha closed D84023: Make MSVC generate appropriate __cplusplus macro definition.
Aug 3 2020, 2:53 AM · Restricted Project
tatyana-krasnukha closed D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.
Aug 3 2020, 2:53 AM · Restricted Project
tatyana-krasnukha added a comment to D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.

Thank you! I fixed the commit title and description as you suggested.

Aug 3 2020, 2:53 AM · Restricted Project

Jul 30 2020

tatyana-krasnukha updated the diff for D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints.

TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check.

Jul 30 2020, 1:19 PM · Restricted Project
tatyana-krasnukha retitled D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error from [lldb/Process/Windows] Trying to kill exited/detached process in not error to [lldb/Process/Windows] Attempt to kill exited/detached process in not error.
Jul 30 2020, 11:00 AM · Restricted Project
tatyana-krasnukha added a reviewer for D84023: Make MSVC generate appropriate __cplusplus macro definition: asmith.
Jul 30 2020, 10:57 AM · Restricted Project
tatyana-krasnukha requested review of D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.
Jul 30 2020, 10:56 AM · Restricted Project
tatyana-krasnukha requested review of D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints.
Jul 30 2020, 10:48 AM · Restricted Project

Jul 29 2020

tatyana-krasnukha committed rGda0bba5c9abb: [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its… (authored by tatyana-krasnukha).
[lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its…
Jul 29 2020, 12:08 PM
tatyana-krasnukha closed D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation.
Jul 29 2020, 12:08 PM · Restricted Project
tatyana-krasnukha committed rGd5c1f686e34f: [lldb/BreakpointSite] Handle all ways of control flow (authored by tatyana-krasnukha).
[lldb/BreakpointSite] Handle all ways of control flow
Jul 29 2020, 11:53 AM
tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

Ups... Pushed it occationaly with the other patchs.

Jul 29 2020, 11:32 AM · Restricted Project
tatyana-krasnukha committed rGebaa8b1c6074: [lldb] Don't use hardware index to determine whether a breakpoint site is… (authored by tatyana-krasnukha).
[lldb] Don't use hardware index to determine whether a breakpoint site is…
Jul 29 2020, 11:27 AM
tatyana-krasnukha committed rGb352e62feadd: [lldb] Make process plugins check whether a hardware breakpoint is required (authored by tatyana-krasnukha).
[lldb] Make process plugins check whether a hardware breakpoint is required
Jul 29 2020, 11:27 AM
tatyana-krasnukha committed rGf7ec3e3be70d: [lldb] Skip overlapping hardware and external breakpoints when writing memory (authored by tatyana-krasnukha).
[lldb] Skip overlapping hardware and external breakpoints when writing memory
Jul 29 2020, 11:27 AM
tatyana-krasnukha closed D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.
Jul 29 2020, 11:27 AM · Restricted Project
tatyana-krasnukha closed D84255: [lldb] Make process plugins check whether a hardware breakpoint is required.
Jul 29 2020, 11:27 AM · Restricted Project
tatyana-krasnukha closed D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory.
Jul 29 2020, 11:27 AM · Restricted Project
tatyana-krasnukha committed rGc114352edfe0: [lldb/test] Put hardware breakpoint tests together, NFC (authored by tatyana-krasnukha).
[lldb/test] Put hardware breakpoint tests together, NFC
Jul 29 2020, 11:20 AM
tatyana-krasnukha closed D84311: [lldb/test] Put hardware breakpoint tests together, NFC.
Jul 29 2020, 11:20 AM · Restricted Project
tatyana-krasnukha updated the diff for D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation.

Addressed comments.

Jul 29 2020, 8:22 AM · Restricted Project
tatyana-krasnukha updated the diff for D84255: [lldb] Make process plugins check whether a hardware breakpoint is required.

Un-skip TestRequireHWBreakpoints.py on Windows, now it works as expected.

Jul 29 2020, 8:10 AM · Restricted Project
tatyana-krasnukha added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

It also fixes warnings about using deprecated std::tr1, which became errors in VS 2019, produced while compiling lldbUtilityHelpers project (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17887/steps/test/logs/stdio).

Jul 29 2020, 8:07 AM · Restricted Project

Jul 24 2020

tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that.

Jul 24 2020, 6:54 AM · Restricted Project
tatyana-krasnukha updated the diff for D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

@omjavaid, thank you for verifying this!

Jul 24 2020, 6:52 AM · Restricted Project
tatyana-krasnukha updated the summary of D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation.
Jul 24 2020, 6:43 AM · Restricted Project
Herald added a project to D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation: Restricted Project.
Jul 24 2020, 6:43 AM · Restricted Project

Jul 22 2020

tatyana-krasnukha created D84311: [lldb/test] Put hardware breakpoint tests together, NFC.
Jul 22 2020, 5:22 AM · Restricted Project
tatyana-krasnukha updated the diff for D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory.

BreakpointSite::IntersectsRange returns false for hardware breakpoints, that's why the assertion fails.

Jul 22 2020, 5:22 AM · Restricted Project
tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.
Jul 22 2020, 2:58 AM · Restricted Project

Jul 21 2020

tatyana-krasnukha added a comment to D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.

Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64.

Jul 21 2020, 12:00 PM · Restricted Project
tatyana-krasnukha created D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware.
Jul 21 2020, 11:25 AM · Restricted Project
tatyana-krasnukha created D84255: [lldb] Make process plugins check whether a hardware breakpoint is required.
Jul 21 2020, 11:23 AM · Restricted Project
tatyana-krasnukha created D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory.
Jul 21 2020, 11:21 AM · Restricted Project
tatyana-krasnukha added a reviewer for D84023: Make MSVC generate appropriate __cplusplus macro definition: stella.stamenova.
Jul 21 2020, 6:31 AM · Restricted Project

Jul 20 2020

tatyana-krasnukha updated the diff for D84023: Make MSVC generate appropriate __cplusplus macro definition.

No updates, just to trigger rebasing onto master where tests should be already fixed.

Jul 20 2020, 3:43 AM · Restricted Project

Jul 17 2020

Herald added a project to D84023: Make MSVC generate appropriate __cplusplus macro definition: Restricted Project.
Jul 17 2020, 6:36 AM · Restricted Project

Mar 26 2020

tatyana-krasnukha committed rGa92673fe9a08: [lldb-vscode] Convert launch_info and attach_info to local variables (authored by anton.kolesov).
[lldb-vscode] Convert launch_info and attach_info to local variables
Mar 26 2020, 9:13 AM
tatyana-krasnukha closed D76593: [lldb-vscode] Convert launch_info and attach_info to local variables.
Mar 26 2020, 9:12 AM · Restricted Project
tatyana-krasnukha committed rG2bfe2b878a62: [lldb][testsuite] Check that process is launched successfully in inline tests (authored by tatyana-krasnukha).
[lldb][testsuite] Check that process is launched successfully in inline tests
Mar 26 2020, 5:23 AM
tatyana-krasnukha committed rGccf1c30cde6e: [lldb][testsuite] Add lldb-server category (authored by tatyana-krasnukha).
[lldb][testsuite] Add lldb-server category
Mar 26 2020, 5:23 AM
tatyana-krasnukha abandoned D76309: Add wait timeout to process properties.

Lit option --timeout partly solves the problem, so these changes are unnecessary.

Mar 26 2020, 5:23 AM

Mar 20 2020

tatyana-krasnukha committed rG0b18b568e91a: [lldb-vscode] Don't use SBLaunchInfo in request_attach (authored by anton.kolesov).
[lldb-vscode] Don't use SBLaunchInfo in request_attach
Mar 20 2020, 10:18 AM
tatyana-krasnukha closed D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach.
Mar 20 2020, 10:18 AM · Restricted Project