tatyana-krasnukha (Tatyana Krasnukha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2017, 8:23 AM (64 w, 2 d)

Recent Activity

Thu, Jul 19

tatyana-krasnukha added a comment to D48623: WIP: Move architecture-specific address adjustment to architecture plugins..

@clayborg , thank you for the feedback, but why don't you like the approach with static functions?

Thu, Jul 19, 6:46 AM
tatyana-krasnukha updated the diff for D49017: Replace "nullptr-terminated" C-array with safer llvm::ArrayRef for PropertyDefinition and OptionDefinition..

Thank you for pointing this problem. Though ArrayRef constructor with std::array parameter is declared as constexpr, it is not a constant expression actually because std::array::data() member function is not constexpr until C++17.
So, I reverted using std::array and added constexpr keyword to each static PropertyDefinition and OptionDefinition to ensure that constant initialization requirements remain satisfied.

Thu, Jul 19, 12:28 AM

Tue, Jul 10

tatyana-krasnukha added a comment to D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero.

Oops! I meant only your changes when asking to use nullptr instead of NULL;)

Tue, Jul 10, 11:35 AM
tatyana-krasnukha added inline comments to D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero.
Tue, Jul 10, 3:49 AM
tatyana-krasnukha added a comment to D49111: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero.

Some code style notes

Tue, Jul 10, 3:15 AM

Mon, Jul 9

tatyana-krasnukha updated the diff for D48623: WIP: Move architecture-specific address adjustment to architecture plugins..

Upd: Making functions static with Target* parameter allowed to rid out of checking target and architecture plugin by caller code.

Mon, Jul 9, 3:42 PM

Fri, Jul 6

tatyana-krasnukha added reviewers for D49017: Replace "nullptr-terminated" C-array with safer llvm::ArrayRef for PropertyDefinition and OptionDefinition.: clayborg, jingham, zturner.
Fri, Jul 6, 3:55 AM
tatyana-krasnukha added a comment to D49017: Replace "nullptr-terminated" C-array with safer llvm::ArrayRef for PropertyDefinition and OptionDefinition..
Fri, Jul 6, 3:45 AM
tatyana-krasnukha created D49017: Replace "nullptr-terminated" C-array with safer llvm::ArrayRef for PropertyDefinition and OptionDefinition..
Fri, Jul 6, 3:40 AM

Wed, Jun 27

tatyana-krasnukha updated the diff for D48623: WIP: Move architecture-specific address adjustment to architecture plugins..

Uncommented arguments and used ArchSpec::IsMIPS()

Wed, Jun 27, 2:30 AM
tatyana-krasnukha added inline comments to D48623: WIP: Move architecture-specific address adjustment to architecture plugins..
Wed, Jun 27, 2:25 AM
tatyana-krasnukha added inline comments to D48623: WIP: Move architecture-specific address adjustment to architecture plugins..
Wed, Jun 27, 1:33 AM
tatyana-krasnukha added a comment to D48623: WIP: Move architecture-specific address adjustment to architecture plugins..

I doubt that I should create plugin for thumb also. Cannot ArchitectureArm handle it?
And what about big-endian versions?

Wed, Jun 27, 1:05 AM
tatyana-krasnukha added reviewers for D48623: WIP: Move architecture-specific address adjustment to architecture plugins.: jingham, labath, clayborg.
Wed, Jun 27, 12:44 AM
tatyana-krasnukha updated the diff for D48623: WIP: Move architecture-specific address adjustment to architecture plugins..

Removed unrelated changes from the patch.

Wed, Jun 27, 12:42 AM
tatyana-krasnukha created D48623: WIP: Move architecture-specific address adjustment to architecture plugins..
Wed, Jun 27, 12:29 AM

Jun 22 2018

tatyana-krasnukha added inline comments to D48384: WIP: Let OptionArgParser fix up address arguments depending on intended use..
Jun 22 2018, 8:16 AM
tatyana-krasnukha retitled D48384: WIP: Let OptionArgParser fix up address arguments depending on intended use. from Let CommandObjectDisassemble fix unaligned addresses to WIP: Let OptionArgParser fix up address arguments depending on intended use..
Jun 22 2018, 5:49 AM
tatyana-krasnukha updated the diff for D48384: WIP: Let OptionArgParser fix up address arguments depending on intended use..

TODO: workaround for ARM.

Jun 22 2018, 5:46 AM

Jun 20 2018

tatyana-krasnukha added reviewers for D48384: WIP: Let OptionArgParser fix up address arguments depending on intended use.: clayborg, jingham.
Jun 20 2018, 11:34 AM
tatyana-krasnukha created D48384: WIP: Let OptionArgParser fix up address arguments depending on intended use..
Jun 20 2018, 11:32 AM

Jun 7 2018

tatyana-krasnukha updated the diff for D47728: Fix DynamicRegisterInfo copying/moving issue.

Get rid of additional structure.
Update pointers only if finalized info is passed to the function.

Jun 7 2018, 6:31 AM

Jun 5 2018

tatyana-krasnukha added a comment to D47728: Fix DynamicRegisterInfo copying/moving issue.

Hello Greg,

Jun 5 2018, 5:26 AM

Jun 4 2018

tatyana-krasnukha added a reviewer for D47728: Fix DynamicRegisterInfo copying/moving issue: clayborg.
Jun 4 2018, 10:26 AM
tatyana-krasnukha created D47728: Fix DynamicRegisterInfo copying/moving issue.
Jun 4 2018, 10:20 AM

Apr 13 2018

tatyana-krasnukha added a comment to D45309: [ARC] Add LImm support for J/JL.

It looks ready to land. I can do it for you, if needed.

Apr 13 2018, 2:55 AM

Apr 6 2018

tatyana-krasnukha added a comment to D45309: [ARC] Add LImm support for J/JL.

Hello Yan,

Apr 6 2018, 1:17 PM

Feb 23 2018

tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Have no idea how to know about working around breakpoints for read and write separately. Just rely on support of Z-packets for now.
This expectation could be fair, however...

Feb 23 2018, 2:59 PM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

Got it. Yes, you are right. At least debugserver works around breakpoints by himself while writing memory.
I will handle this case.

Feb 23 2018, 1:24 PM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

May be I misunderstand your question, but I checked, that all targets of both lldb-server and debugserver read opcode from memory and save it, when enable software breakpoint.

Feb 23 2018, 1:14 PM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Change ForEach return type (bool -> void)

Feb 23 2018, 11:48 AM
tatyana-krasnukha added inline comments to D39967: Disable breakpoints before writing memory and re-enable after..
Feb 23 2018, 11:21 AM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Remove Optional from return type of FindInRange

Feb 23 2018, 2:41 AM

Feb 22 2018

tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Fix naming

Feb 22 2018, 3:52 PM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Remove Guard class completely

Feb 22 2018, 3:43 PM
tatyana-krasnukha added inline comments to D39967: Disable breakpoints before writing memory and re-enable after..
Feb 22 2018, 3:38 PM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

It might be true that allowing the use of manual lock and unlock is unsafe, but adding additional code also has some cost.

Feb 22 2018, 3:22 PM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Update according suggestions above

Feb 22 2018, 3:21 PM
tatyana-krasnukha added inline comments to D39967: Disable breakpoints before writing memory and re-enable after..
Feb 22 2018, 2:49 PM
tatyana-krasnukha added inline comments to D39967: Disable breakpoints before writing memory and re-enable after..
Feb 22 2018, 2:34 PM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Use Disable|EnableBreakpointSite instead of Disable|EnableSoftwareBreakpoint.
Make BreakpointSiteList::ForEach callbacks return bool.

Feb 22 2018, 2:20 PM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

So one issue with this is some things, like GDB servers, might not need you to disable breakpoints in a range because they actually set the breakpoint for you and you don't know what opcode they used. I am hoping this works with that and doesn't cause us to manually write to memory when we don't need to by forcing every process subclass to always to the manual re-writing of the breakpoint opcodes.

Feb 22 2018, 2:20 PM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

diff with more context

Feb 22 2018, 4:37 AM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

pass callbacks by const-reference

Feb 22 2018, 3:52 AM
tatyana-krasnukha retitled D39967: Disable breakpoints before writing memory and re-enable after. from Refactoring of MemoryWrite function to Disable breakpoints before writing memory and re-enable after..
Feb 22 2018, 12:54 AM
tatyana-krasnukha added reviewers for D39967: Disable breakpoints before writing memory and re-enable after.: labath, jasonmolenda.
Feb 22 2018, 12:51 AM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Disable breakpoints before writing memory and re-enable after.

Feb 22 2018, 12:47 AM

Feb 14 2018

tatyana-krasnukha added a comment to D43089: clang: Add ARCTargetInfo.

Sorry, =default is not applicable in these cases, of course.

Feb 14 2018, 5:33 AM

Feb 9 2018

tatyana-krasnukha added a comment to D43089: clang: Add ARCTargetInfo.

This is what I could note

Feb 9 2018, 3:12 PM
tatyana-krasnukha added a comment to D43089: clang: Add ARCTargetInfo.

Hello Pete,

Feb 9 2018, 2:38 PM

Jan 23 2018

tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

Cannot promise that I'll do it (with all tests) quickly, but I'll do.

Jan 23 2018, 8:42 AM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

I completely agree with your point, but why isn't enough just to return an error about breakpoints in the area user wants to write? Or to disable breakpoints forcibly?

Jan 23 2018, 7:40 AM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

Does this functionality really belong in the client? In case of memory reads, it's the server who patches out the breakpoint opcodes (NativeProcessProtocol::ReadMemoryWithoutTrap). I think it would make sense to do this in the same place.

Jan 23 2018, 6:17 AM

Jan 22 2018

tatyana-krasnukha added a comment to D39969: Set error status in ObjectFile::LoadInMemory if it is not set .

Yes, I see... There is some inconsistency between status and returned value. That is why I wondered about this https://reviews.llvm.org/D39967#984065

Jan 22 2018, 11:38 AM
tatyana-krasnukha removed rL LLVM as the repository for D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Jan 22 2018, 11:01 AM
tatyana-krasnukha removed rL LLVM as the repository for D39967: Disable breakpoints before writing memory and re-enable after..
Jan 22 2018, 11:01 AM
tatyana-krasnukha added a dependent revision for D39967: Disable breakpoints before writing memory and re-enable after.: D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Jan 22 2018, 10:51 AM
tatyana-krasnukha added a dependency for D39969: Set error status in ObjectFile::LoadInMemory if it is not set : D39967: Disable breakpoints before writing memory and re-enable after..
Jan 22 2018, 10:51 AM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

What about having 2 versions:

  1. WriteMemory(..., bool force = false), that fails if there are breakpoints in the area. Let user decide what to do.

If force == true just call DoWriteMemory without checking on breakpoints. It is needed while writing on stack, for example (and to all sections beside .text ?).
All usages should be followed with if (status.Success()).

  1. WriteMemorySavingBreakpoints for that cases where it is really needed. It will not return bytes_written, only status.
Jan 22 2018, 10:47 AM

Jan 17 2018

tatyana-krasnukha added a comment to D39969: Set error status in ObjectFile::LoadInMemory if it is not set .

Greg, Abid, if you disagree with the changes, let me know and I'll close the revision.

Jan 17 2018, 10:21 AM
tatyana-krasnukha closed D42172: [ARC] Add missing condition codes..
Jan 17 2018, 10:00 AM
tatyana-krasnukha created D42172: [ARC] Add missing condition codes..
Jan 17 2018, 6:15 AM

Jan 11 2018

tatyana-krasnukha closed D41584: Check existence of each required component during construction of LLVMCDisassembler..
Jan 11 2018, 4:07 AM
tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..

Fixed comment spacing. Changed the comment slightly (words “I added this class to…” sound now like I did this, so, replaced it with passive voice).

Jan 11 2018, 3:46 AM

Jan 10 2018

tatyana-krasnukha added a comment to D41584: Check existence of each required component during construction of LLVMCDisassembler..

There is the function GetDisasmToUse in InstructionLLVMC class that can return nullptr. But this case is not handled in any usage. I suppose that caller functions cannot be invoked if !DisassemblerLLVMC::IsValid(). But it still looks dangerous for me. May be GetDisasmToUse should assert if neither m_disasm_up nor m_alternate_disasm_up exists? And may return a reference then.

Jan 10 2018, 6:42 AM
tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..

Added "_up" suffix to each unique_ptr, renamed MCDisasmToolset to MCDisasmInstance.

Jan 10 2018, 6:16 AM
tatyana-krasnukha added inline comments to D41584: Check existence of each required component during construction of LLVMCDisassembler..
Jan 10 2018, 4:09 AM

Jan 9 2018

tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..

Added function Create that creates an instance of LLVMCDisassembler only if pass all constraints.
Moved LLVMCDisassembler declaration to .cpp file, renamed to MCDisasmToolset (is this name ok?).
Added const qualifier to some functions of the class.
I also had the courage to remove ‘_ap’ suffixes from unique pointers.

Jan 9 2018, 10:56 AM
tatyana-krasnukha added a comment to D41584: Check existence of each required component during construction of LLVMCDisassembler..

Thank you, Pavel.
Would you mind if I move LLVMCDisassembler declaration in .cpp also? It looks like perfect candidate for pimpl.

Jan 9 2018, 5:33 AM

Dec 26 2017

tatyana-krasnukha updated the diff for D41584: Check existence of each required component during construction of LLVMCDisassembler..
Dec 26 2017, 9:00 AM
tatyana-krasnukha created D41584: Check existence of each required component during construction of LLVMCDisassembler..
Dec 26 2017, 8:11 AM

Nov 28 2017

tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete,
Now I have commit after approval access and would land this revision. May I do it now?

Nov 28 2017, 2:37 AM

Nov 22 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

When I added instructions, I didn't care about properties like isBranch, isBarrier, etc., because didn't know its purpose. But it was found that debugger cannot step over a range of instructions correctly without this knowing, thus, I've added appropriate fields to instructions.

Nov 22 2017, 9:38 AM
tatyana-krasnukha closed D40022: Remove extra minuses from command option.
Nov 22 2017, 9:07 AM
tatyana-krasnukha updated the diff for D40022: Remove extra minuses from command option.

Made diff with full paths (studying to use arcanist)...

Nov 22 2017, 9:06 AM
tatyana-krasnukha updated the diff for D40022: Remove extra minuses from command option.

Things that didn't require review was committed separately.

Nov 22 2017, 7:28 AM

Nov 16 2017

tatyana-krasnukha added a comment to D39742: Add backend name to Target to enable runtime info to be fed back into TableGen.

Build for ARC fails, fix TargetInfo for this target please.

Nov 16 2017, 6:04 AM

Nov 15 2017

tatyana-krasnukha added inline comments to D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Nov 15 2017, 3:10 AM
tatyana-krasnukha added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

Still have a feeling that it is not enough to clarify for function users that "if (bytes_written != bytes_to_write)" is not always criteria of error, as well as "if (error.Success())" doesn't mean that whole area was written to memory...

Nov 15 2017, 12:17 AM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Same for comment in the header file.

Nov 15 2017, 12:01 AM

Nov 14 2017

tatyana-krasnukha added a comment to D40022: Remove extra minuses from command option.

I have not commit access, that is why I've decided to group all typos in one patch...

Nov 14 2017, 10:59 PM
tatyana-krasnukha updated the diff for D39969: Set error status in ObjectFile::LoadInMemory if it is not set .

Removed clang-format changes.

Nov 14 2017, 10:55 PM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Sorry for wrong formatting, I've removed it.

Nov 14 2017, 10:45 PM
tatyana-krasnukha added inline comments to D40022: Remove extra minuses from command option.
Nov 14 2017, 5:22 AM
tatyana-krasnukha created D40022: Remove extra minuses from command option.
Nov 14 2017, 5:20 AM
tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete,

Nov 14 2017, 4:31 AM

Nov 13 2017

tatyana-krasnukha created D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Nov 13 2017, 10:45 AM
tatyana-krasnukha added inline comments to D39967: Disable breakpoints before writing memory and re-enable after..
Nov 13 2017, 10:32 AM
tatyana-krasnukha created D39967: Disable breakpoints before writing memory and re-enable after..
Nov 13 2017, 10:29 AM

Nov 8 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Removed accidentally added file.

Nov 8 2017, 11:44 AM
tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Use type of instruction for its fields instead of 'auto'.

Nov 8 2017, 11:28 AM
tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

I agree that matching the style in other backends is very important, but it is hard to be consistent with last, because it was written long before even c++11 was released...

Nov 8 2017, 11:25 AM
tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete,

Nov 8 2017, 10:40 AM

Oct 12 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Corrupted it by merging...

Oct 12 2017, 9:57 AM
tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Thanks for comment, Pete!

Oct 12 2017, 9:22 AM

Oct 6 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Forgot to change decoder method name.

Oct 6 2017, 9:19 AM

Sep 22 2017

tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Applied fixes from 2nd comment.

Sep 22 2017, 10:39 AM
tatyana-krasnukha added inline comments to D37983: Add instruction subset for the ARC backend.
Sep 22 2017, 10:37 AM
tatyana-krasnukha updated the diff for D37983: Add instruction subset for the ARC backend.

Added tests, fixed ARCDisassembler.cpp according suggestions.

Sep 22 2017, 10:15 AM

Sep 19 2017

tatyana-krasnukha added a comment to D37983: Add instruction subset for the ARC backend.

Hi Pete, thank you for review!

Sep 19 2017, 6:35 AM