- User Since
- Apr 28 2017, 8:23 AM (177 w, 5 d)
Mon, Sep 14
Looks reasonable to me.
Aug 5 2020
I'm not familiar with the z/OS target, so I cannot check the correctness of the target-specific changes. The overall patch looks good.
Aug 4 2020
I see. The option "/Zc:__cplusplus" affects GTEST_LANG_CXX11 but not GTEST_HAS_TR1_TUPLE. I didn't have warnings just because my LLVM fork uses C++17.
Aug 3 2020
The option "/Zc:__cplusplus" solves this problem. With this option passed, Gtest doesn't try using namespace tr1. I don't have such warnings if pass this option.
LLVM documentation says: "You will need Visual Studio 2017 or higher, with the latest Update installed". Does this mean Visual Studio 2017 version 15.9? Because the /Zc:__cplusplus option is available starting in Visual Studio 2017 version 15.7.
Thank you! I fixed the commit title and description as you suggested.
Jul 30 2020
TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check.
Jul 29 2020
Ups... Pushed it occationaly with the other patchs.
Un-skip TestRequireHWBreakpoints.py on Windows, now it works as expected.
It also fixes warnings about using deprecated std::tr1, which became errors in VS 2019, produced while compiling lldbUtilityHelpers project (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17887/steps/test/logs/stdio).
Jul 24 2020
I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that.
@omjavaid, thank you for verifying this!
Jul 22 2020
BreakpointSite::IntersectsRange returns false for hardware breakpoints, that's why the assertion fails.
Jul 21 2020
Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64.
Jul 20 2020
No updates, just to trigger rebasing onto master where tests should be already fixed.
Jul 17 2020
Mar 26 2020
Lit option --timeout partly solves the problem, so these changes are unnecessary.
Mar 20 2020
Mar 17 2020
Mar 16 2020
Mar 12 2020
platform.module-cache-directory should be fixed by rGfe74df01a909.
Thank you for details, I'm looking at these failures, however, I'm not able to debug on the macOS.
Mar 5 2020
Removed TestFixIts.py as those changes relate to the parent revision.
Mar 4 2020
Added --all property to settings clear + added a test
Mar 3 2020
Moved settings clearing to the separate patch D75537
Clear all settings during a test's setUp
As Pavel wrote, there are global properties that all debuggers share. That's why this approach doesn't work for me.
I'm going to add settings clear mode without arguments that will revert all the settings to their default values.
@jingham Is it Ok with you?
Feb 21 2020
I like this idea and ready to implement, but I'm not aware of the reasons why the current implementation was chosen. Suppose that initializing the Debugger for each test will slow down the test-suite significantly.
Feb 20 2020
Feb 18 2020
Closed by commit b624b7dfd087
Closed by commit 185ef697ef5c
Feb 14 2020
Just realized that BreakpointResolverScripted::CreateImplementationIfNeeded should work when m_breakpoint == nullptr.
GetBreakpoint with assertion is not suitable here, so I pass the breakpoint as a parameter.
Moved assertion into GetBreakpoint().