- User Since
- Apr 28 2017, 8:23 AM (107 w, 4 d)
Fri, Apr 26
Apr 3 2019
Hi, currently we have a private build server that executes the test-suite on ARC. There are failures for now, mostly due to unimplemented features for ARC like expressions support.
I'll take care of a public build-bot, if it is required.
Mar 27 2019
Mar 26 2019
Kind reminder. I believe all discussions have been resolved.
Mar 6 2019
Run into a few compilation errors building on Windows with msvc.
Mar 5 2019
Mar 1 2019
Feb 26 2019
Feb 25 2019
Removed new lines from MIUtilString.h
Feb 20 2019
LLDB_PROJECT_ROOT -> LLDB_SOURCE_DIR
Thanks for the review!
Feb 16 2019
Thank you for mentioning StringRef, you gave me the idea to keep pointers check inside the CMIUtilString to obviate undefined behavior. This is the best place to do it, however, a caller still should examine pointers he passes to CMIUtilString::Format as the ellipsis parameter.
Feb 14 2019
Thanks for the review!
Feb 11 2019
Yes, of course!
These also don't relate directly but intersect with your changes:
A few modernizations which though don't directly relate to make_shared:
Feb 6 2019
Jan 31 2019
Updated file headers to reflect the new license;
Updated according to the last revision of D55718.
Changed configuration register handling logic: if an RSP-server doesn't provide a register, don't count this as a failure - just use default values for flags.
Jan 24 2019
Updated new file headers to reflect the new license
Moved ARC flags enum inside the ArchitectureArc class;
Jan 23 2019
Updated according to D55718
Jan 21 2019
Keep trying to hide the processor's specifics from the ProcessGDBRemote
Why lldb_private::Flags is required? std::bitset provides the same functionality and even more.
Jan 19 2019
Jan 18 2019
After all, I moved ARC configuring routines to the ArchitechtureArc plug-in.
Jan 17 2019
Addressed the comment
Added a list of registers with correct dwarf numbers
Removed registers adjustment, dwarf numbers are corrected by AugmentRegisterInfoViaABI now.
Jan 14 2019
Friendly ping. I would like to have this in the nearest release.
It is fixed.
Dec 19 2018
Rid off of including std::vector at the cost of adding a wrapper class that can be forward declared.
Without this, it is not possible to do https://reviews.llvm.org/D55472#inline-491159
Clear m_register_info if it is incorrect.
Removed dump file from the patch
Add a test
Minor change: replace using with typedef since old swig versions don't understand c++11's aliases.
ARCflags are used by ABISysV_arc (related patch D55724). I would be glad to move it to architecture plugin, but I ought to add SetFlags/GetFlags to Architecture interface in this case. Then we'll have the same members in ArchSpec and in Architecture, that may look confusing.
Dec 18 2018
Addressed more comments
Replace vector of unique pointers with vector of values, revert some API changes, remove MinidumpParser changes.
I will put overridden GetMemoryRegions in a separate patch.
Addressed review comments
My intent was to move ARC-specific code to the architecture plugin as much as possible, but it requires to add undesired dependencies to Architecture interface. So, you are right, it seems to be better to keep these functions in ProcessGDBRemote.cpp and remove ArcArchitecture plugin at all.
Dec 14 2018
Dec 13 2018
Dec 10 2018
Thanks to all for comments!
Don't you mind to take overridden GetMemoryRegions in this patch so that I can remove all minidump-related changes from D55472?
Without overriding Process::GetMemoryRegions still does a lot of unnecessary job (FindMemoryRegion for each element in the vector).
With these changes, it may just return m_regions (if not empty), doesn't it?
Dec 7 2018
Nov 26 2018
Minor change: remove splitting big numeric arguments on 32-bit integers. Backend lowering code does this work.
Oct 10 2018
Sep 28 2018
Modifies Driver::ParseArgs checks
Sep 27 2018
Sep 26 2018
It seems you are speaking about OptionDefinition, not PropertyDefinition. I was going to create a separate revision for it. Should I add OptionDefinition-related changes here?
Hmm... There is no such logic left, isn't it?
If you mean iterating OptionValueProperties::m_properties vector, I can replace cycles with range based for loop, but this doesn't seem to be related to these changes.
Sep 25 2018
Now works with Python 3.1 too. LGTM.
Forget that the test calls default python, not which was passed to cmake. So, it is enough to replace (3,0) pair with (3,2) to fix.
It seems I ran into an unrelated issue like this. If the revision works for others, you may ignore this.
Sorry, it was added in 3.2. Anyway, the test fails due to __init__() got an unexpected keyword argument 'pass_fds'.
Could you look at it again, please?
Adding address adjustment to OptionArgParser doesn't help when disassembling is requested through API. Close the revision, since I have not a centralized solution for now.
Sep 24 2018
A lot of tests are failing with Python 3, at least on CentOS. So, I agree the problem doesn't block this review.
Thanks for the information I missed. Removed all changes of API and joined together more typemap implementations.
Sep 21 2018
Thanks for your patience;)
LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't propagate lldbHost's include directories to lldbCore and lldbInterpreter.
For lldbHost itself, I had to use PUBLIC, because its sources require includes libedit headers and unittests inherit this path too.
Make overriding functions public.