Page MenuHomePhabricator

tatyana-krasnukha (Tatyana Krasnukha)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2017, 8:23 AM (142 w, 22 h)

Recent Activity

Fri, Jan 10

tatyana-krasnukha committed rG3eea082535e2: [lldb][tests] Make it possible to expect failure for a whole category (authored by tatyana-krasnukha).
[lldb][tests] Make it possible to expect failure for a whole category
Fri, Jan 10, 6:38 AM
tatyana-krasnukha closed D71906: [lldb][tests] Make it possible to expect failure for a whole category.
Fri, Jan 10, 6:38 AM · Restricted Project
tatyana-krasnukha committed rGe20a3b9b6c02: [lldb][tests][NFC] Unify variable naming convention (authored by tatyana-krasnukha).
[lldb][tests][NFC] Unify variable naming convention
Fri, Jan 10, 6:38 AM
tatyana-krasnukha committed rGb3af8ab7f83c: [lldb][tests] Cleanup '.categories' (authored by tatyana-krasnukha).
[lldb][tests] Cleanup '.categories'
Fri, Jan 10, 5:47 AM
tatyana-krasnukha committed rG9ba151274869: [lldb][test] NFC, re-use _getTestPath() function (authored by tatyana-krasnukha).
[lldb][test] NFC, re-use _getTestPath() function
Fri, Jan 10, 5:37 AM
tatyana-krasnukha committed rGe4d672971030: [lldb][tests] Take into account all parent's categories when traverse folders… (authored by tatyana-krasnukha).
[lldb][tests] Take into account all parent's categories when traverse folders…
Fri, Jan 10, 5:37 AM
tatyana-krasnukha closed D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards.
Fri, Jan 10, 5:36 AM · Restricted Project

Thu, Jan 9

tatyana-krasnukha updated the diff for D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards.

Stop iterating when reach the top-level test folder

Thu, Jan 9, 7:34 AM · Restricted Project

Mon, Jan 6

tatyana-krasnukha updated the diff for D71906: [lldb][tests] Make it possible to expect failure for a whole category.

Increased number of lines of context.

Mon, Jan 6, 8:31 AM · Restricted Project

Thu, Dec 26

tatyana-krasnukha created D71906: [lldb][tests] Make it possible to expect failure for a whole category.
Thu, Dec 26, 8:41 AM · Restricted Project
tatyana-krasnukha created D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards.
Thu, Dec 26, 8:41 AM · Restricted Project
tatyana-krasnukha committed rGdb1fa62bf824: [lldb][test] Don't include "test_common.h" in the debug macros test (authored by tatyana-krasnukha).
[lldb][test] Don't include "test_common.h" in the debug macros test
Thu, Dec 26, 7:54 AM
tatyana-krasnukha committed rGe2d3eb00ccd8: [lldb] Specify unsigned underlying type for an enumeration explicitly (authored by tatyana-krasnukha).
[lldb] Specify unsigned underlying type for an enumeration explicitly
Thu, Dec 26, 7:54 AM
tatyana-krasnukha committed rGb0469eede285: [lldb][NFC] Move lock scope where it should begin (authored by tatyana-krasnukha).
[lldb][NFC] Move lock scope where it should begin
Thu, Dec 26, 7:54 AM
tatyana-krasnukha committed rGb7c45ac35295: [lldb][NFC] Add "lldb-vscode" to all_categories (authored by tatyana-krasnukha).
[lldb][NFC] Add "lldb-vscode" to all_categories
Thu, Dec 26, 7:54 AM
tatyana-krasnukha committed rG04359f48f021: [lldb][NFC] Simplify if-return (authored by tatyana-krasnukha).
[lldb][NFC] Simplify if-return
Thu, Dec 26, 7:54 AM
tatyana-krasnukha committed rGa58bd0e42cf2: [lldb][tests] Platform triple can be None (authored by tatyana-krasnukha).
[lldb][tests] Platform triple can be None
Thu, Dec 26, 7:54 AM
tatyana-krasnukha committed rGf57b35af2f00: [lldb][tests] Posix function strdup requires macro _POSIX_C_SOURCE (authored by tatyana-krasnukha).
[lldb][tests] Posix function strdup requires macro _POSIX_C_SOURCE
Thu, Dec 26, 7:53 AM

Dec 9 2019

tatyana-krasnukha committed rGd32484f40cbe: [lldb][CMake] Fix build for the case of custom libedit installation (authored by tatyana-krasnukha).
[lldb][CMake] Fix build for the case of custom libedit installation
Dec 9 2019, 9:28 AM

Dec 5 2019

tatyana-krasnukha added inline comments to D69589: [lldb] Refactor all POST_BUILD commands into targets.
Dec 5 2019, 4:29 AM · Restricted Project

Nov 21 2019

tatyana-krasnukha committed rGffc4ff868fcc: [lldb][NFC] Remove test directory completely (authored by tatyana-krasnukha).
[lldb][NFC] Remove test directory completely
Nov 21 2019, 4:12 AM

Nov 12 2019

tatyana-krasnukha committed rG3130a88137dd: [lldb][test] Macros in expressions require DWARF 5 (authored by tatyana-krasnukha).
[lldb][test] Macros in expressions require DWARF 5
Nov 12 2019, 3:06 AM

Nov 1 2019

tatyana-krasnukha added a comment to D67227: [lldb] Extend and document TestIRInterpreter.py.

I mean, when a process is not able to allocate memory, it cannot JIT, but still can interpret. Should the test report failure in this case?

Nov 1 2019, 9:29 AM · Restricted Project
tatyana-krasnukha added a comment to D67227: [lldb] Extend and document TestIRInterpreter.py.

Another problem of the test_ir_interpreter is that it fails even when JIT fails despite it should test the interpreter.

Nov 1 2019, 7:25 AM · Restricted Project

Oct 17 2019

tatyana-krasnukha committed rG92e498d58cf4: [ARC] Add SystemV ABI (authored by tatyana-krasnukha).
[ARC] Add SystemV ABI
Oct 17 2019, 8:18 AM
tatyana-krasnukha committed rGfaf6b2543e47: [ARC] Basic support in gdb-remote process plugin (authored by tatyana-krasnukha).
[ARC] Basic support in gdb-remote process plugin
Oct 17 2019, 8:17 AM
tatyana-krasnukha closed D55724: [ARC] Add SystemV ABI.
Oct 17 2019, 8:17 AM · Restricted Project
tatyana-krasnukha closed D55718: [ARC] Basic support in gdb-remote process plugin.
Oct 17 2019, 8:17 AM · Restricted Project
tatyana-krasnukha updated the diff for D55724: [ARC] Add SystemV ABI.

Rebased on the current trunk.

Oct 17 2019, 7:58 AM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Removed any ARC-specific logic from the ProcessGDBRemote.cpp.

Oct 17 2019, 7:49 AM · Restricted Project

Oct 15 2019

tatyana-krasnukha accepted D68858: [lldb] Creates _liblldb symlink from cmake.

Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode.

Oct 15 2019, 6:58 AM · Restricted Project

Oct 14 2019

tatyana-krasnukha added a comment to D68858: [lldb] Creates _liblldb symlink from cmake.

@hhb, please, take a look. Slightly changed your patch to make it work for Visual Studio.

Oct 14 2019, 11:58 AM · Restricted Project

Oct 12 2019

tatyana-krasnukha added inline comments to D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 12 2019, 2:54 AM · Restricted Project

Oct 11 2019

tatyana-krasnukha added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 11 2019, 6:59 AM · Restricted Project
tatyana-krasnukha abandoned D68719: Fix issue when building with Visual Studio.

Fixed by reverting the initial commit.

Oct 11 2019, 5:07 AM · Restricted Project

Oct 10 2019

tatyana-krasnukha retitled D68719: Fix issue when building with Visual Studio from Fix build with Visual Studio to Fix issue when building with Visual Studio.
Oct 10 2019, 9:18 AM · Restricted Project
tatyana-krasnukha added a comment to D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.

Please see my comment D68719#1703785.

Oct 10 2019, 9:18 AM · Restricted Project
tatyana-krasnukha added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 10 2019, 7:53 AM · Restricted Project
tatyana-krasnukha added a comment to D68719: Fix issue when building with Visual Studio.

Hi Haibo,

Oct 10 2019, 7:53 AM · Restricted Project

Oct 9 2019

tatyana-krasnukha created D68719: Fix issue when building with Visual Studio.
Oct 9 2019, 11:26 AM · Restricted Project

Oct 8 2019

tatyana-krasnukha accepted D68606: [test] Split LLDB tests into filecheck, unittest and dotest..

I have longed for this change, thank you!

Oct 8 2019, 8:07 AM · Restricted Project

Sep 26 2019

tatyana-krasnukha committed rGa11668e87b90: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP (authored by tatyana-krasnukha).
Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP
Sep 26 2019, 3:57 AM

Sep 25 2019

tatyana-krasnukha updated the diff for D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.

Removed using UnixSignals::ShouldSuppress, just check if a signal is either SIGINT or SIGSTOP.

Sep 25 2019, 6:39 AM · Restricted Project, Restricted Project
tatyana-krasnukha added a comment to D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.

To Pavel: this problem is not only about the behavior of process attach, but for process launch too (and possibly something else). That's why I'm trying to move this logic out of specific commands.

Sep 25 2019, 6:29 AM · Restricted Project, Restricted Project

Sep 24 2019

tatyana-krasnukha added inline comments to D67965: Have ABI plugins vend llvm MCRegisterInfo data.
Sep 24 2019, 10:17 AM · Restricted Project
tatyana-krasnukha committed rG5a4355324e1b: [NFC] Fix typo in the "kind" description for the software single-step breakpoint (authored by tatyana-krasnukha).
[NFC] Fix typo in the "kind" description for the software single-step breakpoint
Sep 24 2019, 7:24 AM

Sep 20 2019

tatyana-krasnukha added inline comments to D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.
Sep 20 2019, 10:41 AM · Restricted Project, Restricted Project
tatyana-krasnukha updated the diff for D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.

Added a test

Sep 20 2019, 10:32 AM · Restricted Project, Restricted Project
tatyana-krasnukha added a comment to D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.

The flag m_abnormal_stop_was_expected was added in the commit to avoid stop on crash because attach always stops
with a SIGSTOP on OSX. I faced the same issue with SIGTRAP and SIGSTOP sent by a gdb-remote stub on some commands. This patch filters out such harmless signals instead of setting the flag everywhere in commands.

Sep 20 2019, 7:29 AM · Restricted Project, Restricted Project

Sep 19 2019

tatyana-krasnukha created D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.
Sep 19 2019, 3:33 PM · Restricted Project, Restricted Project

Aug 27 2019

tatyana-krasnukha committed rG900f9ba21717: [lldb] Fix x86 compilation (authored by tatyana-krasnukha).
[lldb] Fix x86 compilation
Aug 27 2019, 10:34 AM
tatyana-krasnukha accepted D66655: [lldb] Fix x86 compilation .

LGTM

Aug 27 2019, 7:06 AM · Restricted Project, Restricted Project

Aug 26 2019

tatyana-krasnukha added a comment to D66655: [lldb] Fix x86 compilation .

A few typos remained after copy-pasting

Aug 26 2019, 8:57 AM · Restricted Project, Restricted Project
tatyana-krasnukha committed rG55aafa35ea33: [ProcessWindows] Remove equivalent macros (authored by tatyana-krasnukha).
[ProcessWindows] Remove equivalent macros
Aug 26 2019, 6:37 AM
tatyana-krasnukha added a comment to D66655: [lldb] Fix x86 compilation .

Macros __x86_64__ and _M_X64 are more common than AMD-branded, though there is no functional difference (unless using old versions of the Intel compiler).

Aug 26 2019, 6:13 AM · Restricted Project, Restricted Project

Aug 24 2019

tatyana-krasnukha added inline comments to D66655: [lldb] Fix x86 compilation .
Aug 24 2019, 9:03 AM · Restricted Project, Restricted Project

Jul 31 2019

tatyana-krasnukha committed rGe98b4188dc6e: [ProcessWindows] Choose a register context file by preprocessor (authored by tatyana-krasnukha).
[ProcessWindows] Choose a register context file by preprocessor
Jul 31 2019, 5:01 AM

Jul 30 2019

tatyana-krasnukha added a comment to D65409: [ProcessWindows] Choose a register context file by prepocessor.

I wonder if directories x86 and x64 are needed. Should I remove them to make hierarchy consistent with D63165?

Jul 30 2019, 10:04 AM · Restricted Project, Restricted Project
tatyana-krasnukha updated the diff for D65409: [ProcessWindows] Choose a register context file by prepocessor.

Addressed comments

Jul 30 2019, 9:26 AM · Restricted Project, Restricted Project

Jul 29 2019

tatyana-krasnukha added inline comments to D65409: [ProcessWindows] Choose a register context file by prepocessor.
Jul 29 2019, 11:08 AM · Restricted Project, Restricted Project
tatyana-krasnukha created D65409: [ProcessWindows] Choose a register context file by prepocessor.
Jul 29 2019, 10:44 AM · Restricted Project, Restricted Project

Jun 21 2019

tatyana-krasnukha committed rGd76c7b1c2a79: [unittests] Simplify CMakeLists with object library (authored by tatyana-krasnukha).
[unittests] Simplify CMakeLists with object library
Jun 21 2019, 4:45 AM
tatyana-krasnukha reopened D63544: Use object library if cmake supports it.

@beanz you're absolutely right, thank you.

Jun 21 2019, 4:40 AM · Restricted Project, Restricted Project

Jun 20 2019

tatyana-krasnukha committed rG36358cd3ed0f: [unittests] Use object library if cmake supports it (authored by tatyana-krasnukha).
[unittests] Use object library if cmake supports it
Jun 20 2019, 8:04 AM
tatyana-krasnukha added a comment to D60360: Dump the minimal version of cmake 3.5.0.

There is a workaround D63544 for fixing the issue in lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt without changing the minimum required cmake's version.

Jun 20 2019, 7:19 AM · Restricted Project
tatyana-krasnukha updated the diff for D63544: Use object library if cmake supports it.

Finally updated versions - target_sources supports using $<TARGET_OBJECTS:...> since CMake 3.5.0.

Jun 20 2019, 7:04 AM · Restricted Project, Restricted Project

Jun 19 2019

tatyana-krasnukha updated the diff for D63544: Use object library if cmake supports it.

As I figured out, cmake allows to use $<TARGET_OBJECTS:...> anywhere since version 3.9 (commit).

Jun 19 2019, 11:33 AM · Restricted Project, Restricted Project
tatyana-krasnukha added a comment to D63544: Use object library if cmake supports it.

It will cause some time overhead for linking a library. Linking is already formidable for the project and I'd avoid it when possible.

Jun 19 2019, 5:57 AM · Restricted Project, Restricted Project
tatyana-krasnukha added inline comments to D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.
Jun 19 2019, 5:22 AM · Restricted Project
tatyana-krasnukha created D63544: Use object library if cmake supports it.
Jun 19 2019, 5:18 AM · Restricted Project, Restricted Project

Jun 10 2019

tatyana-krasnukha committed rGf62e23d901df: [Target] Use llvm::scope_exit to restore m_suppress_stop_hooks value. (authored by tatyana-krasnukha).
[Target] Use llvm::scope_exit to restore m_suppress_stop_hooks value.
Jun 10 2019, 2:11 PM

May 21 2019

tatyana-krasnukha committed rGe0cc56e038df: [lldb-mi] Include full path in the -data-disassemble response (authored by tatyana-krasnukha).
[lldb-mi] Include full path in the -data-disassemble response
May 21 2019, 6:24 AM

Apr 26 2019

tatyana-krasnukha committed rGedebf12acfe2: Replace local utility class OnExit with llvm::scope_exit (NFC) (authored by tatyana-krasnukha).
Replace local utility class OnExit with llvm::scope_exit (NFC)
Apr 26 2019, 9:39 AM

Apr 3 2019

tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Hi, currently we have a private build server that executes the test-suite on ARC. There are failures for now, mostly due to unimplemented features for ARC like expressions support.
I'll take care of a public build-bot, if it is required.

Apr 3 2019, 6:15 AM · Restricted Project

Mar 27 2019

tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

TBE, the best way would be no not even hardcode that info but ask llvm about these things.

Mar 27 2019, 12:39 PM · Restricted Project
tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Back in 2015 I added some code in r247121 that would fill in eh_frame and dwarf register numbers from the ABI plugin if the remote stub didn't provide them in ProcessGDBRemote's AugmentRegisterInfoViaABI. It might be better for ARC to hardcode these generic register additions some place like that.

Mar 27 2019, 8:20 AM · Restricted Project

Mar 26 2019

tatyana-krasnukha added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Kind reminder. I believe all discussions have been resolved.

Mar 26 2019, 6:24 AM · Restricted Project

Mar 6 2019

tatyana-krasnukha committed rG1b6700eff4a9: Re-apply "Fix embedded Python initialization according to changes in version 3. (authored by tatyana-krasnukha).
Re-apply "Fix embedded Python initialization according to changes in version 3.
Mar 6 2019, 9:28 AM
tatyana-krasnukha added reviewers for D59015: [lldb-mi] Include full path in the -data-disassemble response: ki.stfu, deepak2427, abidh.
Mar 6 2019, 7:03 AM · Restricted Project, Restricted Project
tatyana-krasnukha added a comment to D57475: [Reproducers] Add SBReproducer macros.

Run into a few compilation errors building on Windows with msvc.

Mar 6 2019, 2:30 AM · Restricted Project

Mar 5 2019

tatyana-krasnukha committed rG622862987f34: Revert "Fix embedded Python initialization according to changes in version 3.7" (authored by tatyana-krasnukha).
Revert "Fix embedded Python initialization according to changes in version 3.7"
Mar 5 2019, 7:27 AM
tatyana-krasnukha committed rGb30c1d571bde: Fix embedded Python initialization according to changes in version 3.7 (authored by tatyana-krasnukha).
Fix embedded Python initialization according to changes in version 3.7
Mar 5 2019, 3:18 AM

Mar 1 2019

tatyana-krasnukha created D58833: Fix embedded Python initialization according to changes in version 3.7.
Mar 1 2019, 10:16 AM · Restricted Project, Restricted Project

Feb 26 2019

tatyana-krasnukha committed rG9e1929305c82: Fix short options syntax in Minidump test (authored by tatyana-krasnukha).
Fix short options syntax in Minidump test
Feb 26 2019, 7:40 AM
tatyana-krasnukha committed rGf388d17d7cad: Fix error handling in Options::Parse (authored by tatyana-krasnukha).
Fix error handling in Options::Parse
Feb 26 2019, 6:51 AM

Feb 25 2019

tatyana-krasnukha committed rGa20bd2735e0e: [lldb-mi] Return source line number in proper format (authored by tatyana-krasnukha).
[lldb-mi] Return source line number in proper format
Feb 25 2019, 10:32 AM
tatyana-krasnukha committed rG96585d11fbf5: [lldb-mi] Fix conversion warning for 64-bit build (authored by tatyana-krasnukha).
[lldb-mi] Fix conversion warning for 64-bit build
Feb 25 2019, 10:24 AM
tatyana-krasnukha committed rG2a4c1f3e5b28: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment (authored by tatyana-krasnukha).
[lldb-mi] Check raw pointers before passing them to std::string ctor/assignment
Feb 25 2019, 8:42 AM
tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Removed new lines from MIUtilString.h

Feb 25 2019, 8:38 AM · Restricted Project

Feb 20 2019

tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

LLDB_PROJECT_ROOT -> LLDB_SOURCE_DIR

Feb 20 2019, 10:21 AM · Restricted Project
tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Thanks for the review!

Feb 20 2019, 9:49 AM · Restricted Project

Feb 16 2019

tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Thank you for mentioning StringRef, you gave me the idea to keep pointers check inside the CMIUtilString to obviate undefined behavior. This is the best place to do it, however, a caller still should examine pointers he passes to CMIUtilString::Format as the ellipsis parameter.

Feb 16 2019, 8:02 PM · Restricted Project
tatyana-krasnukha committed rGb81d715cd251: Add PythonBoolean type to the PythonDataObjects (authored by tatyana-krasnukha).
Add PythonBoolean type to the PythonDataObjects
Feb 16 2019, 10:39 AM

Feb 14 2019

tatyana-krasnukha added a comment to D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Thanks for the review!

Feb 14 2019, 12:41 PM · Restricted Project
tatyana-krasnukha added reviewers for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment: sgraenitz, jingham.
Feb 14 2019, 11:51 AM · Restricted Project
tatyana-krasnukha updated the diff for D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

Fixed misspelling

Feb 14 2019, 11:48 AM · Restricted Project

Feb 11 2019

tatyana-krasnukha added a comment to D57990: Use std::make_shared in LLDB (NFC).

Yes, of course!

Feb 11 2019, 10:43 AM · Restricted Project
tatyana-krasnukha added a comment to D57990: Use std::make_shared in LLDB (NFC).

These also don't relate directly but intersect with your changes:

Feb 11 2019, 7:40 AM · Restricted Project
tatyana-krasnukha added a comment to D57990: Use std::make_shared in LLDB (NFC).

A few modernizations which though don't directly relate to make_shared:

Feb 11 2019, 6:48 AM · Restricted Project

Feb 6 2019

tatyana-krasnukha created D57817: Add PythonBoolean type to PythonDataObjects.
Feb 6 2019, 6:38 AM · Restricted Project