Allow custom handling of inline assembly output parameters and add X86
flag parameter support.
Details
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 27695 Build 27694: arc lint + arc unit
Event Timeline
FYI: only reviewed the SelectionDAGBuilder parts.
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | ||
---|---|---|
7700–7701 | Please update this comment | |
7931 | Previous code was using IA (that is the output of getCalledValue on the CallSite) rather than the instruction. From what I saw your change is correct as this parameter only gets used indirectly in diagnosePossiblyInvalidConstraint which expects an instruction. Can you confirm? | |
7943 | are manifest -> manifest |
llvm/test/CodeGen/X86/inline-asm-flag-output.ll | ||
---|---|---|
2 | FileCheck the output? I wanted to check what this patch does before going back to look at the code. :) |
Landed in r353307.
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | ||
---|---|---|
7931 | Your understanding matches mine. |
Please update this comment