This is an archive of the discontinued LLVM Phabricator instance.

ELF: Set sh_info on RelaIplt to point to the IgotPlt output section.
ClosedPublic

Authored by pcc on Jan 25 2019, 5:40 PM.

Details

Summary

Previously we were setting it to the GotPlt output section, which is
incorrect on ARM where this section is in .got. In static binaries
this can lead to sh_link being set to -1 (because there is no .got.plt)
which results in various tools rejecting the output file.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

pcc created this revision.Jan 25 2019, 5:40 PM
grimar added a subscriber: grimar.Jan 28 2019, 12:56 AM
peter.smith accepted this revision.Jan 28 2019, 3:29 AM

Looks good to me. Thanks for the fix.

This revision is now accepted and ready to land.Jan 28 2019, 3:29 AM
This revision was automatically updated to reflect the committed changes.