Page MenuHomePhabricator

GlobalISel: Implement fewerElementsVector for select
ClosedPublic

Authored by arsenm on Jan 23 2019, 11:03 AM.

Diff Detail

Event Timeline

arsenm created this revision.Jan 23 2019, 11:03 AM
volkan accepted this revision.Jan 29 2019, 7:50 PM

LGTM with a few nits.

lib/CodeGen/GlobalISel/LegalizerHelper.cpp
1409

Could you move this below the if statement?

1448

This if-else block can be simplified as:
MIRBuilder.buildSelect(DstReg, CondTy.isVector() ? Src0Regs[i] : CondReg, Src1Regs[i], Src2Regs[i]);

This revision is now accepted and ready to land.Jan 29 2019, 7:50 PM
arsenm closed this revision.Jan 29 2019, 8:19 PM
arsenm marked 2 inline comments as done.

r352601