This is an archive of the discontinued LLVM Phabricator instance.

[CodeComplete] [clangd] Fix crash on ValueDecl with a null type
ClosedPublic

Authored by ilya-biryukov on Jan 23 2019, 3:54 AM.

Event Timeline

ilya-biryukov created this revision.Jan 23 2019, 3:54 AM
kadircet accepted this revision.Jan 23 2019, 5:36 AM

LGTM

clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp
2322

nit: WorksWithNullType ? it doesn't seem like crashing

This revision is now accepted and ready to land.Jan 23 2019, 5:36 AM
ilya-biryukov marked 2 inline comments as done.
  • Rename the test
  • clang-format
ilya-biryukov added inline comments.Jan 24 2019, 2:40 AM
clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp
2322

Indeed, I've been using this naming convention for ages, but I can see why it might be confusing.

This revision was automatically updated to reflect the committed changes.