Diff Detail
Diff Detail
- Repository
- rCTE Clang Tools Extra
- Build Status
Buildable 27156 Build 27155: arc lint + arc unit
Event Timeline
Comment Actions
LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts
Comment Actions
I'm going to land this now to unbreak build. Feel free to comment or do further refactoring if the default is not the best thing to pass here. Currently, this doesn't seem to matter as it's not used in CodeCompletion.
Comment Actions
I think it is safe to use the empty one (constructed by the default constructor) here -- since getDefaults is not free, and we don't need the configurations in codeComplete, fixed in rL351826.