This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Fix broken build after r351793.
AbandonedPublic

Authored by ioeric on Jan 22 2019, 4:51 AM.

Details

Event Timeline

ioeric created this revision.Jan 22 2019, 4:51 AM
kadircet accepted this revision.Jan 22 2019, 6:26 AM
kadircet added a reviewer: hokein.

LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts

This revision is now accepted and ready to land.Jan 22 2019, 6:27 AM

LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts

I'm going to land this now to unbreak build. Feel free to comment or do further refactoring if the default is not the best thing to pass here. Currently, this doesn't seem to matter as it's not used in CodeCompletion.

ioeric abandoned this revision.Jan 22 2019, 6:34 AM

nvm, Simon beat me to it ;)

I think it is safe to use the empty one (constructed by the default constructor) here -- since getDefaults is not free, and we don't need the configurations in codeComplete, fixed in rL351826.